Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbXEXQpZ (ORCPT ); Thu, 24 May 2007 12:45:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750733AbXEXQpO (ORCPT ); Thu, 24 May 2007 12:45:14 -0400 Received: from [216.16.235.2] ([216.16.235.2]:47359 "EHLO rubicon.netdirect.ca" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750724AbXEXQpN (ORCPT ); Thu, 24 May 2007 12:45:13 -0400 X-Originating-Ip: 99.246.112.70 Date: Thu, 24 May 2007 12:43:07 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Satyam Sharma cc: Krzysztof Halasa , Adrian Bunk , Linux Kernel Mailing List Subject: Re: any value to "NORET_TYPE" macro? In-Reply-To: Message-ID: References: <20070522135927.GA2098@stusta.de> <20070522161951.GC2098@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-36.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 41 On Wed, 23 May 2007, Satyam Sharma wrote: > Actually there's another thing :-) The __attribute__((xxx)) must go > with the function _declarations_ (and not the > implementations/definitions). that's not true, AFAICT. the pattern seems to be that, in the case of declarations, attributes go at the end, as in: arch/sparc/boot/btfixupprep.c:void fatal(void) __attribute__((noreturn)); while in actual definitions, they typically go after the return type, as in arch/arm/kernel/traps.c: void __attribute__((noreturn)) __bug(const char *file, int line) { printk(KERN_CRIT"kernel BUG at %s:%d!\n", file, line); *(int *)0 = 0; /* Avoid "noreturn function does return" */ for (;;); } is that the standard that most people use? if it is, i can use that standard for the cleanup. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/