Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Huang, Ying" <ying.huang@intel.com>
To:     Qian Cai <quic_qiancai@quicinc.com>,
        Miaohe Lin <linmiaohe@huawei.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        <akpm@linux-foundation.org>, <david@redhat.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] mm/swapfile: fix possible data races of inuse_pages
References: <20220608144031.829-1-linmiaohe@huawei.com>
        <20220608144031.829-3-linmiaohe@huawei.com>
        <87edzjrcq8.fsf@yhuang6-desk2.ccr.corp.intel.com>
        <13414d6a-9e72-fb6c-f0a8-8b83ba0455de@huawei.com>
        <YrA8kxavqsDfH5R7@FVFYT0MHHV2J.usts.net>
        <09ffac27-7fe9-0977-cb33-30433e78e662@huawei.com>
        <b61771ad-9daa-741e-27e4-fdb50a7c5e38@huawei.com>
        <YrB6R5uHQaz1adhK@qian> <YrCCFwgoLKhDn7Fo@FVFYT0MHHV2J.usts.net>
        <YrDob8+9Xgig6mZw@qian>
Date:   Tue, 21 Jun 2022 09:14:00 +0800
In-Reply-To: <YrDob8+9Xgig6mZw@qian> (Qian Cai's message of "Mon, 20 Jun 2022
        17:36:47 -0400")
Message-ID: <87pmj2q0mf.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Precedence: bulk

Qian Cai <quic_qiancai@quicinc.com> writes:

> On Mon, Jun 20, 2022 at 10:20:07PM +0800, Muchun Song wrote:
>> The lock does not protect the read sides. So the write side should be
>> fixed by WRITTE_ONCE().
>
> https://lwn.net/Articles/816854/
>
> "Unmarked writes (aligned and up to word size) can be treated as if they had
> used WRITE_ONCE() by building with
> CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=y (also selected by default).
> Experience has shown that compilers are much less likely to destructively
> optimize in-kernel writes than reads. Some developers might therefore
> choose to use READ_ONCE() but omit the corresponding WRITE_ONCE(). Other
> developers might prefer the documentation benefits and long-term peace of
> mind accruing from explicit use of WRITE_ONCE()..."

Thanks for pointing me to this great article.  So although not required
by KCSAN strictly, WRITE_ONCE() is still good for documentation, etc.
Just like we have done for swap_info_struct->highest_bit, etc.

Best Regards,
Huang, Ying