Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6e27dae-0fba-cabf-465b-b2d1c258752b@squashfs.org.uk>
Date:   Tue, 21 Jun 2022 03:36:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v7 0/4] Implement readahead for squashfs
To:     Hsin-Yi Wang <hsinyi@chromium.org>,
        Matthew Wilcox <willy@infradead.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Xiongwei Song <Xiongwei.Song@windriver.com>,
        Zheng Liang <zhengliang6@huawei.com>,
        Zhang Yi <yi.zhang@huawei.com>, Hou Tao <houtao1@huawei.com>,
        Miao Xie <miaoxie@huawei.com>,
        "linux-mm @ kvack . org" <linux-mm@kvack.org>,
        "squashfs-devel @ lists . sourceforge . net" 
        <squashfs-devel@lists.sourceforge.net>,
        linux-kernel@vger.kernel.org
References: <20220617083810.337573-1-hsinyi@chromium.org>
From:   Phillip Lougher <phillip@squashfs.org.uk>
In-Reply-To: <20220617083810.337573-1-hsinyi@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17/06/2022 09:38, Hsin-Yi Wang wrote:
> Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
> disable read-ahead") mitigates the performance drop issue for squashfs
> by closing readahead for it.
> 
> This series implements readahead callback for squashfs. The previous
> discussions are in [1] and [2].

Patch series looks OK to me.

I will be offline at the Glastonbury festival from Tuesday 21 June to
Monday 27 June.

Thanks

Phillip

> 
> [1]
> https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
> [2]
> https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1
> 
> v7 adds the patch to support reading fragments in readahead call[3]. No
> changes on other patches since v6, which is included in next-20220617.
> 
> [3]
> https://patchwork.kernel.org/project/linux-mm/patch/20220617030345.24712-1-phillip@squashfs.org.uk/
> 
> Hsin-Yi Wang (2):
>    Revert "squashfs: provide backing_dev_info in order to disable
>      read-ahead"
>    squashfs: implement readahead
> 
> Phillip Lougher (2):
>    squashfs: always build "file direct" version of page actor
>    squashfs: support reading fragments in readahead call
> 
>   fs/squashfs/Makefile     |   4 +-
>   fs/squashfs/file.c       | 133 ++++++++++++++++++++++++++++++++++++++-
>   fs/squashfs/page_actor.h |  46 --------------
>   fs/squashfs/super.c      |  33 ----------
>   4 files changed, 134 insertions(+), 82 deletions(-)
>