Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 22:37:06 -0500
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Johan Hovold <johan+linaro@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: add SC8280XP platform
Message-ID: <YrE84tLOpJtzrNW4@builder.lan>
References: <20220607214113.4057684-1-bjorn.andersson@linaro.org>
 <20220607214113.4057684-3-bjorn.andersson@linaro.org>
 <79443fb4-5c09-a33f-594d-71ac93cc0317@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <79443fb4-5c09-a33f-594d-71ac93cc0317@linaro.org>
Precedence: bulk

On Wed 08 Jun 03:18 CDT 2022, Krzysztof Kozlowski wrote:

> On 07/06/2022 23:41, Bjorn Andersson wrote:
> > Introduce initial support for the Qualcomm SC8280XP platform, aka 8cx
> > Gen 3. This initial contribution supports SMP, CPUfreq, CPU cluster
> > idling, GCC, TLMM, SMMU, RPMh regulators, power-domains and clocks,
> > interconnects, some QUPs, UFS, remoteprocs, USB, watchdog, LLCC and
> > tsens.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2195 ++++++++++++++++++++++++
> >  1 file changed, 2195 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > new file mode 100644
> > index 000000000000..4143813643ad
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > @@ -0,0 +1,2195 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2022, Linaro Limited
> > + */
> > +
> > +#include <dt-bindings/clock/qcom,gcc-sc8280xp.h>
> > +#include <dt-bindings/clock/qcom,rpmh.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/interconnect/qcom,sc8280xp.h>
> > +#include <dt-bindings/mailbox/qcom-ipcc.h>
> > +#include <dt-bindings/power/qcom-rpmpd.h>
> > +#include <dt-bindings/soc/qcom,rpmh-rsc.h>
> > +#include <dt-bindings/thermal/thermal.h>
> > +
> > +/ {
> > +	interrupt-parent = <&intc>;
> > +
> > +	#address-cells = <2>;
> > +	#size-cells = <2>;
> > +
> > +	clocks {
> > +		xo_board: xo-board {
> 
> xo-board-clk
> 
> > +			compatible = "fixed-clock";
> > +			#clock-cells = <0>;
> > +			clock-frequency = <38400000>;
> 
> The clock is probably on the board, so the frequency should be rather
> defined in DTS.
> 

It's an interesting question, but I don't think it's possible to change
the rate of this clock from one board to another.

So I think it's best to keep this in the .dtsi, to avoid unnecessary
duplication.


Thanks for the feedback, will update the remaining things.

Regards,
Bjorn

> > +		};
> > +
> > +		sleep_clk: sleep-clk {
> > +			compatible = "fixed-clock";
> > +			#clock-cells = <0>;
> > +			clock-frequency = <32764>;
> > +		};
> > +	};
> 
> (...)
> 
> > +
> > +		qup1: geniqup@ac0000 {
> > +			compatible = "qcom,geni-se-qup";
> > +			reg = <0 0x00ac0000 0 0x6000>;
> > +			clocks = <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>,
> > +				 <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>;
> > +			clock-names = "m-ahb", "s-ahb";
> > +			iommus = <&apps_smmu 0x83 0>;
> > +
> > +			#address-cells = <2>;
> > +			#size-cells = <2>;
> > +			ranges;
> > +
> > +			status = "disabled";
> > +		};
> > +
> > +		ufs_mem_hc: ufshc@1d84000 {
> 
> Just "ufs" as node name.
> 
> > +			compatible = "qcom,sc8280xp-ufshc", "qcom,ufshc",
> > +				     "jedec,ufs-2.0";
> > +			reg = <0 0x01d84000 0 0x3000>;
> > +			interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
> > +			phys = <&ufs_mem_phy_lanes>;
> > +			phy-names = "ufsphy";
> > +			lanes-per-direction = <2>;
> > +			#reset-cells = <1>;
> > +			resets = <&gcc GCC_UFS_PHY_BCR>;
> > +			reset-names = "rst";
> > +
> > +			power-domains = <&gcc UFS_PHY_GDSC>;
> > +			required-opps = <&rpmhpd_opp_nom>;
> > +
> > +			iommus = <&apps_smmu 0xe0 0x0>;
> > +
> > +			clocks = <&gcc GCC_UFS_PHY_AXI_CLK>
> > +				 <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
> > +				 <&gcc GCC_UFS_PHY_AHB_CLK>,
> > +				 <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>,
> > +				 <&rpmhcc RPMH_CXO_CLK>,
> > +				 <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>,
> > +				 <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>,
> > +				 <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>;
> > +			clock-names = "core_clk",
> > +				      "bus_aggr_clk",
> > +				      "iface_clk",
> > +				      "core_clk_unipro",
> > +				      "ref_clk",
> > +				      "tx_lane0_sync_clk",
> > +				      "rx_lane0_sync_clk",
> > +				      "rx_lane1_sync_clk";
> > +			freq-table-hz = <75000000 300000000>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<75000000 300000000>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<0 0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		ufs_mem_phy: phy@1d87000 {
> > +			compatible = "qcom,sc8280xp-qmp-ufs-phy";
> > +			reg = <0 0x01d87000 0 0xe10>;
> > +			#address-cells = <2>;
> > +			#size-cells = <2>;
> > +			ranges;
> > +			clock-names = "ref",
> > +				      "ref_aux";
> > +			clocks = <&rpmhcc RPMH_CXO_CLK>,
> > +				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> > +
> > +			resets = <&ufs_mem_hc 0>;
> > +			reset-names = "ufsphy";
> > +			status = "disabled";
> > +
> > +			ufs_mem_phy_lanes: phy@1d87400 {
> > +				reg = <0 0x01d87400 0 0x108>,
> > +				      <0 0x01d87600 0 0x1e0>,
> > +				      <0 0x01d87c00 0 0x1dc>,
> > +				      <0 0x01d87800 0 0x108>,
> > +				      <0 0x01d87a00 0 0x1e0>;
> > +				#phy-cells = <0>;
> > +				#clock-cells = <0>;
> > +			};
> > +		};
> > +
> > +		ufs_card_hc: ufshc@1da4000 {
> 
> node name: ufs
> 
> > +			compatible = "qcom,sc8280xp-ufshc", "qcom,ufshc",
> > +				     "jedec,ufs-2.0";
> > +			reg = <0 0x01da4000 0 0x3000>;
> > +			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> > +			phys = <&ufs_card_phy_lanes>;
> > +			phy-names = "ufsphy";
> > +			lanes-per-direction = <2>;
> > +			#reset-cells = <1>;
> > +			resets = <&gcc GCC_UFS_CARD_BCR>;
> > +			reset-names = "rst";
> > +
> > +			power-domains = <&gcc UFS_CARD_GDSC>;
> > +
> > +			iommus = <&apps_smmu 0x4a0 0x0>;
> > +
> > +			clocks = <&gcc GCC_UFS_CARD_AXI_CLK>,
> > +				 <&gcc GCC_AGGRE_UFS_CARD_AXI_CLK>,
> > +				 <&gcc GCC_UFS_CARD_AHB_CLK>,
> > +				 <&gcc GCC_UFS_CARD_UNIPRO_CORE_CLK>,
> > +				 <&rpmhcc RPMH_CXO_CLK>,
> > +				 <&gcc GCC_UFS_CARD_TX_SYMBOL_0_CLK>,
> > +				 <&gcc GCC_UFS_CARD_RX_SYMBOL_0_CLK>,
> > +				 <&gcc GCC_UFS_CARD_RX_SYMBOL_1_CLK>;
> > +			clock-names = "core_clk",
> > +				      "bus_aggr_clk",
> > +				      "iface_clk",
> > +				      "core_clk_unipro",
> > +				      "ref_clk",
> > +				      "tx_lane0_sync_clk",
> > +				      "rx_lane0_sync_clk",
> > +				      "rx_lane1_sync_clk";
> > +			freq-table-hz = <75000000 300000000>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<75000000 300000000>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<0 0>,
> > +					<0 0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		ufs_card_phy: phy@1da7000 {
> > +			compatible = "qcom,sc8280xp-qmp-ufs-phy";
> > +			reg = <0 0x01da7000 0 0xe10>;
> > +			#address-cells = <2>;
> > +			#size-cells = <2>;
> > +			ranges;
> > +			clock-names = "ref",
> > +				      "ref_aux";
> > +			clocks = <&gcc GCC_UFS_1_CARD_CLKREF_CLK>,
> > +				 <&gcc GCC_UFS_CARD_PHY_AUX_CLK>;
> > +
> > +			resets = <&ufs_card_hc 0>;
> > +			reset-names = "ufsphy";
> > +			status = "disabled";
> > +
> > +			ufs_card_phy_lanes: phy@1da7400 {
> > +				reg = <0 0x01da7400 0 0x108>,
> > +				      <0 0x01da7600 0 0x1e0>,
> > +				      <0 0x01da7c00 0 0x1dc>,
> > +				      <0 0x01da7800 0 0x108>,
> > +				      <0 0x01da7a00 0 0x1e0>;
> > +				#phy-cells = <0>;
> > +				#clock-cells = <0>;
> > +			};
> > +		};
> > +
> > +		tcsr_mutex: hwlock@1f40000 {
> > +			compatible = "qcom,tcsr-mutex";
> > +			reg = <0x0 0x01f40000 0x0 0x20000>;
> > +			#hwlock-cells = <1>;
> > +		};
> > +
> > +		usb_0_hsphy: phy@88e5000 {
> > +			compatible = "qcom,sc8280xp-usb-hs-phy",
> > +				     "qcom,usb-snps-hs-5nm-phy";
> > +			reg = <0 0x088e5000 0 0x400>;
> > +			status = "disabled";
> 
> status goes to the end
> 
> > +			#phy-cells = <0>;
> > +
> > +			clocks = <&gcc GCC_USB2_HS0_CLKREF_CLK>;
> > +			clock-names = "ref";
> > +
> > +			resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
> > +		};
> > +
> > +		usb_2_hsphy0: phy@88e7000 {
> > +			compatible = "qcom,sc8280xp-usb-hs-phy",
> > +				     "qcom,usb-snps-hs-5nm-phy";
> > +			reg = <0 0x088e7000 0 0x400>;
> > +			status = "disabled";
> 
> ditto
> 
> > +			#phy-cells = <0>;
> > +
> > +			clocks = <&gcc GCC_USB2_HS0_CLKREF_CLK>;
> > +			clock-names = "ref";
> > +
> > +			resets = <&gcc GCC_QUSB2PHY_HS0_MP_BCR>;
> > +		};
> > +
> > +		usb_2_hsphy1: phy@88e8000 {
> > +			compatible = "qcom,sc8280xp-usb-hs-phy",
> > +				     "qcom,usb-snps-hs-5nm-phy";
> > +			reg = <0 0x088e8000 0 0x400>;
> > +			status = "disabled";
> 
> ditto
> 
> > +			#phy-cells = <0>;
> > +
> > +			clocks = <&gcc GCC_USB2_HS1_CLKREF_CLK>;
> > +			clock-names = "ref";
> > +
> > +			resets = <&gcc GCC_QUSB2PHY_HS1_MP_BCR>;
> > +		};
> > +
> > +		usb_2_hsphy2: phy@88e9000 {
> > +			compatible = "qcom,sc8280xp-usb-hs-phy",
> > +				     "qcom,usb-snps-hs-5nm-phy";
> > +			reg = <0 0x088e9000 0 0x400>;
> > +			status = "disabled";
> 
> ditto and so on
> 
> Best regards,
> Krzysztof