Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a40ab401-1368-b287-0e2b-daf8026bbf5a@quicinc.com>
Date:   Tue, 21 Jun 2022 10:40:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH rcu 2/3] doc: Document the rcutree.rcu_divisor kernel boot
 parameter
Content-Language: en-US
To:     "Paul E. McKenney" <paulmck@kernel.org>, <rcu@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
        <rostedt@goodmis.org>, Eric Dumazet <edumazet@google.com>
References: <20220620221733.GA3839136@paulmck-ThinkPad-P17-Gen-1>
 <20220620221757.3839212-2-paulmck@kernel.org>
From:   Neeraj Upadhyay <quic_neeraju@quicinc.com>
In-Reply-To: <20220620221757.3839212-2-paulmck@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/21/2022 3:47 AM, Paul E. McKenney wrote:
> This commit adds kernel-parameters.txt documentation for the
> rcutree.rcu_divisor kernel boot parameter, which controls the softirq
> callback-invocation batch limit.
> 
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---

Reviewed-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>

>   Documentation/admin-guide/kernel-parameters.txt | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 2522b11e593f2..bdf431bdbfdc4 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4666,6 +4666,21 @@
>   			When RCU_NOCB_CPU is set, also adjust the
>   			priority of NOCB callback kthreads.
>   
> +	rcutree.rcu_divisor= [KNL]
> +			Set the shift-right count to use to compute
> +			the callback-invocation batch limit bl from
> +			the number of callbacks queued on this CPU.
> +			The result will be bounded below by the value of
> +			the rcutree.blimit kernel parameter.  Every bl
> +			callbacks, the softirq handler will exit in
> +			order to allow the CPU to do other work.
> +
> +			Please note that this callback-invocation batch
> +			limit applies only to non-offloaded callback
> +			invocation.  Offloaded callbacks are instead
> +			invoked in the context of an rcuoc kthread, which
> +			scheduler will preempt as it does any other task.
> +
>   	rcutree.rcu_nocb_gp_stride= [KNL]
>   			Set the number of NOCB callback kthreads in
>   			each group, which defaults to the square root