Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 17:18:00 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Oscar Salvador <osalvador@suse.de>
Subject: Re: linux-next: build failures after merge of the mm tree
Message-ID: <20220621171800.0397976a@canb.auug.org.au>
In-Reply-To: <20220620164246.0d3f7784@canb.auug.org.au>
References: <20220620164246.0d3f7784@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/.gKofYcDqE7_tSi1YTSVd61";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/.gKofYcDqE7_tSi1YTSVd61
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Mon, 20 Jun 2022 16:42:46 +1000 Stephen Rothwell <sfr@canb.auug.org.au> =
wrote:
>
> Hi all,
>=20
> After merging the mm tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
>=20
> In file included from arch/x86/include/asm/page.h:86,
>                  from arch/x86/include/asm/thread_info.h:12,
>                  from include/linux/thread_info.h:60,
>                  from arch/x86/include/asm/preempt.h:7,
>                  from include/linux/preempt.h:78,
>                  from include/linux/spinlock.h:55,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:6,
>                  from include/linux/slab.h:15,
>                  from include/linux/crypto.h:20,
>                  from arch/x86/kernel/asm-offsets.c:9:
> include/linux/mm.h: In function 'destroy_large_folio':
> include/asm-generic/memory_model.h:35:21: error: implicit declaration of =
function 'page_to_section'; did you mean 'present_section'? [-Werror=3Dimpl=
icit-function-declaration]
>    35 |         int __sec =3D page_to_section(__pg);                     =
 \
>       |                     ^~~~~~~~~~~~~~~
> include/asm-generic/memory_model.h:40:32: note: in definition of macro '_=
_pfn_to_page'
>    40 | ({      unsigned long __pfn =3D (pfn);                    \
>       |                                ^~~
> include/asm-generic/memory_model.h:52:21: note: in expansion of macro '__=
page_to_pfn'
>    52 | #define page_to_pfn __page_to_pfn
>       |                     ^~~~~~~~~~~~~
> include/linux/mm.h:214:38: note: in expansion of macro 'page_to_pfn'
>   214 | #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))
>       |                                      ^~~~~~~~~~~
> include/linux/page-flags.h:312:33: note: in expansion of macro 'nth_page'
>   312 | #define folio_page(folio, n)    nth_page(&(folio)->page, n)
>       |                                 ^~~~~~~~
> include/linux/mm.h:928:38: note: in expansion of macro 'folio_page'
>   928 |         enum compound_dtor_id dtor =3D folio_page(folio, 1)->comp=
ound_dtor;
>       |                                      ^~~~~~~~~~
> In file included from include/linux/memcontrol.h:20,
>                  from include/linux/swap.h:9,
>                  from include/linux/suspend.h:5,
>                  from arch/x86/kernel/asm-offsets.c:13:
> include/linux/mm.h: At top level:
> include/linux/mm.h:1556:29: error: conflicting types for 'page_to_section=
'; have 'long unsigned int(const struct page *)'
>  1556 | static inline unsigned long page_to_section(const struct page *pa=
ge)
>       |                             ^~~~~~~~~~~~~~~
> In file included from arch/x86/include/asm/page.h:86,
>                  from arch/x86/include/asm/thread_info.h:12,
>                  from include/linux/thread_info.h:60,
>                  from arch/x86/include/asm/preempt.h:7,
>                  from include/linux/preempt.h:78,
>                  from include/linux/spinlock.h:55,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:6,
>                  from include/linux/slab.h:15,
>                  from include/linux/crypto.h:20,
>                  from arch/x86/kernel/asm-offsets.c:9:
> include/asm-generic/memory_model.h:35:21: note: previous implicit declara=
tion of 'page_to_section' with type 'int()'
>    35 |         int __sec =3D page_to_section(__pg);                     =
 \
>       |                     ^~~~~~~~~~~~~~~
> include/asm-generic/memory_model.h:40:32: note: in definition of macro '_=
_pfn_to_page'
>    40 | ({      unsigned long __pfn =3D (pfn);                    \
>       |                                ^~~
> include/asm-generic/memory_model.h:52:21: note: in expansion of macro '__=
page_to_pfn'
>    52 | #define page_to_pfn __page_to_pfn
>       |                     ^~~~~~~~~~~~~
> include/linux/mm.h:214:38: note: in expansion of macro 'page_to_pfn'
>   214 | #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))
>       |                                      ^~~~~~~~~~~
> include/linux/page-flags.h:312:33: note: in expansion of macro 'nth_page'
>   312 | #define folio_page(folio, n)    nth_page(&(folio)->page, n)
>       |                                 ^~~~~~~~
> include/linux/mm.h:928:38: note: in expansion of macro 'folio_page'
>   928 |         enum compound_dtor_id dtor =3D folio_page(folio, 1)->comp=
ound_dtor;
>       |                                      ^~~~~~~~~~
> cc1: some warnings being treated as errors
>=20
> Caused by commit (I think)
>=20
>   d3b90b76e101 ("mm: convert destroy_compound_page() to destroy_large_fol=
io()")
>=20
> I have reverted these commits fot today:
>=20
> 56629699b3dd mm/swap: convert __delete_from_swap_cache() to a folio
> e5085f2cc241 mm/swap: convert delete_from_swap_cache() to take a folio
> 169f02f4efb1 mm: convert page_swap_flags to folio_swap_flags
> d3b90b76e101 mm: convert destroy_compound_page() to destroy_large_folio()
>=20
> Then I got:
>=20
> mm/hugetlb_vmemmap.c: In function 'vmemmap_optimizable_pages':
> mm/hugetlb_vmemmap.c:110:24: error: implicit declaration of function 'spa=
rse_decode_mem_map' [-Werror=3Dimplicit-function-declaration]
>   110 |         vmemmap_page =3D sparse_decode_mem_map(ms->section_mem_ma=
p,
>       |                        ^~~~~~~~~~~~~~~~~~~~~
> mm/hugetlb_vmemmap.c:110:22: warning: assignment to 'struct page *' from =
'int' makes pointer from integer without a cast [-Wint-conversion]
>   110 |         vmemmap_page =3D _sparsedecode_mem_map(ms->section_mem_ma=
p,
>       |                      ^
> cc1: some warnings being treated as errors
>=20
> from my arm64 defconfig build.
>=20
> Caused by commit
>=20
>   10a768735470 ("mm: memory_hotplug: make hugetlb_optimize_vmemmap compat=
ible with memmap_on_memory")
>=20
> So I gave up and used the mm tree from next-20220617 for today.

Today, I reverted the following commits instead:

10a768735470 mm: memory_hotplug: make hugetlb_optimize_vmemmap compatible w=
ith memmap_on_memory
cececf2df493 mm: memory_hotplug: enumerate all supported section flags
56629699b3dd mm/swap: convert __delete_from_swap_cache() to a folio
e5085f2cc241 mm/swap: convert delete_from_swap_cache() to take a folio
169f02f4efb1 mm: convert page_swap_flags to folio_swap_flags
d3b90b76e101 mm: convert destroy_compound_page() to destroy_large_folio()
19211dae45bb mm/swap: convert __page_cache_release() to use a folio

--=20
Cheers,
Stephen Rothwell

--Sig_/.gKofYcDqE7_tSi1YTSVd61
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmKxcKgACgkQAVBC80lX
0Gw9Ewf9GXmuZy7oI2z6WdE7/cMEJLc+X6UreyfX5QIRJVm4Nu9Un90CIy5JHcqZ
A/PZJ7EIb0TEvqdWJH7FZOMcrpV84St/5iF4QGuY836cmH3pAHfynxk3oho/876d
OVXEO/ltSAtmw10nh+ouxtUWwHXWZ/0OGx4T6IvfH2k0lR04fXCm4Ty61mMq/Gpz
dIIUq/QKXM8DXZkg5XnkpD7ojay38T7w3jX2hxJvK6HMb6YnjKuncTi3gVo/j1hN
6aJbxykGhghyK6vf0rO8rACPHcXuzJd4+H7uzKPUnRbkV5ZhaUxkCfk/UYE+2dq3
tSxbNj15KYgPNpIpPCErKKtZTFgwQA==
=LPu5
-----END PGP SIGNATURE-----

--Sig_/.gKofYcDqE7_tSi1YTSVd61--