Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef7276bd-c5ce-af98-bd49-051e24528426@rasmusvillemoes.dk>
Date:   Tue, 21 Jun 2022 09:19:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not
 write past nul
Content-Language: en-US
To:     Kent Overstreet <kent.overstreet@gmail.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com
Cc:     rostedt@goodmis.org, enozhatsky@chromium.org, willy@infradead.org
References: <20220620004233.3805-1-kent.overstreet@gmail.com>
 <20220620004233.3805-14-kent.overstreet@gmail.com>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
In-Reply-To: <20220620004233.3805-14-kent.overstreet@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/06/2022 02.42, Kent Overstreet wrote:
> The current test code checks that sprintf never writes past the
> terminating nul. This is a rather strange requirement, completely
> separate from writing past the end of the buffer, which of course we
> can't do

And which of course you don't check anymore. So any statement about "all
tests passing after these patches" is not worth much.

So NAK in this form, but perhaps if/when my year-old patch gets picked
up (or you could include it in the series) we can talk about eliminating
the check for past-nul-before-end-of-buffer writes.

Rasmus