Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <13e54c18-7a58-b6bd-0399-273a109ee42e@kylinos.cn>
Date:   Tue, 21 Jun 2022 16:40:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v5 -next] usb: xhci: disable irq during initialization
Content-Language: en-US
To:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        Hongyu Xie <xy521521@gmail.com>, mathias.nyman@intel.com,
        gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        125707942@qq.com, wangqi@kylinos.cn, xiongxin@kylinos.cn
References: <20220616083852.1264261-1-xiehongyu1@kylinos.cn>
 <bf133cfd-8d9a-474e-989e-48fe383ecfbd@linux.intel.com>
From:   =?UTF-8?B?6LCi5rOT5a6H?= <xiehongyu1@kylinos.cn>
In-Reply-To: <bf133cfd-8d9a-474e-989e-48fe383ecfbd@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

It looks fine.
Thanks for all the advices and cleanups.

On 2022/6/21 16:25, Mathias Nyman wrote:
> Hi
> 
> On 16.6.2022 11.38, Hongyu Xie wrote:
>> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
>> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
>> It's possible that you will receive thousands of interrupt requests
>> after initialization for 2.0 roothub. And you will get a lot of
>> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
>> disabled?". This amount of interrupt requests will cause the entire
>> system to freeze.
>> This problem was first found on a device with ASM2142 host controller
>> on it.
>>
>> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
>> --
> Thanks, added.
> Did some non-functional cleanups, mostly to the old debug messages this patch
> moves around:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?h=for-usb-linus&id=2d1fa9b0b08bb841fde9136c249f632eb04a1e00
> 
> Let me know if you disagree with the changes
> 
> -Mathias
  -Hongyu