Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220621070224.1231039-1-zhangshida@kylinos.cn> <20220621073943.GQ227878@dread.disaster.area>
In-Reply-To: <20220621073943.GQ227878@dread.disaster.area>
From:   Stephen Zhang <starzhangzsd@gmail.com>
Date:   Tue, 21 Jun 2022 16:39:15 +0800
Message-ID: <CANubcdVW8cje_3MEAZsWN8TFKMO8kTe8VuNFAxsBxTh7haV8vg@mail.gmail.com>
Subject: Re: [PATCH v2] xfs: add check before calling xfs_mod_fdblocks
To:     Dave Chinner <david@fromorbit.com>
Cc:     djwong@kernel.org, dchinner@redhat.com,
        zhangshida <zhangshida@kylinos.cn>, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Dave Chinner <david@fromorbit.com> =E4=BA=8E2022=E5=B9=B46=E6=9C=8821=E6=97=
=A5=E5=91=A8=E4=BA=8C 15:39=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, Jun 21, 2022 at 03:02:24PM +0800, Shida Zhang wrote:
> > Checks are missing when delta equals 0 in __xfs_ag_resv_free() and
> > __xfs_ag_resv_init().
>
> This describes what the patch does, not the problem being solved is.
>
> i.e. This doesn't tell the reader why the delta can be zero in these
> places, nor does it tell them what the impact of it being zero is.
> We can't use this information to identify a system that is having
> problems due to this issue because they havent' been described.
>
> Hence when I ask for more detail about how something occurs, what I'm
> asking for is a description of the how the problem was found, what
> the impact of the problem has on systems, how the problem is
> reproduced, etc.
>
> Something led you to finding this problem - tell us the story so we
> also know what you know and so can understand why the change needs
> to be made. A good commit description tells the reader everything
> you know about the problem that needs to be fixed, the code change
> itself will then describe how the problem was fixed...
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com

Thanks for your suggestion. I will try to rephrase the description.

Cheers,

Stephen.