Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3598220iog; Tue, 21 Jun 2022 01:58:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uBGXLF9bftnGUA0TlhlTSwKqCAWmtLMnvtZowqS7GqN7ZJlto1vdfMY8IpkdQZVm7NuFLP X-Received: by 2002:a17:907:7f8d:b0:711:d8db:2714 with SMTP id qk13-20020a1709077f8d00b00711d8db2714mr24175379ejc.63.1655801927596; Tue, 21 Jun 2022 01:58:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655801927; cv=none; d=google.com; s=arc-20160816; b=HfiJKoOc2fvYliSmApCGc5IYC50fYevMN0Ojlhnm3SdtvuQ2tYt3awf15dTNqwwSxG sqEX9It2WRmW+Yg7oZSPdr1qgrshwRaXDu2zTjBItvCi4Ze/VwRtiSMBgjIldymVGwnK ha/WNCnR/hnZIlDHuLb6hnDOgGnvSt2rb9L5w4T8q2DISJcRADuAUTRf1Ri3utHHzuOc DHkpcErHFjEwBRTD/99arl9qP5bgKA9pZxRJybyJg/WKLQ/igARpHUaF98WOcCSSnLoj 0yA3yjMX1VQetexMSatv5sCZEATG8ojxI7juHpXEudKFKjby5mMzTqpnI/fGyt1Ud4D7 Gx9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=0cx/amxb3Wd/PcYv0eYLLeJxSM7TQT62UUtprSbhbwY=; b=rRq81HEEhZ2BCkjrCxZmf2cdZJkXuB2WbLDUAIE38U3zJ6ykPujXFGV6TiOKpwd59t BVMSYn0erpTS1OC5CUR+nCHUsaLkYBhkP9U3/x5n5IUrnTG0/3W/YgPQH43LGHf99mfY 7ynFF9lYF6KHzu7kTbxQVUirmLXSF9JexksxPcbL6KcklGf1cIbQ3jfMaGZtOuWcZ8Ek xyFQ8fl82HGpW4jt9a61Xhgb/C070uTC1GQTDf2/BHCeZWqFz6IN53wyXrHsNlUnnXo5 RmGvhzbZ7Uef0kGLP8Kg/UALv4ecGLkrPeLb5kzUrJOYAxpzUhYgljBNWdwpPYoqkv3S btzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=l6LNhCtW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb41-20020a1709071ca900b00711da98d1besi17853165ejc.251.2022.06.21.01.58.21; Tue, 21 Jun 2022 01:58:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=l6LNhCtW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346907AbiFUI5K (ORCPT + 99 others); Tue, 21 Jun 2022 04:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348632AbiFUI5B (ORCPT ); Tue, 21 Jun 2022 04:57:01 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E45A27177; Tue, 21 Jun 2022 01:56:56 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id v1so25954698ejg.13; Tue, 21 Jun 2022 01:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0cx/amxb3Wd/PcYv0eYLLeJxSM7TQT62UUtprSbhbwY=; b=l6LNhCtWPcYK5lVOJB4knQOEE4oFs6J2Jg6Rt0e7BaNut9e46lb5KdVYDnj6ilkGm2 mQ7VTnH80+cXckqjznh1du5dtOdVPhs652Du5TxDiQ+58oHjtxhVtjko9YTZsFibM+4t dteat9bhz8IHA88U249+vCWBP8CMzaA8asRdTLzsuGL9ee0hN04GeQteE0Fi4kylaNKj 0TFF8lnde6SvXHYI9XMpMF1ignz5BbL2lHAoTlF4Oug9V6Zxoushwt5/wntbiBkIu6+l VjoJciC5kvKSDrAabkgWHTdSnlVHc0xwfw64uWPO7VuWtTj36CeQPvqwS05CcagrCAjw 1RAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0cx/amxb3Wd/PcYv0eYLLeJxSM7TQT62UUtprSbhbwY=; b=m8yDpWL7xnjkW6wcHoxsuYxU6LlsCcTBEV72s689WvD+38v5JEDXr78vVMoMPGgyan jRHUv6HlIiS4AnO6TI0RBl701pqSD0TXEg2dUotfR5Pd3e0ur/NXQUIc03sx4iptAnuW OiGRCGiyi2Xx9NxL7+pddkPMn34YLt/G9MEOhCFpK7CurT2+BMa8oYCgTnfp5O+KMDgr DV4HoKqYMQd/TyevHAbQNKsolLJDP00yT1S7ehDDMrph97pZtYq8hXbEgLAvIkzmzgkJ rNcZAWFIYybJCzGFkqFVV9xjjdUKbq3dXpPalinCgC3dG16Hd33zZVdQNMyUI45M9EGh b83g== X-Gm-Message-State: AJIora+x8yZDC9bqMjjaFgJ5yMhGdWFHxYUH6xYK99Gh3P+ESpI023rc 8FXYd7Y0HWif71+feEYOhwnhh/6Qhvam6gML1X0= X-Received: by 2002:a17:906:d550:b0:704:7ba6:9854 with SMTP id cr16-20020a170906d55000b007047ba69854mr24696900ejc.579.1655801815068; Tue, 21 Jun 2022 01:56:55 -0700 (PDT) MIME-Version: 1.0 References: <20220621064321.25635-1-jiangjian@cdjrlc.com> In-Reply-To: <20220621064321.25635-1-jiangjian@cdjrlc.com> From: Andy Shevchenko Date: Tue, 21 Jun 2022 10:56:18 +0200 Message-ID: Subject: Re: [PATCH] iio: aligned '*' each line To: Jiang Jian Cc: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2022 at 8:57 AM Jiang Jian wrote: > > Consider '*' alignment in comments Subject should start with "iio: dac: ad5380: ..." The commit message should follow English grammar (missed period in your case) and explain a little bit more, e.g. "Consider '*' alignment in the comments of struct ad5380_chip_info declaration". ... > * @channel_template: channel specification template > * @num_channels: number of channels > * @int_vref: internal vref in uV > -*/ > + */ > While at it, drop the unneeded blank line here. > struct ad5380_chip_info { -- With Best Regards, Andy Shevchenko