Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3631010iog; Tue, 21 Jun 2022 02:45:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vmmTVsNPsEodn3yW6R0d/TUr3KMXLFCmZu1U1kp+fADJXyQlLY7QOFITvWYlfk6UaMtwOv X-Received: by 2002:a05:6402:3490:b0:435:9802:96ac with SMTP id v16-20020a056402349000b00435980296acmr2309884edc.40.1655804730378; Tue, 21 Jun 2022 02:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655804730; cv=none; d=google.com; s=arc-20160816; b=ZceqG5ys4xabZ01ZnZGPThMYh7Tb/GLybYNeHDvjmCixfpfSmjZNW3DbJM4xQISO95 ePvZ+QbdPDQ2v/TAn1vkfg7chwrFNkdrPRWDWjAuf74kgy9xIJ9n5rWlpIyWvO9/Ziar KN755J2LXTGpvaKSR55Z3MDztakX45sUZXc/NeGDhxcygxG6GvV7CrjkAerMvdcYbyRA 43gywCcEyOmFkrgEEqjFLVT1PvHim4Yt7JwUHl7fPcLvcKizLSEdYztaqhsWUWxOG+JD M7h8IbxjPdWXvZTp2hc699V31HiPhqHR54RLuDUCf7YHzDMDdAGInSJSCp2AYSjKp9UM fdfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7W8pS4HaYS/K/F5s5QPICn7aqLZXMuTyRRVdAfsAcPg=; b=yl6SKl4TspQGO5STvJfRreannVIsU9174qvcVi5ANf0thZTU5twng1dqcnYPX828ul Nck/IbdyRCwHjOa87i3DoBvM/VGtatAhDoKaM/XLkvmN9yOdqqmILulfLLA0+rCBF1fV 111ThfU/r6xc2l7+9PxfW5/N8DO6ekqh5/wRVWTMjY3IRXRv7M7ZLVU5K+DGS8AhTNNO yqtB9U9c+7ChvrGhbYCjpqvjUXS5RA0InhLdKbSw8QwrzyMpXwBXtEIKG0gSfgPe1R3E JA8IcDAZRya75cbi1PA44b+hK1r2aUI4WVrEfoaehdFkvA69Jp/HZAvwIB8ksgZ9T0rG NQDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XoZerS+q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a170906794b00b00711d868d144si15101569ejo.976.2022.06.21.02.45.04; Tue, 21 Jun 2022 02:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XoZerS+q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349317AbiFUJnN (ORCPT + 99 others); Tue, 21 Jun 2022 05:43:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349385AbiFUJnK (ORCPT ); Tue, 21 Jun 2022 05:43:10 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8AEC16591; Tue, 21 Jun 2022 02:43:08 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id cw10so2512323ejb.3; Tue, 21 Jun 2022 02:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7W8pS4HaYS/K/F5s5QPICn7aqLZXMuTyRRVdAfsAcPg=; b=XoZerS+qv1R28f40K6hoLnLM4Ct5C+e/yqRmtv+kzV9PCDFL/LS7bsUEdldOD+RyHB ukczq/1O7qTvO3tyrlZrzFhXQ33KoFDifHZODZVFjJ3TigoHkBk7geFdz+QWVVDhdZd0 4QXA3Mcp4UOLWIVfOEaXgpOhro4R7EyEOzGxZz//6kMGNLexIQ1RMMhIHoy6Fmqp95s3 edH6j4r60Egf0+IoooN2Kl4dh1amXJKmc5SerDqp0IPAetq8boVtQMtd1V4UihFiytjO i7exWG8M8Vy6qOonHlsopob38cCHeq//DmG2j5wMnELgMi7YdE2S591sC4Eqab5J28+F vr/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7W8pS4HaYS/K/F5s5QPICn7aqLZXMuTyRRVdAfsAcPg=; b=EN4KTb12zFCgRCKjayRRLDTvs4wJ1cnJ8uu+JrJX83p5emApSz+eW5PXD/gqtCPK3Q d6Vlzp/KGvYTii3zzQ9Dw8YxruLfgxWql4pCia9boDNdVze0dshqQpfiN+4EKrcxJlTU jdYV63IsJE/l4VEL9UYWFE2Sc3UJ+5nv0p6HET8X9GkbKuIuvDs1hnPa6Stz9Eij4zKy YuX1PufQv96qOx9rgqNUqAtsVq2+S2roXso8i8+jPukPNjf63HXkbtPzdHyelIs8z9QM YHeC1R2rYhk5m/c6r5V9+UO3gbvnTx42f6c4J7u+bxUv6QAc805UqhIO/h+HAHnvhq5X 5Y7w== X-Gm-Message-State: AJIora8HTIHa1XvgZ3Gb6pn3v5VjanwJPE0fZ7gg4ekVcejTHtTPw7Mw sXdBCRTPkCLfPTwDsrrFCMRzOjgDw/G5Pc5kY+c= X-Received: by 2002:a17:906:434f:b0:711:eb76:c320 with SMTP id z15-20020a170906434f00b00711eb76c320mr24832521ejm.636.1655804587541; Tue, 21 Jun 2022 02:43:07 -0700 (PDT) MIME-Version: 1.0 References: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> <20220620200644.1961936-40-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220620200644.1961936-40-aidanmacdonald.0x0@gmail.com> From: Andy Shevchenko Date: Tue, 21 Jun 2022 11:42:31 +0200 Message-ID: Subject: Re: [PATCH 39/49] gpio: sl28cpld: replace irqchip mask_invert with unmask_base To: Aidan MacDonald Cc: Mark Brown , Andy Gross , Bjorn Andersson , Srinivas Kandagatla , Banajit Goswami , Greg Kroah-Hartman , "Rafael J. Wysocki" , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , MyungJoo Ham , Michael Walle , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Lee Jones , Manivannan Sadhasivam , Cristian Ciocaltea , Chen-Yu Tsai , tharvey@gateworks.com, rjones@gateworks.com, Matti Vaittinen , orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, Jernej Skrabec , Samuel Holland , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , linux-actions@lists.infradead.org, linux-arm-msm , linux-arm Mailing List , linux-sunxi@lists.linux.dev, ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:10 PM Aidan MacDonald wrote: > > An inverted mask register can be described more directly > as an unmask register. Reviewed-by: Andy Shevchenko > Signed-off-by: Aidan MacDonald > --- > drivers/gpio/gpio-sl28cpld.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c > index 52404736ac86..2195f88c2048 100644 > --- a/drivers/gpio/gpio-sl28cpld.c > +++ b/drivers/gpio/gpio-sl28cpld.c > @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev, > irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs); > irq_chip->num_regs = 1; > irq_chip->status_base = base + GPIO_REG_IP; > - irq_chip->mask_base = base + GPIO_REG_IE; > - irq_chip->mask_invert = true; > + irq_chip->unmask_base = base + GPIO_REG_IE; > irq_chip->ack_base = base + GPIO_REG_IP; > > ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev), > -- > 2.35.1 > -- With Best Regards, Andy Shevchenko