Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 10:27:28 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Yu Zhao <yuzhao@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 7/7] mm/page_alloc: Replace local_lock with normal
 spinlock
Message-ID: <20220621092728.GE15453@techsingularity.net>
References: <20220613125622.18628-1-mgorman@techsingularity.net>
 <20220613125622.18628-8-mgorman@techsingularity.net>
 <43033655-2e78-621b-cc76-c3dc53024d00@suse.cz>
 <CAOUHufaHV9Aua3sneOnQvPhrtuxxDuJ5+c+A-zy8RufoDkmeMQ@mail.gmail.com>
 <8354ba5b-d1ce-90c7-be76-328ab9321550@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <8354ba5b-d1ce-90c7-be76-328ab9321550@suse.cz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Jun 17, 2022 at 09:57:06AM +0200, Vlastimil Babka wrote:
> On 6/16/22 23:07, Yu Zhao wrote:
> > On Thu, Jun 16, 2022 at 11:02 AM Vlastimil Babka <vbabka@suse.cz> wrote:
> >>
> >>
> >> > @@ -3794,19 +3805,29 @@ static struct page *rmqueue_pcplist(struct zone *preferred_zone,
> >> >       struct list_head *list;
> >> >       struct page *page;
> >> >       unsigned long flags;
> >> > +     unsigned long __maybe_unused UP_flags;
> >> >
> >> > -     local_lock_irqsave(&pagesets.lock, flags);
> >> > +     /*
> >> > +      * spin_trylock_irqsave is not necessary right now as it'll only be
> >> > +      * true when contending with a remote drain. It's in place as a
> >> > +      * preparation step before converting pcp locking to spin_trylock
> >> > +      * to protect against IRQ reentry.
> >> > +      */
> >> > +     pcp_trylock_prepare(UP_flags);
> >> > +     pcp = pcp_spin_trylock_irqsave(zone->per_cpu_pageset, flags);
> >> > +     if (!pcp)
> >>
> >> Besides the missing unpin Andrew fixed, I think also this is missing
> >> pcp_trylock_finish(UP_flags); ?
> > 
> > spin_trylock only fails when trylock_finish is a NOP.
> 
> True, so it's not an active bug, but I would still add it, so it's not
> confusing and depending on non-obvious details that might later change and
> break the code.

Yes. Even though it may work, it's still wrong.

-- 
Mel Gorman
SUSE Labs