Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3648085iog; Tue, 21 Jun 2022 03:07:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vvFF6uMz1fc+lnX/2j98KRJJgZl/db1rOUa4h0zhpNwvti3HVUIwJ4SBOKyy69LY0ePgL/ X-Received: by 2002:a05:6402:51d3:b0:431:6c7b:c35 with SMTP id r19-20020a05640251d300b004316c7b0c35mr35155607edd.28.1655806026703; Tue, 21 Jun 2022 03:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655806026; cv=none; d=google.com; s=arc-20160816; b=sOGj8T4tK313vTNIS4wJTNbp/yCE4ZnvQpj94TnzKN+uH440vsQCqD8HZPOn3fCLg0 +Ll78ZWPsPm7vkQpwSGwYnxcD3yruf1UMdFUJhzzD9DtCatgRlf2fqvLu1e9JVKTjkek Sh8yj8hXhRliJLlASHU9jin+KXU/Re8CD95P3VnpL6Fu6YKP0Q9LC286ZOVYVRE1NSmE VLlfV1fwI5fRCh1HLm8W0lwrCjoHBta7G6lbBVjaHUQsqFjn1+1k0gIMa0ADt7yuoB1M zjFAZQj1zqmLDa+8204V7J3GRtqSTrZJ4Avk/2Fg1gKSE35hExsqairyD2LsobAz6gN2 TMsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B3mXXvSs4qGpLiVTug5tdC+fphrM4PCUnQdpfU/r3B4=; b=nz/i/xDKmC6IxuQzLvEKsMLAC74PGpE+G8dsgwkFHsY5dvLczXWPfMFNNVyLU3J3kS Go9CF0LG17SYMHsLSDc6Lo0sa7y+RK4tVEYghgzYe28356Ze+xOmnRKlACxJrQFelwxh 578NxGfdkYQZFn7Bl3x/qYKZnk4X181rw6qUsnH5JK9+th0e3Ob5dWAgKxHRSgiMRwxc y3zQ3Wt3N9iMT7iQHvuXkjmA8rLxZEVMOnE4EM1oeZJxxnSgmEBD4RQwa2lZerECVG+b 47goauBumelfflFQOs3zhap1/1448BljTUHLxF0uVzE69y3DoJmEDwIn5/YsIYxxHSai WuHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GZTXPEfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gl20-20020a170906e0d400b006f3c442e22fsi14890859ejb.361.2022.06.21.03.06.41; Tue, 21 Jun 2022 03:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GZTXPEfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349075AbiFUJgc (ORCPT + 99 others); Tue, 21 Jun 2022 05:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349072AbiFUJga (ORCPT ); Tue, 21 Jun 2022 05:36:30 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C4B2715F; Tue, 21 Jun 2022 02:36:27 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id g26so4839519ejb.5; Tue, 21 Jun 2022 02:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B3mXXvSs4qGpLiVTug5tdC+fphrM4PCUnQdpfU/r3B4=; b=GZTXPEfS47hEV7elN7AWU0dyhKzNKwdabIk8g/G/aEeYWfI/AEfKiiKKiJ0evIjaEd FtH51zPQdYz0Wv0AmPXOMQLodWRlV7HyTinHEw6fgJQgOlyjsTl6fQZSl/ybu604W4F+ UxX4FRJSL6jlr9oxoyyq/C/sBcO8EH2byvWx7KEErHyh/iWfN8aNrTMTHnPVZ2W1J4lS 1/7esI1emn382GWt20lYVLjXhb37rvclxIVWEiEfxWQVq7ufkcL+iuwCEDXuZqtEs1hI 31L1rsZzI7J12QKbgN32jIG+MHsmRs2cNl3LB3qH6J7/PgBIg4Xu7+4egEgkvTA5IXOX L5hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B3mXXvSs4qGpLiVTug5tdC+fphrM4PCUnQdpfU/r3B4=; b=bUkG6p78RZgOenmMJnBtDnetyk0ZI6GZPHDiMOryYm4MBh/Nx637LrLqr0XI7EzHzC +uU4PiqECmz3UNkcIhCdDnwE56h/hwJSzMH7TVX3AR73Z8T+sAyyLpF1h/UXRY7xOPM4 5Im8pRb4he4CoivKXyNdccrSogHsHDFCFfbPL25GjNYx4thD14mBks21DFsubTwSl4zO WDHoUPgUYdL+UaBhlXZsv+Kzb7arjmM2scEHMQj8Izvd2uvsxjRWuvOza8jpWy3UVwXy T91q/iBGRpLeDmTldnTEn1NkSVNkYR77xk5BNiYOEh6RSrPsENOr7rf7q80/nvECfXNA 1ZCg== X-Gm-Message-State: AJIora/RgVFat76sdVIQPgUFp7vjRTXnprS6NazyAkryu/eSlYf73xC0 +nzD1uFJrO6sAnNcPSIkvM+eZUGKy8ANHC8e4h0= X-Received: by 2002:a17:907:9721:b0:70c:65e7:2aa5 with SMTP id jg33-20020a170907972100b0070c65e72aa5mr24694089ejc.132.1655804186418; Tue, 21 Jun 2022 02:36:26 -0700 (PDT) MIME-Version: 1.0 References: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> <20220620200644.1961936-20-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220620200644.1961936-20-aidanmacdonald.0x0@gmail.com> From: Andy Shevchenko Date: Tue, 21 Jun 2022 11:35:49 +0200 Message-ID: Subject: Re: [PATCH 19/49] mfd: stpmic1: Add broken_mask_unmask irq chip flag To: Aidan MacDonald Cc: Mark Brown , Andy Gross , Bjorn Andersson , Srinivas Kandagatla , Banajit Goswami , Greg Kroah-Hartman , "Rafael J. Wysocki" , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , MyungJoo Ham , Michael Walle , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Lee Jones , Manivannan Sadhasivam , Cristian Ciocaltea , Chen-Yu Tsai , tharvey@gateworks.com, rjones@gateworks.com, Matti Vaittinen , orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, Jernej Skrabec , Samuel Holland , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , linux-actions@lists.infradead.org, linux-arm-msm , linux-arm Mailing List , linux-sunxi@lists.linux.dev, ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:08 PM Aidan MacDonald wrote: > > The STPMIC1 has a normal "1 to disable" mask register with > separate set and clear registers. It's relying on masks and > unmasks being inverted from their intuitive meaning, so it > needs the broken_mask_unmask flag. Same comment as per previous patch and continues to all patches of a kind. -- With Best Regards, Andy Shevchenko