Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3648294iog; Tue, 21 Jun 2022 03:07:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u5H40bToIALHYf/Op5VueR5o14UNS8O2KQ83zx56FWiZ1HTdUSJkz3jTGmhkh4ePMHjQsh X-Received: by 2002:a17:906:794e:b0:711:da52:c6c1 with SMTP id l14-20020a170906794e00b00711da52c6c1mr26460166ejo.463.1655806039616; Tue, 21 Jun 2022 03:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655806039; cv=none; d=google.com; s=arc-20160816; b=Jw/YZ4UQawI4OMEI8AAaBYQ5/X+Ftv/DF6pkVncUyAJrGt64JQ0pAxH2CEmhGq54WA wmwUN9iwU1LvZ+fJcxqavq7n6J16jAvOectfEH8qE5O/6v/+Hmywo1Cqui1qLUIJ2Nu5 OUOJKxtQy9yJzBpSaUDmHGMmdKUyq/Q08SHm78HNf16mzJxvYydzbZCmfjI1vC3L7uwy EVESWMTizaVh0I+1W5Yru0dnB3sSiDSCEZKE4MEGItGeU3UzTnM02anv4kxBqFRao38L 5LUqq/Q96l2PFk+tyupNEVXZXwZm18IOwaXs6jvS81uiXkhl9gOD0C4+nTA3hKFfIQX0 Ktkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=a56PheGcF+r+BjhYmHX7tYRduE7y97a0JE0aqCMtBZI=; b=K9okBOLmy6pxPHQrt6VBNH/ingsqLWON1mwDQEbfa/eKTc95cXeplDXOaBwemKlI0P QxdAoDL3BMk+FVhAY8ETI0IvgoHQ6NLl5pSkj1jcprZbEKbpXleq9Xut3DvugGmkGpaZ /vbGsyeOgUg98B6YjXBfRLpC+bHnD8qfvM68Dft4suprMyLmNiwgURv3whwxVFeD/ix4 arG76sxoOexq6NNF4BRRmVHz6SB1TseLCzVHf6r9VQ9lILqF1KFq+nxK2p2AHmA5UOev 52a+vCq7t9fe9KLTyjD5flY5SZBWEcDYFVlrT+Fdl+iGH6v7EOHEaJnlfKXXpcMCmCuZ F6vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UixjmExe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 11-20020a170906000b00b006ff17356288si390899eja.803.2022.06.21.03.06.54; Tue, 21 Jun 2022 03:07:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UixjmExe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348906AbiFUJft (ORCPT + 99 others); Tue, 21 Jun 2022 05:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349026AbiFUJfs (ORCPT ); Tue, 21 Jun 2022 05:35:48 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2AAD25E83; Tue, 21 Jun 2022 02:35:47 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id o7so26235150eja.1; Tue, 21 Jun 2022 02:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a56PheGcF+r+BjhYmHX7tYRduE7y97a0JE0aqCMtBZI=; b=UixjmExeWC3NrbmY2//fqkfPnJRAmI3sK61SBW8J25ecyvNRu8cdjcXzZrB9vFZaVW YUpJGfwbiuk1/Q15sPGbqfe6e4JyoZUF59VlyzpkI8jO20sjRrqotK1X7unN/KnfUqEu p1Se6aKX+tKaHJYE71hUPqHSk+sEw3O9OOYNMtYAQ70/ZfGxiMBPLX85OQUMZjK6B5Cg tPCfGRSWvPAgVwm+hlCyY4iVKhj6g7/5PYEeerpe5McbZ3g4CAAkUyCi8c3KpFsTdeoC DSdWLIDZ7kz2SMZgvQ71gwC1mUwdwSgDGv5XUY5Mjm6N+iOs/pHvh4h7V4c3k1ultgT7 JV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a56PheGcF+r+BjhYmHX7tYRduE7y97a0JE0aqCMtBZI=; b=Sw9eadQ6MF9Ihh396x1XTGe72sh6gINc4glSzuppK97VEbI/eaNhlom+TUH3ifdIyd r1NVx6ZKQu/UZJG6F0NP+6SNTV9m9JjaxiYaS9oacoQoyHoJLEgG3c/bbRDYBVh3kNRJ SF7kus/fXiNykx4TmQVNkTNrvg9VPlXVWtZ6jwkuEyhc0B5TCBUOw0Ws05Rxwl1yfskQ neKIPPXMUs+XqR+vYtwz2OsHk8VDgGM11vb6K+QOgCnDrma4k3UJzDJEcBlhtQI2wyTU GmyxptSl8xRt/c8y1/6UWXHQGkxOLsL598EFJgMTk96UTfocd1+1hAJDfQRvWMUtWO8P aFhw== X-Gm-Message-State: AJIora8xiGFQs9YY0PRnObRLhEnGPzvuyJh/YjYffTjcGkIrk6EGag4o C6ZE14poDXLOK6WrP4wN4NreMad5uKtGD4AlLXE= X-Received: by 2002:a17:906:d9d9:b0:710:f2ae:b455 with SMTP id qk25-20020a170906d9d900b00710f2aeb455mr25461664ejb.77.1655804146381; Tue, 21 Jun 2022 02:35:46 -0700 (PDT) MIME-Version: 1.0 References: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> <20220620200644.1961936-19-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220620200644.1961936-19-aidanmacdonald.0x0@gmail.com> From: Andy Shevchenko Date: Tue, 21 Jun 2022 11:35:09 +0200 Message-ID: Subject: Re: [PATCH 18/49] mfd: qcom-pm8008: Add broken_mask_unmask irq chip flag To: Aidan MacDonald Cc: Mark Brown , Andy Gross , Bjorn Andersson , Srinivas Kandagatla , Banajit Goswami , Greg Kroah-Hartman , "Rafael J. Wysocki" , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , MyungJoo Ham , Michael Walle , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Lee Jones , Manivannan Sadhasivam , Cristian Ciocaltea , Chen-Yu Tsai , tharvey@gateworks.com, rjones@gateworks.com, Matti Vaittinen , orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, Jernej Skrabec , Samuel Holland , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , linux-actions@lists.infradead.org, linux-arm-msm , linux-arm Mailing List , linux-sunxi@lists.linux.dev, ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:08 PM Aidan MacDonald wrote: > > The qcom-pm8008 appears to use "1 to enable" convention for > enabling interrupts, with separate set and clear registers. > It's relying on masks and unmasks being inverted from their It relies > intuitive meaning, so it needs the broken_mask_unmask flag. How has it worked until now? -- With Best Regards, Andy Shevchenko