Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d683b37-abb0-a0d6-417a-b5f7c97673c5@marcan.st>
Date:   Tue, 21 Jun 2022 19:07:02 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 1/2] arm64: dts: apple: Re-parent ANS2 power domains
Content-Language: es-ES
To:     Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220602174213.2737-1-sven@svenpeter.dev>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20220602174213.2737-1-sven@svenpeter.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/06/2022 02.42, Sven Peter wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> Turns out that the APCIE_ST*_SYS domains do hard-depend on ANS2, so
> without this they refuse to power up.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
>  arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> index fc51bc872468..a6dbb1f485d8 100644
> --- a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
> @@ -725,11 +725,6 @@ ps_ans2: power-controller@3f0 {
>  		#power-domain-cells = <0>;
>  		#reset-cells = <0>;
>  		label = "ans2";
> -		/*
> -		 * The ADT makes ps_apcie_st depend on ps_ans2 instead, but this
> -		 * doesn't make much sense since ANS2 uses APCIE_ST.
> -		 */
> -		power-domains = <&ps_apcie_st>;
>  	};
>  
>  	ps_gfx: power-controller@3f8 {
> @@ -836,7 +831,7 @@ ps_apcie_st: power-controller@418 {
>  		#power-domain-cells = <0>;
>  		#reset-cells = <0>;
>  		label = "apcie_st";
> -		power-domains = <&ps_apcie>;
> +		power-domains = <&ps_apcie>, <&ps_ans2>;
>  	};
>  
>  	ps_ane_sys: power-controller@470 {

Applied both patches to asahi-soc/dt. Thanks!

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub