Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92c163f6-0527-e8dd-8e4a-e721594630a5@suse.com>
Date:   Tue, 21 Jun 2022 14:33:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v3] net: usb: ax88179_178a: Bind only to vendor-specific
 interface
Content-Language: en-US
To:     Hector Martin <marcan@marcan.st>,
        Jacky Chou <jackychou@asix.com.tw>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220621102150.202475-1-marcan@marcan.st>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220621102150.202475-1-marcan@marcan.st>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDVibnZKbU5XeGNiL2F6dktKanhhbFFSemd2bzk1cnBjVS81YTNRWlA3MlQ4?=
 =?utf-8?B?VTVITjg4WDFrcWd6MEFvdGw1Rm0rSDdZZHprdGNneFRYRWdoczFMdVN5TEFp?=
 =?utf-8?B?VnNqeVZiQU5BdlVlZS9KYUtvQ2NXUzZkTExRdmR5SGRqYjkrSjBMMlhWdmNk?=
 =?utf-8?B?bGZHZkZHalJtUHhicUpPdmhzLzVsVWp5MU9XelhnU0FDWW1heUFnRUZremVk?=
 =?utf-8?B?MVZ6VFpKVmRBcElpd2hhMnNRUVM4N25uUFl3TUVEdVVNMHdNRE9NeWVJSE9X?=
 =?utf-8?B?UGFIWENQSll4SHRxMHExVWcxQkFyQlFwSlF3M0lILzloTHMyRy83eHlNV0Qz?=
 =?utf-8?B?TmMvZjU4SXJwSS8xeXIwenA0SThQMHdLYUZtUVNTYURmaFdtUVFlckdQd0Nk?=
 =?utf-8?B?TlFqMnlvTlpVVFoyQVJVSlRrQWVpWWwzN083WC81amx0QlFyLzVxSDQ2eEtt?=
 =?utf-8?B?VisrUXI3clk4WmwzeVJSZ3V0MFJmR3FMc2lRUzVoL2dqQlR6bUZTQnFqQ1BT?=
 =?utf-8?B?YkJlRlY2MEhoQ3lDcG9RZXpkbU9WeTZYaWZRcUhKZTBvNjAxODRQQlUxNjRE?=
 =?utf-8?B?clFkVTBuMlhTTTRWdGgzdVpKRVlnNDc5T1RXSGp3T2NiN3YycWRPQlh0MFVN?=
 =?utf-8?B?TmdYVFpvMlJJWERhb1czTGpQOTd1cWFnTVBYS1NsR1Q4Q1Arei9rZlhGM1RY?=
 =?utf-8?B?ZkJ2cS9seHZCZnFwSERSOGtJbHRNM21uZFlkc3pYelIxbGF0MWx4dmxNbEtZ?=
 =?utf-8?B?emo1Y25kS3dwWlFwS1Ntbk5YR1oxNkhaNnZEbW9iTy9kbTdqM21YRmRqZFFo?=
 =?utf-8?B?cXlKUUx6eFZKT3NXWmY4dzNJVU5Say9OU0QydWxzcjNYQjA5QzFveWN6QTN0?=
 =?utf-8?B?THNLS2oybXF3ckNRQ3FxNEZQeElCNTdRRXFONlR3THkrb1NIcGRvaUgwWmFv?=
 =?utf-8?B?VGRXT1NIcWFXaXFkUG85aGpJcDVkRjZNYnUxU3ZzbkxkSG1SZzlHMEROTW1i?=
 =?utf-8?B?TlAvVzhYL1g0Sk0xa0RiRjdNM0wxSUF2TGRZWDhkVVgwanF1MFJGTS9VTGp2?=
 =?utf-8?B?elRIbWF6OElZdGFXbmdYN1RRMU5sK3dRUDlaMWFEaHBrR0hNeU9kQXY5TnZX?=
 =?utf-8?B?UHpIalBIa1FCZ0pxTW5EUVY3WEdkejRDV00ydy9oa3pMd2NYMkV1ekNBQUU1?=
 =?utf-8?B?THVFaytwWnpmZnVVQ1VyR3phNi9wZmw0T3pzM2p6NXZ5RXY3YVFtYlQwUDk3?=
 =?utf-8?B?dnZtcHpYcFY2dWRtN0kzUlY1Y0oyWi9wajg4WG9JV2dnUFU3eU9yTlJtbllL?=
 =?utf-8?B?V1E2cDcwa2RoQTV2b3NvQk13VjJNSVVWdGFGcXU3ZDQwb0lscFpFRU9BYjJC?=
 =?utf-8?B?T0l1V3dCdEZ2a0pJRnBxRisvaXNUdnNDSmZweERQbU5MMGdJN0QyV2o2QUln?=
 =?utf-8?B?NVl6bjZDWVZEVys1NTRlT1B1Rlg2eEYvM2R5bGVnRnE3Wkkrc0JZYlFyNSs2?=
 =?utf-8?B?d3o1RmczM1h4c0xUL3NRcis5NWwvVjYrVmlpdWNUL0ZLM1ZzMm5LU2lWYU9K?=
 =?utf-8?B?V1ZERS9pTWdGV2I0Z2RVdEN6eXhSbkZEL3lyTDJHZDUzOThGZXVzbFlDT2hO?=
 =?utf-8?B?ZW5BWUtDeUlzTVJBSXI5RW1XZGlMMitsRkNaWThIQ01hTlp5bFlXU25ZK21U?=
 =?utf-8?B?MG90UlpHbTBDa051cWV2SXo1ZjhwRXc0UHl5MHBCUkhqeTlDYTdVTkQ1YlNr?=
 =?utf-8?B?UVRBdk5ncEoxMjhFdnVWcmloSkRBMzNsVE1lVVJFelhJQmI2OEdwbVQ2QjBV?=
 =?utf-8?B?SDNVRE1oUG9uTDRERkRoUFFMMGlJUEpIaUR2ZjdkQUlxaUQyZ1VmRTVlQzZz?=
 =?utf-8?B?SEJmR3IxaDVKY1pwSjZrY2JwYUpLRGNiQThsK3pONTRXNDNyYVd6QVhPYmd4?=
 =?utf-8?B?RTdML29yLzJueDgyTURsSHNTUkQ4YTVOQktyTnZ4QkRZYkhkL3BDZHFpamxZ?=
 =?utf-8?B?cmpyR0VPcExJNkpYWWFLVkVWSjJRMStyN3Z2T2RRekE2UkNJemV4L29QQ1I4?=
 =?utf-8?B?TDFZWlUvZTIvQlhscElKczAwaTlNdlZJQy9OclJyaDd6cWlwN0M4aVN5c1lp?=
 =?utf-8?B?UFFKRkUrSDlxUzlvOVF1QVVVdkJnOUI4aCtnZFVwbkRaRGVSeG13alBDbE5j?=
 =?utf-8?B?eDdxSTdFYVJSQ0JXNmliQWIzTmY4UVJNdldQU2Y4SU5ZampKUXVnZ1Jla0tV?=
 =?utf-8?B?aEVYY0Z2dENCK1lJQ3JIZ0M1Q2lTUEFlMW9HN1NUV2JxZmxnMUlDMFFKZWZ2?=
 =?utf-8?B?emEvNGViUy9OSkpxQ1JjNlVpU3RScGhPR1N5RGM1eFhnWHdsMmRBaHdpQWtx?=
 =?utf-8?Q?+UBnPVRzfrCKg+TkCjS3ShnKxS/+L/ixdJgwVLh01eBJd?=
X-MS-Exchange-AntiSpam-MessageData-1: OMn18YEXIIYl/g==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5c61eb-a395-43ba-a05c-08da5382513c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 12:34:00.1534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P2KA6dcFGMYv3248IZRCjc5I0UHGAZtf5/9XvP2HfL/sm7D7yKmsf9kYtwNi4xDcwLl7vKZ9qgUpyZvBn+O9qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4810
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21.06.22 12:21, Hector Martin wrote:
> The Anker PowerExpand USB-C to Gigabit Ethernet adapter uses this
> chipset, but exposes CDC Ethernet configurations as well as the
> vendor specific one. This driver ends up binding first to both CDC
> interfaces, tries to instantiate two Ethernet interfaces talking to
> the same device, and the result is a nice fireworks show.

Could you explicitly state here that the root cause is that the
driver for the vendor specific mode binds to the device based only
on vendor:product ID, thus taking interfaces that only the
class driver can handle properly?

This log reads like the basic issue is that it binds to two
interfaces.

The patch itself is fine.

	Regards
		Oliver