Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 14:29:45 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Zheng Bin <zhengbin13@huawei.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        boon.leong.ong@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, gaochao49@huawei.com
Subject: Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when
 CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m
Message-ID: <YrHHyZNJXVme1JIe@shell.armlinux.org.uk>
References: <20220621131251.3357104-1-zhengbin13@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220621131251.3357104-1-zhengbin13@huawei.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Tue, Jun 21, 2022 at 09:12:51PM +0800, Zheng Bin wrote:
> If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
> 
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
> pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
> pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
> 
> Make PCS_XPCS depends on PHYLINK to fix this.
> 
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Paolo Abeni has already sent a patch, which I think is addressing a
similar issue. Please see:

https://lore.kernel.org/r/6959a6a51582e8bc2343824d0cee56f1db246e23.1655797997.git.pabeni@redhat.com

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!