Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbXEXTvu (ORCPT ); Thu, 24 May 2007 15:51:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750877AbXEXTvm (ORCPT ); Thu, 24 May 2007 15:51:42 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:35115 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbXEXTvl (ORCPT ); Thu, 24 May 2007 15:51:41 -0400 Date: Thu, 24 May 2007 12:50:22 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Christoph Lameter , Michal Piotrowski , Andrew Morton , LKML , "Cherwin R. Nooitmeer" , linux-pcmcia@lists.infradead.org, Robert de Rooy , Alan Cox , Tejun Heo , sparclinux@vger.kernel.org, David Miller , Mikael Pettersson , linux1394-devel@lists.sourceforge.net, Stefan Richter , Kristian H?gsberg , linux-pm@lists.linux-foundation.org, "Rafael J. Wysocki" , Pavel Machek , Marcus Better , Andrey Borzenkov , linux-usb-devel@lists.sourceforge.net, Greg Kroah-Hartman Subject: Re: [2/3] 2.6.22-rc2: known regressions v2 In-Reply-To: <20070524193740.GA6787@elte.hu> Message-ID: References: <46558708.2040803@googlemail.com> <46559B54.80106@googlemail.com> <20070524193740.GA6787@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 28 On Thu, 24 May 2007, Ingo Molnar wrote: > > i very much agree that this kmalloc_index() one shouldnt be called a > "BUG: ", but if you look at the majority of WARN_ON() instances they are > checks for clear, serious kernel bugs. I _still_ disagree. There's a huge difference between "You killed my father, prepare to die", and "Btw, I didn't like that, but I'll just continue". And that's the difference between BUG_ON() and WARN_ON(). And dammit, the kernel message should make that CLEAR. It's totally idiotic to call both "BUG". One is a clear BUG, the other is a "uhhuh, something unexpected happened, but I know how to continue". So stop this idiotic "we should call them both the same". If they actually were the same, they'd both be called BUG_ON(). Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/