Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 18:02:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Felix Schlepper <f3sch.git@outlook.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: make sizeof type-independent
Message-ID: <20220621150205.GK16517@kadam>
References: <AM9P190MB1299D518C86D495B168954B2A5B39@AM9P190MB1299.EURP190.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM9P190MB1299D518C86D495B168954B2A5B39@AM9P190MB1299.EURP190.PROD.OUTLOOK.COM>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vQ7OdvX1x3t15821T6OUE2vDyJWOt1Am4ipTq89DSmsOYpvBuJ+PcaPzuJos?=
 =?us-ascii?Q?sK3V6WrzVgXJoSTikpFNaf9FNi2FSAT/4OT3e9JAs6xn2tJ1X7tSAMQuLZ5K?=
 =?us-ascii?Q?GZY8TnnT+MvGiIxU0PYGtENVdqDEX8nWeGJ06zOPrWEAgJEV/Wc5lSL7Ly/i?=
 =?us-ascii?Q?LjZg+f9ZjCIsmmeo5Vok4hzo/4Bit23WVIn0mWTx/bwq97sdg1/TFfFIF9Ju?=
 =?us-ascii?Q?fKPTmTWgU62f3wEAJR6yoy8/20ePNxg8WSLShJWqucfRMz+Nnbd8IVrzCyEN?=
 =?us-ascii?Q?guIMDTFRhcNRcw7xQIeTqc9lpfyiTyHpPTcRUuh1L3zqR9zkKa84jw/xUs6L?=
 =?us-ascii?Q?N2n6gdCGWDAUJ7WfX0M3Cd3M75oapuUlp3Y1eTbPK3adansBqzJnRF7FUiQz?=
 =?us-ascii?Q?9wTVeFLoagEpVWw1wMZiPS8PyO3qiE+ahtj2dSZF5FcXMb7YnQbSt/zw732n?=
 =?us-ascii?Q?IjXPTzD8w5EjJtoec8NWBTe0nMQCP0pZODgXxYFcANLPFttTgpB1NcOGBNx5?=
 =?us-ascii?Q?Tf8avhk6nAbEIbYIqBJwBF0HFlizHEuV5x+g+jiOAPOXRJchezJ8gSF9Bs7P?=
 =?us-ascii?Q?otIVDHRGciv+wfanXNV/uscr54TRW0qD7GERzKKpDLXqPwSgl0qgVMym/5ry?=
 =?us-ascii?Q?QLs6VUhXtuj9V258L+uaO3sO+Tc3V7Qyswz1FAoVnARRb/skE410ap/u2sZK?=
 =?us-ascii?Q?HtULdm9/gZhfs6Nn2olutY06B/WD9DwmecB7NoqgDKhUoiixJJMmJwdx57vR?=
 =?us-ascii?Q?M6B9YfvHU8gefyZJu+5oXDj9lKR1wxa5OsvA+kytZihIF0VtYLvnAtUMXEwj?=
 =?us-ascii?Q?Y5ayJh2cF4tNJscqJ3uHEjUpR4kygHlR5r9GvMZlB327emzihhbppH8C4fl0?=
 =?us-ascii?Q?QsW8E2pTCJoVpD/3KUZhKu1LleI6/LACIW1Yu9khWQS+pU66b/+Cvc1fgOHN?=
 =?us-ascii?Q?hBlIyve1mlCuJ4Fy7oNDFRYhzvO9k1X5Oh2WAKiORpatOhAOaiQh1piAX8pE?=
 =?us-ascii?Q?QJNFpn3Suf7PRqWKjKGMQBinNtYfbagX9O0iWt0dHdrhZY7oFJEYLvzH1+38?=
 =?us-ascii?Q?7xO0Wy+8Ih8B0vl3sqmEFUFE8TiEB8v9fkQ6ES9xOnVmtk45kurDm4Dtt0MS?=
 =?us-ascii?Q?+mhlrse8ZcGgcIV5HkTlUs7sbAGdueeNM8ZeAuQjdR3/pIjHHOQaM/UtTO97?=
 =?us-ascii?Q?X2YonMN0Hw7pkwPdY7jXsG2MoZgwZsrZEKpDjlzdM5UPmj0DemyxerMz3ut+?=
 =?us-ascii?Q?qozxVbqzHAGStpT5L8JeTB7PtsKpa0ABqqS4A28/iIzVzUDxckipX/0IZMfe?=
 =?us-ascii?Q?2NKL2sC5leN+GyWkOtHj4yxL29Q/N9Oa0kWtrDUBBQRBeIl352Xvow/PgMdI?=
 =?us-ascii?Q?7V3g05e7R10bfg+Nmr/WN/pCJ2oKgmtJVthyveRFCYK9HnN489jxkIbMG2jm?=
 =?us-ascii?Q?sLiILfbTvmD2tx6XdkrnqVXs2pp8tIBfvx5hTyFBePDZOepAEnLC+su7U8Cv?=
 =?us-ascii?Q?XWYLwT/wv0x8N5ov8f/0J4lGXjdF0zhJx+gG7caRRpgX6T5KmWkBumG3AqJj?=
 =?us-ascii?Q?IFCEshJX6OVtTwtHjxaUV8G1dRWOVfq1JfALO5tMgo5qofLMjqFWMbjkjR/V?=
 =?us-ascii?Q?kEVaHaKbmgVkhs9ZOiJpzSfFQYTdo6RCUkjUvedYan7Wm0F9duM/kl8+GQZy?=
 =?us-ascii?Q?AwksNlIWTGpGoS28X3yCcJ2xiS24I5rl5I05su8Woqx6ZuMj6JQSbpuddbUs?=
 =?us-ascii?Q?UTRFq1nlpXWoC/zW+tfz0LOUkIbqRZA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: feca769e-b5ec-42c8-cf31-08da53970b89
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 15:02:23.1656
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4b0w+bUdQCaO14Ce31SBxW8IDL6Wn8cNCk+XFxmuq7yK3gnwCjm6un5Iv2+wlXgdW7CzHZ+Qu6Pr4PerAW6kzAjT9JN3OM2KlPHzl1ca2Qw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3234
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_07:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206210064
X-Proofpoint-GUID: khvvc4Bj7Jgd1RbdrUTbDuzO7ZjpanSd
X-Proofpoint-ORIG-GUID: khvvc4Bj7Jgd1RbdrUTbDuzO7ZjpanSd
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 21, 2022 at 04:58:45PM +0200, Felix Schlepper wrote:
> Making sizeof operator type-independent.
> 
> Reported by checkpatch:
> 
> CHECK: Prefer kmalloc(sizeof(*txb)...) over
>         kmalloc(sizeof(struct rtllib_txb)...)
> 
> ---
> Note: First patch, trying to follow kernelnewbies tutorial.
> 
> Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
> ---
>  drivers/staging/rtl8192e/rtllib_tx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index 37715afb0210..01e163e61f0e 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -205,8 +205,7 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,
>  	struct rtllib_txb *txb;
>  	int i;
>  
> -	txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
> -		      gfp_mask);
> +	txb = kmalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);

Use the struct_size() macro instead.

regards,
dan carpenter