Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3916391iog; Tue, 21 Jun 2022 08:23:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uaFb6DoFKM3nLiTgCG1Vo06QBprfevs2puUxhvJg8y9ENcx5fu7W28AZC02rNPR5/WTFyq X-Received: by 2002:aa7:d795:0:b0:435:7fc8:2d1b with SMTP id s21-20020aa7d795000000b004357fc82d1bmr14390069edq.201.1655825021088; Tue, 21 Jun 2022 08:23:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655825021; cv=none; d=google.com; s=arc-20160816; b=a8uCDwBMajp5QyrEtaAyVf+FPZEY+59jm0aY6bMgZooVsSqtIPeXLTdOcI7PsyJbZP teSxLS2c5lVFleUOLC9UpGwqkTMiWLbwt+PQPovHuek1AteGOQvxFAcAt8e0YbD90loZ N503ZFXxf0YMxYfQnMxaU80injD7V9i/xDOKIsWp4h8iAMQWidi4xk9sDSsd8SnOhTOb YCPcYoYE3JnDZoerTIWHbUCvk6uuVOGauEYbu9qMWyZLi4FKlTrqkN4MNfbM7wVbISuq 7GLVwXeBpUZVNUTkbfs5isSkRBHxktXJW0T9Ziu4Ux1LxkDwu9uSV7pcYRvnH3BDudIB zcuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=aVvQHsgZHZOnZwmSoDZ+hFKUeIFDopTBwh+6tB7xSmw=; b=f2v9PmQJR5w+LcEEy4GSpRMwaxBeX/3Bw6uiAUcPeHpDy59w7q6A9P9RQ8BfPL3DxQ BKGZ/D0B7dt7uLJ/WNBxHFUgCuV6kAqFLEF26yWqWG1FiUfEGgqzDEIU+45XBjfSJKum POc5FVB25w71ZVEOYfGk0JhfyzqLCzVKVC275FN6AUD2FfI1yKbkV/cE1VXbARcfDbvU 9DNBArRK2plmVNLB28YZthM8mnyp/naiRLybVvzA8pzYE1fdqJCV7yuwWg/gz4MKQPB/ +DuxmCNzy+FS0oXHkVDhYaY+Y35QplkwNUEFjtXyP7GRlK6ERbKbrJmIvAIVh8+568hX uH+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dx26-20020a170906a85a00b006fe8832ae3dsi3449326ejb.839.2022.06.21.08.23.11; Tue, 21 Jun 2022 08:23:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352737AbiFUPWE (ORCPT + 99 others); Tue, 21 Jun 2022 11:22:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352733AbiFUPWC (ORCPT ); Tue, 21 Jun 2022 11:22:02 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E7D1328E2C; Tue, 21 Jun 2022 08:22:01 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1o3fh4-0001zL-05; Tue, 21 Jun 2022 17:21:30 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id DAA63C01AA; Tue, 21 Jun 2022 17:16:11 +0200 (CEST) Date: Tue, 21 Jun 2022 17:16:11 +0200 From: Thomas Bogendoerfer To: Liang He Cc: yangtiezhu@loongson.cn, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mips/pic32/pic32mzda: Fix refcount leak bugs Message-ID: <20220621151611.GF12206@alpha.franken.de> References: <20220619045427.4064946-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220619045427.4064946-1-windhl@126.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 19, 2022 at 12:54:27PM +0800, Liang He wrote: > of_find_matching_node(), of_find_compatible_node() and > of_find_node_by_path() will return node pointers with refcout > incremented. We should call of_node_put() when they are not > used anymore. > > Signed-off-by: Liang He > --- > changelog: > > v2: (1) merge pic32/pic32mzda bugs into one patch > (2) fix leak bug related to of_find_node_by_path. > v1: use two patch for intit.c and time.c > > arch/mips/pic32/pic32mzda/init.c | 7 ++++++- > arch/mips/pic32/pic32mzda/time.c | 3 +++ > 2 files changed, 9 insertions(+), 1 deletion(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]