Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3943156iog; Tue, 21 Jun 2022 08:53:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t1W0TkV28wZZfTU5ZboJRBzjBcd8Psan6Cwi/ekVMorRW52O9KM+bK92NKGd1GKFZqv51/ X-Received: by 2002:a17:906:7a56:b0:722:df69:3bd5 with SMTP id i22-20020a1709067a5600b00722df693bd5mr5107882ejo.581.1655826802858; Tue, 21 Jun 2022 08:53:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655826802; cv=none; d=google.com; s=arc-20160816; b=pRbThTFDS6dJvAaVjOpn6QF1Sky4aXCLZRq2kRPdwNtQjytWRxyVp6RJJsU/zLqNjC gO7qp7PuIyMx1QWkGuZ3jjE0BoxjfsHySKl2gWsXjSYmbIRCDxif+pSpXkZT9tiYWKDn 8kvTlzxMCot2q64w+vI+xoxnF/AnDu0c33cto1sx+EmUBulhHOOX3oZrSY8ZAeNhxCJq OS8xP0solKBBLYRxYoM3PbdRtvTsGmhMFucw0J7l0NSKj3cClqtmATbkL12kzJYL2Tt/ 2rmRS3JnbC+5VwTVUahAtqYM0eeWA28IXrDJn5PiJdeYZp1oxub+DTe6gIRthQS9KLh6 mL+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=fHS3hPwk6t6lD+BqEUrRIXU1FpMlyu9tJOcdLQbcLe0=; b=wN/ZgGkRKM/jtAjJ4fARwVUZhWy4bwiFJGIJUJYxSXx18QZs+O9WIzQxtXrltDf8Hq kZiVIDbo/9vI+Yu+h9I7hl1wXR88yWWtBfouGHeJS4Tfq1k4TofeYlxJSDlNPjIf4KHw 9MLv/CTddq1+lYrwnW5gU1GR9tD11vzd/gL3T3Uk1sEdQia/+uqRfBq7Fje/siG6lESt QK/4ng80pRUHddVmnvQlomSYDcEPwjLISB8lxO/O8i3Cha/eS1NR6lcXRpV82KZSMBHc EEcQE2KIgtsYhhiQbI37DTJPTXX4a2pLF7oWqdIuiAZa3UTdGLXCWZslPn4qPKaHghCm ZADg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a17090673c900b00706d5138d5bsi2079094ejl.183.2022.06.21.08.52.54; Tue, 21 Jun 2022 08:53:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352089AbiFUPB2 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 Jun 2022 11:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236418AbiFUPB1 (ORCPT ); Tue, 21 Jun 2022 11:01:27 -0400 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3172526553 for ; Tue, 21 Jun 2022 08:01:24 -0700 (PDT) Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D50E351D9; Tue, 21 Jun 2022 15:01:21 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id B87FD2000F; Tue, 21 Jun 2022 15:01:18 +0000 (UTC) Message-ID: Subject: Re: [PATCH] net: s390: drop unexpected word "the" in the comments From: Joe Perches To: Alexandra Winter , Jiang Jian Cc: wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 21 Jun 2022 08:01:17 -0700 In-Reply-To: <09b411b2-0e1f-26d5-c0ea-8ee6504bdcfd@linux.ibm.com> References: <20220621113740.103317-1-jiangjian@cdjrlc.com> <09b411b2-0e1f-26d5-c0ea-8ee6504bdcfd@linux.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.1-0ubuntu1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Stat-Signature: nbwwtqkrsbqnzwh9ramyn7pzw1fuzn1n X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: B87FD2000F X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+sUyxK4FFvpDjZtlXFNMosIz2P+MhhHMw= X-HE-Tag: 1655823678-383585 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-06-21 at 13:58 +0200, Alexandra Winter wrote: > On 21.06.22 13:37, Jiang Jian wrote: > > there is an unexpected word "the" in the comments that need to be dropped [] > > * have to request a PCI to be sure the the PCI > > * have to request a PCI to be sure the PCI [] > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c [] > > @@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index, > > if (!atomic_read(&queue->set_pci_flags_count)) { > > /* > > * there's no outstanding PCI any more, so we > > - * have to request a PCI to be sure the the PCI Might have intended "that the" and not "the the" > > + * have to request a PCI to be sure the PCI > > * will wake at some time in the future then we > > * can flush packed buffers that might still be > > * hanging around, which can happen if no And this is a relatively long sentence. Perhaps something like: if (!atomic_read(&queue->set_pci_flags_count)) { /* * there's no outstanding PCI any more so: * o request a PCI to be sure that the PCI * will wake at some time in the future * o flush packed buffers that might still be * hanging around (which can happen if no * further send was requested by the stack) */