Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <88f11e5c4704bd8510c2c6a171536484a2232f82.camel@nxp.com>
Subject: Re: [PATCH] drm/bridge: imx: i.MX8 bridge drivers should depend on
 ARCH_MXC
From:   Liu Ying <victor.liu@nxp.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Marek Vasut <marex@denx.de>
Cc:     dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 21 Jun 2022 23:47:16 +0800
In-Reply-To: <43645c9b5cd657664c1340d40133f2116c8cef43.1655818025.git.geert+renesas@glider.be>
References: <43645c9b5cd657664c1340d40133f2116c8cef43.1655818025.git.geert+renesas@glider.be>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d09tMzU2b0hWdEJITjV3RmZSNDRrdEVEdnBlb20zNmJSL0JOQ0FXWVl6Tklj?=
 =?utf-8?B?azVnWXo3WnRRWGV1WjRXWEtBaTRrUlpjQy9Ia29Obkc1NEdzK1Q0cnhsUDd2?=
 =?utf-8?B?Yk5kUjEzMU9KNGdWWUMxVVJWY2d0YXVidTJkYkwvc0pTVk5JWTZhM0I5Rytu?=
 =?utf-8?B?ZVBsaWVHcGpTRkV6NVZjK0ZRMWpjYjA1QlZaNDh2YXh3MThGT0dNbVJJNmNQ?=
 =?utf-8?B?TUR0NVBGUERVSEFTcjl1dDBoMDRUU3U2SCs4bGZRV2tucGtra2ZXbHpBcmpW?=
 =?utf-8?B?MkJUeFJHQjFTYjY5RjRrTStCaE1aVzlxU3RPWjVheDErdno0NGc4aU51a1Fy?=
 =?utf-8?B?enlBOFFtOG8wby9tSzNCWjg3V1lQS2RFbzhFVXNVa0pSeVFVSVRpeU1PRzdG?=
 =?utf-8?B?bytxeTBCc1NKdWI5WmE3bjhtSHpzRzZ2WE1LM1dzOW9qVk42V3NWdU5KT3BS?=
 =?utf-8?B?V1c1YnFKZDl2ZVJQYnJTdmRIeFprNnA0emd0QnlZWVNxT1UwQUhrTG5xU2tx?=
 =?utf-8?B?cld1ZmtpTDVWTzFnaFgvK0tGRnNWaGFtMStUM2I1YUVPa1Z5S3NtZzJOSldQ?=
 =?utf-8?B?MjRwRWxvU2l6SEtsWit4UzZNQ0tNRndXMW1jQk9ubFBMb3lTbTA2UUMyNFhW?=
 =?utf-8?B?TW4yOU8yYjJDNWswZjVYYkNReitYM25VN0tPalZZMFBRdkhQR2pnenFRR1Vi?=
 =?utf-8?B?NGRscEtCRWl6MDVyMkdWNWQ2Q2s4ZkdSc3hpdVd6azk0NlEvdWhraEozQnpr?=
 =?utf-8?B?RzUyR25xVGg5WFRTSVJvMnF6K2pmYy94NVJqZmhUWmxvaTNaMk9iVElZZ2RS?=
 =?utf-8?B?MUxFRElXRlZjSEFKOXE0aVp2RU5TaFgweks4UnRCS0RZTEdHYUFzV0d1YytB?=
 =?utf-8?B?Vnlnc3JsUUorM2xSU2djTHdBSTlyT0ZyYmNUZVlpY2dsZVlGTU9TdTJqVVhJ?=
 =?utf-8?B?R3MrVHZOV1lWaDJCN2YvUFdGb3Y1L2sweFJPZDROa0NNcUYxRGxJdXZDVEdM?=
 =?utf-8?B?eTFlaTFWRWo3WjNzOWZPckZDUFJqZjZ2cktHTUtEaWYyUlVMK1dYZ1oxTFI1?=
 =?utf-8?B?anBpYXJDaHNVNFc2ZUtKOGo2TEw5MHdnbWpvcUprV0QzRVVLZ0RHVFFxdStV?=
 =?utf-8?B?WVRUUUhrVHc0VDZVdTJMczFRbjJnK1k3MlEwU3pGNnM2enN4cHhDTncwb1Jp?=
 =?utf-8?B?c25HOHV3MFNjbnRVdGRiWWhmQ3NUVjk2VXR1Z3RLZTRkcVUzNzlWa3JJVGpB?=
 =?utf-8?B?anVZSUtodE1NeEYyWVVJbmlINVFRS2JUOGhUQWFqbklwckxZNXFxTHlFcFg2?=
 =?utf-8?B?VFhtRVpyMXpyRkhJWGRPTkorN29zTjY1TEZGNUVjd25meElkanhMdmllN05M?=
 =?utf-8?B?dnFhUy8zMDBzclIrQnVRaGtFemNzMnlURVZ5Mzl1dXNJamgwTGNTbFViZEF2?=
 =?utf-8?B?bHliUUNxZ1M2NmVyMThwWHlLUnJNZGMrNHhucUdjVWNkV3FYZUxoTG1IbVJ1?=
 =?utf-8?B?ZFhISi9ORXp4bkFuSGloQlRlSzBCZHY2Snk0eVBIWThLWkpVODNIZVRHK0VO?=
 =?utf-8?B?dHE4OGRKMFR1U2piWUh5MmhVS2pFZGlPMWZlQko2RS82T0FPQlJyajd6cGNi?=
 =?utf-8?B?dmVaU0NUMnRkY0EyTkcyeXVqUXFMMk9SL1FVMFFWcFMwTGR5cHVLSHZUcHBa?=
 =?utf-8?B?NG40NXQ4OVBkQTF5QVlVaW1NeDMxcm51SDFpQzlDKzd3REUweUFIZlpWSjMv?=
 =?utf-8?B?a1lPTEdCdjlGTFRTOEdSU2RSWUU4dzAvZGNQa0ltZmhkRTZVbFJkUSs5a0Jw?=
 =?utf-8?B?RW1WMlhheS9uQjA4clEzbHRCM292NkZjN2Y4WWthSDVqNzBXUmpiQVRJVGxv?=
 =?utf-8?B?RWtUQzUwM1FqYkVweW1kbGx3NHZpV28xNTYrWDBQUlZkTWJPME9PNVhnRjR2?=
 =?utf-8?B?Q21sZ3A4OUtjTTEwWVRiMC9NQS9DcDhpNXNLeG9QU1R3UkdpVnVCV0o2MGpz?=
 =?utf-8?B?NCttWkpPV21vRWhXcEMvNmw5Wmp6bzlxNHdlU0ZCSW8vVkpGVm1EcHN4eGF6?=
 =?utf-8?B?UWwydXFBVWZWVm50Lzl2SFZzRjFabkIxR25LZC82V0FvVjk4YlhBWFY5aDVB?=
 =?utf-8?B?NnhYd2RwVjVNbUFzOXB2OXhRZ1p4WDZzdGxxaGZkM3ltTFU0VXRmbGJpZE1l?=
 =?utf-8?B?QTZTQ2ZiZlB2QmZudHRIVFI2MjhqY0hER0pQWi8vQTJIVzIrS0liaEVXT0F4?=
 =?utf-8?B?QzNwQUxzTmkyYXZ3OHhKeVYrNitKSmcvUmMvYTRzaDJRUG96VUhKL2MxeTR6?=
 =?utf-8?B?SkliT1JGTExESXJEcDR2Vm1ocnZqaU8wMDVTcElHZkNydHVUTHQ1UT09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc050d4-e736-46bf-a914-08da539d57ce
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 15:47:27.6978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OQVIhC2LYwfZpyAnk/GKY+PDA8iywH1R0j9LArkv1VtWUh59A31D5c2E3p12UNHlwDdQ3VHBGg4Yuiy80Th41A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4906
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote:
> The various Freescale i.MX8MP display bridges are only present on
> Freescale i.MX8 SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> asking the user about these drivers when configuring a kernel without
> i.MX SoC support.

s/i.MX8MP/i.MX8/

For now, only i.MX8qm and i.MX8qxp display bridge drivers are in
bridge/imx directory, no i.MX8MP display bridge driver.

With this fixed:
Reviewed-by: Liu Ying <victor.liu@nxp.com>

> 
> Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for
> i.MX8qm")
> Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for
> i.MX8qxp")
> Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to
> DPI support")
> Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display
> pixel link support")
> Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel
> combiner support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Probably the remaining i.MX bridge drivers in
> drivers/gpu/drm/bridge/Kconfig (e.g. DRM_FSL_LDB) should be moved
> here,
> too?

DRM_FSL_LDB is for i.MX8MP LVDS Display Bridge(LDB).
Here is a kinda appropriate directory for that driver I think, though
the filename fsl-ldb.c is perhaps a bit too generic(we have imx8qm-ldb-
driver.c and imx8qxp-ldb-driver.c). 

No other bridge drivers can be moved here, AFAICS.

Thanks,
Liu Ying 

> ---
>  drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/Kconfig
> b/drivers/gpu/drm/bridge/imx/Kconfig
> index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644
> --- a/drivers/gpu/drm/bridge/imx/Kconfig
> +++ b/drivers/gpu/drm/bridge/imx/Kconfig
> @@ -1,3 +1,5 @@
> +if ARCH_MXC || COMPILE_TEST
> +
>  config DRM_IMX8QM_LDB
>  	tristate "Freescale i.MX8QM LVDS display bridge"
>  	depends on OF
> @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI
>  	help
>  	  Choose this to enable pixel link to display pixel
> interface(PXL2DPI)
>  	  found in Freescale i.MX8qxp processor.
> +
> +endif # ARCH_MXC || COMPILE_TEST