Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Jungclaus <Frank.Jungclaus@esd.eu>
To:     "mkl@pengutronix.de" <mkl@pengutronix.de>
CC:     =?iso-8859-15?Q?Stefan_M=E4tje?= <Stefan.Maetje@esd.eu>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "wg@grandegger.com" <wg@grandegger.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH 0/1] can/esd_usb2: Added support for esd CAN-USB/3
Thread-Topic: [PATCH 0/1] can/esd_usb2: Added support for esd CAN-USB/3
Thread-Index: AQHYhOP3yq7RQNsW6EGORRWfCWoTWa1ZaEmAgACbqgA=
Date:   Tue, 21 Jun 2022 15:52:11 +0000
Message-ID: <6dc713b8f502857388e411103bf0d31e4c15dd65.camel@esd.eu>
References: <20220620202603.2069841-1-frank.jungclaus@esd.eu>
         <20220621063501.wxxpotw6vck42gsn@pengutronix.de>
In-Reply-To: <20220621063501.wxxpotw6vck42gsn@pengutronix.de>
Accept-Language: en-001, de-DE, en-US
Content-Language: en-US
user-agent: Evolution 3.36.5-0ubuntu1 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?KS58TmqbJD4Qx4FBQk7Q7O7qZZVw+82nn+pye9UEirwOKVcklzgAS75N8?=
 =?iso-8859-15?Q?bSxnjxirg0gbXgKUy51liQV1OX2snUEPPfpiWOPMhcXrzOFceEhwgEO7H?=
 =?iso-8859-15?Q?LKTHXZsSmoAnM+cOEsJRZgUvTD8hcWULN1t7VP/7a5MGASJP49i1QfjcV?=
 =?iso-8859-15?Q?xUZzwFFLmH4LlNmw2Gp3YtoLrZ3O6gP0h/Cu5+7QkhPZ+rYCR7OP9pObK?=
 =?iso-8859-15?Q?3PnRuAVnyFDoWWX2MF52IMA7OlQNlb5VALQR0T2G/UczPV8g4G1vUxgU2?=
 =?iso-8859-15?Q?qOUl1RpAkqM4fuDtgSrogpuShzOXIGopIg/3clXuUNTfUmR8EfexGoFOi?=
 =?iso-8859-15?Q?V6BkPg92qziPWqgOo/XAzr6Sn5BFeEoEMxVfk486RMjOyGj1HqqCNvYfd?=
 =?iso-8859-15?Q?ZVe8vuwn33+K/JvdygAhRlxJO1MDayCGyAfq0m7yPi+upSDed1qiHbE27?=
 =?iso-8859-15?Q?X7IiTHkcxHVCQ+xZVPlE39cgOSU85WdbCoZV5cw3tKI36rDh4CK1sTj/F?=
 =?iso-8859-15?Q?p/WU3UeSlRDBf4vPXCdSw7I9rup4jD+ABW+8vaDmyr6XRKrdVqaJB2i+q?=
 =?iso-8859-15?Q?L4Jr4jscrNES4UViaDimZDhlLBK6QZUWFLl0pR/G4k2fHJ2xSKD5bEGBi?=
 =?iso-8859-15?Q?nOfV7DBmNsp9UATVssFid24HW25O9sJWMMJsb3uHqsiKCt99eHspsm4n6?=
 =?iso-8859-15?Q?sOO2wPPB+qAWz5UoRHg69cfFrVlTKk5SqteTJvYkhDIFh8oEdoaSHcHHa?=
 =?iso-8859-15?Q?h7H19CUddAhiDtX3glrzmGxsZF9Kde9F/lZkRWkbGnPFB4U6bPfc7l66y?=
 =?iso-8859-15?Q?QmmQG82ChkSnkX1Nq7g6f7OCgsegidpPqYy0U/9rV9rSdjSaij+lB3c2h?=
 =?iso-8859-15?Q?bnsLp/TDvCgzr6ddN9cH/Qi/J36om45t7RplgGdVDbv9SVtlRuMz8vFij?=
 =?iso-8859-15?Q?yonJnqLD1KwOg5Qz487Ipc53pFtW8txPQjbcHlG0PkfC0PPBGkcCNuPLy?=
 =?iso-8859-15?Q?wUzzcGGy3TCGqWITZrcHOiJsFS9rKITubM1HpdMIhN+SYXs8q4Fa/TPwx?=
 =?iso-8859-15?Q?wLwOy6Z2UXj+VY5OSOUyTdqpfR81P/Xf1+c8Zjqk4PPTv6an2kkhaSBwE?=
 =?iso-8859-15?Q?yFC/yGQXaJyBvPfNREgMu34S2D8SOvARC3dx5Mgv7vxaA2shGBcLG06B2?=
 =?iso-8859-15?Q?ruQ4hD6w24Zo+PJKZeQlyNJdbuHMlXYYpuZZXhziOjfhzQ6qAsboTxS6u?=
 =?iso-8859-15?Q?6u3gogL7a4cRL4wmVh2I/3m/F0Xuwc/EQSb2hRrvmwxjN5uPU45fbklNH?=
 =?iso-8859-15?Q?YSRQAU2Jqx5ZmmiMc9fBNiy/onmew8kqerZ0PpZMtLZ2MjQ673oEB+msG?=
 =?iso-8859-15?Q?BtOlsM45cHHt3J3A+e5W/DNoG23P/f90Xe56X8J996o4nSMH0FuS+t+q7?=
 =?iso-8859-15?Q?zOXESv9KHP7zIL9FeA86DFJtkng7PkNlAh2o960xdS4xK7LGVl/39mxw+?=
 =?iso-8859-15?Q?IbKlaKVgfBKZFCxcUJJfWRZZPXNwQ+pjF0bj4PTWnL6iPLbti2dh+zEui?=
 =?iso-8859-15?Q?mnyXNFOFSwE7C2+TSFE5APKD1ZX12AKcVHVwW3VAHAgJ9jGPQIXC/A68T?=
 =?iso-8859-15?Q?MrupPX0mgXkWEsPxyEcEvZ0rjGHha9bGduycWRC/SiUPfBvL5a2kP4lLB?=
 =?iso-8859-15?Q?YOLl0CPSFu+nvNBq7pLcmiuHP8EvaRnS/gHQ+inIs5EuDzFVB3F4Lf+vM?=
 =?iso-8859-15?Q?VxNY2XeLD3JLfiJfgG9iHR27xdymm72f/GFToWqbGcLaqbmD3ah5JM9e3?=
 =?iso-8859-15?Q?UBjX8CVo5STOYD/cNlFn9e8PLhmX3yuByI5o22qYwK3J3n+wUK2ZpBzuq?=
 =?iso-8859-15?Q?FnPc=3D?=
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <BECA7D16E6E99246AFAFE9202D22D02A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: esd.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS4PR03MB8436.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef46267-1402-497b-109d-08da539e0123
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 15:52:11.5203
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5a9c3a1d-52db-4235-b74c-9fd851db2e6b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zDaTAYFwur9uWVZ94ZUdkyH58jFz8u9tsB8P6T7+EFI/BTMDFFghOBZSZSOYm0zSTujfw1288RLDY52a+YFN/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4422
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2022-06-21 at 08:35 +0200, Marc Kleine-Budde wrote:
> Hello Frank,
>=20
> thanks for your patch!
>=20
> On 20.06.2022 22:26:02, Frank Jungclaus wrote:
> > This patch adds support for the newly available esd CAN-USB/3.
> >=20
> > The USB protocol for the CAN-USB/3 is similar to the protocol used
> > for the CAN-USB/2 and the CAN-USB/Micro, so most of the code can be
> > shared for all three platforms.
> > Due to the fact that the CAN-USB/3 additionally supports CAN FD
> > some new functionality / functions are introduced.
> > Each occurrence of the term "usb2" within variables, function names,
> > etc. is changed to "usb" where it is shared for all three platforms.
>=20
> Can you split the patch into several ones. Please do the renaming first.
> There's some seemingly unrelated reformatting, this could be a separate
> patch, too. If this is too much work, you might take this into the
> renaming patch. Then add the new device. This makes reviewing a lot
> easier.
>=20
> > The patch has been tested against / should apply to Marc's=20
> > current testing branch:
> > commit 934135149578 ("Merge branch 'document-polarfire-soc-can-controll=
er'")
>=20
> Note: Better use the linux-can-next/master branch as a base, it will be
> only fast forwarded. The testing branch will be rebased. As you don't
> depend on any new features, it doesn't make any difference for you.
>=20
> regards,
> Marc
>=20
Hello Marc, hello Vincent,

I did not expect to get a response that fast ;)

Thanks a lot for all your annotation work, suggestions and remarks.
I'll try to take them all into account. Than I'll send a series of
separate and much smaller and easier to handle patches.

Regards, Frank