Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbXEXU3k (ORCPT ); Thu, 24 May 2007 16:29:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750929AbXEXU3c (ORCPT ); Thu, 24 May 2007 16:29:32 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:54033 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbXEXU3b (ORCPT ); Thu, 24 May 2007 16:29:31 -0400 Date: Thu, 24 May 2007 13:27:37 -0700 (PDT) From: Linus Torvalds To: Pavel Machek cc: Romano Giannetti , Chris Wright , Chuck Ebbert , Linux Kernel Mailing List , stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, "Rafael J. Wysocki" Subject: Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review In-Reply-To: <20070524200435.GA9604@elf.ucw.cz> Message-ID: References: <20070521191612.800400000@sous-sol.org> <4652070D.3090509@redhat.com> <20070521212522.GL3429@sequoia.sous-sol.org> <1179870110.16656.2.camel@localhost> <1180008394.15600.26.camel@localhost> <20070524200435.GA9604@elf.ucw.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 29 On Thu, 24 May 2007, Pavel Machek wrote: > > If someone does request_firmware from resume function... that's > bad. Resume function should be fixed. Pcmcia? ti12xx driver? Probably pcmcia "ds" driver and CONFIG_PCMCIA_LOAD_CIS. > Well. we'd like to present hardware in working state as soon as we > resume (if eth0 was there before resume, it should be there after > resume. not 3 seconds after resume); so if someone needs to load the > firmware, they should just store it in the kernel memory, and load it > during boot or during (very early) suspend. Equally arguably, we should just have a "resume_late()" call that can be used to do this after everything is up and running. And quite frankly, I don't actually see any reason why firmware loading shouldn't work in the resume path. I really do think that this is ANOTHER bug that has no other reason than the fact that that f*cking freezer killed the system for no really good reason. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/