Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 21 Jun 2022 17:39:02 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marek Vasut <marex@denx.de>,
        Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: mxs_lradc_ts: Warning due to "0 is an invalid IRQ number"
In-Reply-To: <CAOMZO5B6606rwWoG-ydEz2UQpnj9QhUK2b5dCHRtp9u=Pe4new@mail.gmail.com>
References: <CAOMZO5D7z=Eg=WYgzrpqn9VoU8HxMeBbEZiv9KLjMVD1_kRo+w@mail.gmail.com>
 <20200701224145.GA3616172@bjorn-Precision-5520>
 <YrHPA+TBKZU/RuSz@smile.fi.intel.com> <87o7ym2fcv.wl-maz@kernel.org>
 <CAOMZO5B6606rwWoG-ydEz2UQpnj9QhUK2b5dCHRtp9u=Pe4new@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <128b8f7dffe45dc241ad571e8a273a2e@kernel.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Fabio,

On 2022-06-21 17:23, Fabio Estevam wrote:
> Hi Marc,
> 
> On Tue, Jun 21, 2022 at 12:41 PM Marc Zyngier <maz@kernel.org> wrote:
> 
>> Something like the hack below could potentially make things less
>> broken, but I'm not holding my breath. If nobody cares, let's remove
>> the code altogether.
> 
> With your patch applied, the warning is gone, thanks.
> 
> The touchscreen is registered:
> 
> [    8.207461] input: mxs-lradc-ts as
> /devices/soc0/80000000.apb/80040000.apbx/80050000.lradc/mxs-lradc-ts/input/input0
> 
> but when I run  "cat /dev/input/event0" and touch the screen, no irq
> event is generated.
> 
> Looking at cat /proc/interrupts shows that no mxs-lradc-touchscreen
> irq happened:
> 
> 216:          0         -  10 Edge      mxs-lradc-touchscreen

I'm not sure I can help you further on that. '10' seems to be
the correct interrupt for the interrupt number (irq index 0 in
the lradc device).

You'll have to debug it further, I'm afraid.

         M.
-- 
Jazz is not dead. It just smells funny...