Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 21:47:57 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jiang Jian <jiangjian@cdjrlc.com>
Cc:     tsbogend@alpha.franken.de, srinivas.kandagatla@linaro.org,
        rafael@kernel.org, sudeep.holla@arm.com,
        alexandre.belloni@bootlin.com, xkernel.wang@foxmail.com,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.
Message-ID: <20220621194757.ay4z6bbwev7ibggs@pengutronix.de>
References: <20220621162114.23723-1-jiangjian@cdjrlc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s4a723nibkbfrw2k"
Content-Disposition: inline
In-Reply-To: <20220621162114.23723-1-jiangjian@cdjrlc.com>
Precedence: bulk


--s4a723nibkbfrw2k
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The Subject speaks about two places, there is only one change here
however?

On Wed, Jun 22, 2022 at 12:21:14AM +0800, Jiang Jian wrote:
> file: ./arch/mips/sgi-ip22/ip22-gio.c
> line: 44
>   * @ids: array of of device match structures to search in
> changed to
>   * @ids: array of device match structures to search in

I know writing a sensible commit log is hard, but this is really very
useless. This is a plain repetition of the diff below.

Additionally I'm not sure the patch is right. The comment speaks about
of (=3D open firmware) devices. So if you want to improve here, maybe make
it read

+ * @match: array gio_device_id structures to search in

But please double check this is indeed sensible; I didn't.

(But yes, @ids is wrong, the parameter is named match.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--s4a723nibkbfrw2k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKyIGoACgkQwfwUeK3K
7AmWRAf9GbhbYFWPzdOQIDbXFeD1he67uvEGsTTtcwrsgq8b1KGkXdzVvxLwlm2p
qUSDzZ3aS+jP/ScaLCkO3FRo/LfliAPKI6a26M/SeZf2F0jnNUjqcbDyQ7kjFbx2
eJ4dzoG7VBWe5GZfRxwzCjUKSVqUENqyCX85tMpo8cA0Jvv1lQcJSWz+kvrHUaiI
00cEWRsCOFCJPFRgUbu9yUQpKr+Hc6s9ahlTq4G+Ato63IeYtPV8wcqfD8gg7BuX
So6/w0bOfN8LCfUZ2pAHBC7ssoTPRgjcpjIL9hxGwWKk3Xr1qjkMJcn+xKdbTTCx
OitQ5aizcuZxM9yeP6uAwzFLFGygMg==
=jxEL
-----END PGP SIGNATURE-----

--s4a723nibkbfrw2k--