Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 21:50:46 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Francesco Dolcini <francesco.dolcini@toradex.com>
Cc:     Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
Message-ID: <20220621195046.rnv66d2333wjmtow@pengutronix.de>
References: <20220512104019.19725-1-andrejs.cainikovs@toradex.com>
 <20220621180749.GA22098@francesco-nb.int.toradex.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cymwswx3km3vprca"
Content-Disposition: inline
In-Reply-To: <20220621180749.GA22098@francesco-nb.int.toradex.com>
Precedence: bulk


--cymwswx3km3vprca
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21.06.2022 20:07:49, Francesco Dolcini wrote:
> Hello Shawn, just a ping on this.
>=20
> Francesco
>=20
> On Thu, May 12, 2022 at 12:40:19PM +0200, Andrejs Cainikovs wrote:
> > Update SPI CAN controller clock to match current hardware design.
> >=20
> > Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/ar=
m64/boot/dts/freescale/imx8mm-verdin.dtsi
> > index 0d84d29e70f1..d309bc0ab8f6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > @@ -32,10 +32,10 @@ backlight: backlight {
> >  	};
> > =20
> >  	/* Fixed clock dedicated to SPI CAN controller */
> > -	clk20m: oscillator {
> > +	clk40m: oscillator {
> >  		compatible =3D "fixed-clock";
> >  		#clock-cells =3D <0>;
> > -		clock-frequency =3D <20000000>;
> > +		clock-frequency =3D <40000000>;
> >  	};
> > =20
> >  	gpio-keys {
> > @@ -194,7 +194,7 @@ &ecspi3 {
> > =20
> >  	can1: can@0 {
> >  		compatible =3D "microchip,mcp251xfd";
> > -		clocks =3D <&clk20m>;
> > +		clocks =3D <&clk40m>;
> >  		interrupts-extended =3D <&gpio1 6 IRQ_TYPE_EDGE_FALLING>;

You don't want to use an edge triggered interrupt with the mcp251xfd
chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--cymwswx3km3vprca
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKyIRMACgkQrX5LkNig
013PCAf9HxzrgOryxn9dqLo2SGEyP6jPeoxhZTOyjTQ00GRTYV2EaKa9f23ylcxz
SeiRPsfCf8mj2DcONhgkHTxDGGCL3mp7CJLnGa5hVEVqCMqSq8D7ThFx6RflDNg+
96Qf8F9LoQOlA+jBmR2KhSNFDzYWTKiwlGur/FrRRpvQephmk/9onhw/fzgZZkCx
2xwSEcE7hZyMy6KBOxcFEg4yVeN7t6TQuXfmzyuV/KqEEGacTwWXovoagVQFDElo
poDx/GH++myJCfZgOKNh1Wrm39A6Q+YI3XLscKWgj+dMf5EdOxdl7Vw7lKpAmLI2
ElEYlv+GQ2vDD8mLXwEMuVArHhzKPA==
=E6rx
-----END PGP SIGNATURE-----

--cymwswx3km3vprca--