Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbXEXVDt (ORCPT ); Thu, 24 May 2007 17:03:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750942AbXEXVDl (ORCPT ); Thu, 24 May 2007 17:03:41 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:36963 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbXEXVDk (ORCPT ); Thu, 24 May 2007 17:03:40 -0400 Date: Thu, 24 May 2007 14:01:54 -0700 From: Andrew Morton To: Romano Giannetti , Sam Ravnborg Cc: Linus Torvalds , Chris Wright , Chuck Ebbert , linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , alan@lxorguk.ukuu.org.uk Subject: Re: Long delay in resume from RAM (Was Re: [patch 00/69] -stablereview) Message-Id: <20070524140154.c8e93d69.akpm@linux-foundation.org> In-Reply-To: <1180037649.15241.6.camel@localhost> References: <20070521191612.800400000@sous-sol.org> <4652070D.3090509@redhat.com> <20070521212522.GL3429@sequoia.sous-sol.org> <1179870110.16656.2.camel@localhost> <1180008394.15600.26.camel@localhost> <1180019201.15600.57.camel@localhost> <1180037649.15241.6.camel@localhost> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1506 Lines: 45 On Thu, 24 May 2007 22:14:08 +0200 Romano Giannetti wrote: > Compiling now. I had lost a lot of time because at first try it stopped > in ntfs: > > CC [M] fs/ntfs/super.o > fs/ntfs/super.c: In function ___init_ntfs_fs___: > fs/ntfs/super.c:3152: error: expected ___)___ before ___NTFS_VERSION___ > fs/ntfs/super.c: At top level: > fs/ntfs/super.c:3262: error: expected ___,___ or ___;___ before ___NTFS_VERSION___ > make[2]: *** [fs/ntfs/super.o] Error 1 > make[1]: *** [fs/ntfs] Error 2 > make: *** [fs] Error 2 > > I suppose because NTFS_VERSION were defined as EXTRA_CFLAGS too in the Makefile, ntfs is being naughty. --- a/fs/ntfs/Makefile~a +++ a/fs/ntfs/Makefile @@ -6,7 +6,7 @@ ntfs-objs := aops.o attrib.o collate.o c index.o inode.o mft.o mst.o namei.o runlist.o super.o sysctl.o \ unistr.o upcase.o -EXTRA_CFLAGS = -DNTFS_VERSION=\"2.1.28\" +EXTRA_CFLAGS += -DNTFS_VERSION=\"2.1.28\" ifeq ($(CONFIG_NTFS_DEBUG),y) EXTRA_CFLAGS += -DDEBUG _ akpm:/usr/src/linux-2.6.22-rc2> grep -r EXTRA_CFLAGS . | fgrep '+=' | wc -l 131 akpm:/usr/src/linux-2.6.22-rc2> grep -r EXTRA_CFLAGS . | fgrep -v '+=' | wc -l 55 hm, lots of Makefiles commit the same sin. Sam, is this as busted as I think it is? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/