Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc8d3d9d-fa62-7e90-9809-449b7338800d@intel.com>
Date:   Tue, 21 Jun 2022 13:40:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [Intel-wired-lan] [PATCH][next] iavf: Replace one-element array
 in struct virtchnl_iwarp_qvlist_info and iavf_qvlist_info
Content-Language: en-US
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
References: <20210525230429.GA175658@embeddedor>
 <ee2c8631-6e3f-c113-cc8e-29834bcc348e@embeddedor.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <ee2c8631-6e3f-c113-cc8e-29834bcc348e@embeddedor.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3kzbnk0anprU2oxWDM5RkJ4YlFHSHllWWhiTUJBZ3g1eTRRK2EwVmZiWENj?=
 =?utf-8?B?WHVsZ0RWK2pCaHNSSmprRGdVemZ6dkY3Z0k0dVI1a3pqUURyK0h2L2JWOHMw?=
 =?utf-8?B?bEg2OUprREhheTJsS2xTcFd1Q2NkSE90TERhT2xuM0RvSjRFSFpMSU5DQ0dB?=
 =?utf-8?B?UDNKVS9XVWh4UjZpK0xOWHR0aTVBZ3ZHTnlHWGpGa3VMa3lHaWNtc3pXcHZY?=
 =?utf-8?B?Wjlsc3N0azVlS0NjYUxhdnJxRVhLZEs4NDFMR0lVU1NKNzg5YmpIL2Q0MEJq?=
 =?utf-8?B?N0JjS29tdjVWeUszVTBob2krWWRRYnBnTWNqODJCZkJFTDhzNm1ROWRHYmhq?=
 =?utf-8?B?NFNJWDVpd0tYeTdmSmhhVG9DTVNPNGt0Y2JiRXFRTlZzeEVTbzRyTUJWMFZs?=
 =?utf-8?B?NDFBTE9jVEExRm4vckxCS1llbDJDOE1tK0FpOHdnQ0k2ckZqMVhHTzVaNWUy?=
 =?utf-8?B?Q2tnZ0wyZ2pGYmRNRkcxRUpFM0UvRUMrM25KWWhsZ2dqb3RkSmtUY3NCcXpL?=
 =?utf-8?B?S2FPb0VzbEpFZWp5NXlxejMzeWxDMVlyOFZuOWlmRmx2eUsrY1JzZTRRQ2pr?=
 =?utf-8?B?c2tXeGlXVHE3TGtCVW1yTlJ2aElNeGdkMmo2VHJ0NG15VDdZSEQ1K3UwcDE5?=
 =?utf-8?B?bDNSdmE1STBzQzV0amhzUHB1ejgvRExtenorOFBlTEIzd2RZbU9uUnNXaXRv?=
 =?utf-8?B?YmJMYmNxZ3l2dXVDcE9HaVhGM1M2K2ZpZ01wSTNiL0NhaG1Pemo5RGEzcUh0?=
 =?utf-8?B?N3ZURWhSdEUrWnduejJESzJJZy84cklHbWF1UUxKb0llWjVCMU56UVhBdnhF?=
 =?utf-8?B?T1F3bGNFdFBEQlVleXV2OEF1VkNRdEF3V0kyMlhmOFpGZ2RHbUVEOFdIVFI4?=
 =?utf-8?B?d3FGOTUwNElGNWpNamhZSHpUZkhEeFlYUVNDMFBKS1FnOW1yQ3JQUitiSUh6?=
 =?utf-8?B?YXlBRTBrZUovKzQvOXR4dWpqb1gyUHo2d1ozb0ZDeGtIVTNtOHc3RHd3K3JO?=
 =?utf-8?B?aTdBU2RWWUI3VVZJSWF2a0ZtQVAzbGcxWjBGSnkyVzJ4UWNub0Y0N0tSeU4w?=
 =?utf-8?B?NXowVlVqVVRaMXZTRStCZ0NIYkROSnFOb1pwaDBBQjFIUFd6U0hzeVh2Vk1F?=
 =?utf-8?B?anB1KytEZHQ1bXVHNHdTYm54TkhqNXVVS0U4b2ExTjFveU9NSWxWNFVFUThB?=
 =?utf-8?B?azFVRkN4SHBGazdTN2dCVlRsRkdCZmFQbjdPUUNDekNqWmhXaXhBYkVVZW11?=
 =?utf-8?B?bUJpVlF3Y2Z6allwZkR0T0thNjYrbjdZUk9pNkh3MVRmR2tjTkhVSDZXNVV3?=
 =?utf-8?B?RWQzQlV4b1ZHQU9vZzRCS3dsaDdxY3JsenplSDc2bzVObDlzNW90a2g1SXVF?=
 =?utf-8?B?R3MxcEUyNmFjd2ttVGhGeThhWnduaEJZV2tuVWZ1S1JpRzNDK0dMUmxtYlAx?=
 =?utf-8?B?K2RRNjJ4RG9EdjgwK3BDa09qVmxweUZiNGlrZlROK2tRNHkrYXk0S2dwY0xB?=
 =?utf-8?B?ZFIzU05CQ1REZzhJb0twOVU3TTNuSWNSNTR3SmJIQXdhQjBDNVFuUFRiTGpl?=
 =?utf-8?B?aXFGdm5XODJ6VG0rM3RFbTJUQzFsNU14WmRuWERyZWZrang4Vk1hVnRaWWdu?=
 =?utf-8?B?TXVaUjliWEFKR0Y1TWwrdUl0NE9sbUN6ejl5eHRWWTlMOXIxNHMzaDhMZXBT?=
 =?utf-8?B?bmppcGVXS1d4R2FtRWl6U3h3ditXM1ZzMVdIV0cxMWFOVUJLWnNVWGFORUxj?=
 =?utf-8?B?WmRGODRDN2RTYjREYU1pVCsrZGNZUzRQb0xENlZBYmNMdmRFaE5QWGxhS2ZK?=
 =?utf-8?B?b3VxYmVCR0ZXeUt1eXBrdHJNcU1MMjg1K2pwTlU5MU9tU0RDOE5uNUZrT2Z1?=
 =?utf-8?B?R3kxN3F3T1RzckZaT2tNTVAxZU5wYldneHp4NGUveUw4ZjlwSGhReWo5c3Rh?=
 =?utf-8?B?czdzUVE4WGM0ZW5LY0cxbjByZVVhRks2SHlTK25HamxiMjQ3N1d2b1pGSXla?=
 =?utf-8?B?WS85c2U0UzE3eVpOQndJTCtjVnpoYUc4SmIzaFY0anZ2K2hvOSszVXpJckY0?=
 =?utf-8?B?WEtPVDlTZVJOMW9WVXlWb0E4dEFHVmdwdzAvc1ozN090QUZpZzRzckxwdHpH?=
 =?utf-8?B?R3MycDdpcnVkazR6UzExWW4wUVI3dGxtOTBESnR3cnVwTUNLcGlLQTBhTmcw?=
 =?utf-8?B?NXNwYi8wMmdMNXlZbkYxTEIxQU9mazMrUUpHSjAxbVJZdFlVV1ZyTGhEaHNF?=
 =?utf-8?B?V3pzS3o4L0hwSjdCVC9pcWsrVGpMYXF2UHFjbnVaQnpiYUxmSGlqaWdoMXA2?=
 =?utf-8?B?VEVhbXZnRUo5NnZyczQvU2lRam04MG1DZWxEa1lkZk9qeHlaSVo5aHZ0VGpN?=
 =?utf-8?Q?QsBD2zzcgTvo6OuI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2fb7eb6-7367-468d-6843-08da53c645d5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 20:40:26.8308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k0dRxAyhCvIMiYh8byb4YfVflfe0IodEf/YuUZ5NBs6LWBni/Bd/i7DHy1cWv++1U64xwjv3/XQ0kZwkaLDx3c6Vu/zBAQp8xbgt++EEZe4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3531
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/17/2022 9:00 AM, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping (after more than a year after I sent this patch :O):
> 
> Who can review and/or take this patch, please?

Hi Gustavo,

IIRC this could cause some issues with the expectations of the virtchnl 
structures [1] for compatibility. There was a direction that we were 
going to head to resolve this. Unfortunately, the person who, I believe, 
was going to make this change is out for a couple of weeks. I will ask 
around and see if I can get any updates on this work. Otherwise, I'll 
ask him when he returns.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/f2fe13346f1d44ee9047254a95914d00@intel.com/

> Thanks
> -- 
> Gustavo
> 
> On 5/26/21 01:04, Gustavo A. R. Silva wrote:
>> There is a regular need in the kernel to provide a way to declare 
>> having a
>> dynamically sized set of trailing elements in a structure. Kernel code
>> should always use “flexible array members”[1] for these cases. The older
>> style of one-element or zero-length arrays should no longer be used[2].
>>
>> Refactor the code according to the use of a flexible-array member in 
>> struct
>> virtchnl_iwarp_qvlist_info and iavf_qvlist_info instead of one-element 
>> array,
>> and use the flex_array_size() helper.
>>
>> [1] https://en.wikipedia.org/wiki/Flexible_array_member
>> [2] 
>> https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays 
>>
>>
>> Link: https://github.com/KSPP/linux/issues/79
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>