Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "damon @ lists . linux . dev" <damon@lists.linux.dev>,
        SeongJae Park <sj@kernel.org>,
        David Hildenbrand <david@redhat.com>
Subject: [PATCH v10 49/69] fork: use VMA iterator
Thread-Topic: [PATCH v10 49/69] fork: use VMA iterator
Thread-Index: AQHYhbATOefcF1kaekSasSOaZFoAjw==
Date:   Tue, 21 Jun 2022 20:47:08 +0000
Message-ID: <20220621204632.3370049-50-Liam.Howlett@oracle.com>
References: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kYjCSqfYC4FhrBMavY8Hla2aiba1B7HnGMwUKlSo2XH9EZXmAqxQOHhIas?=
 =?iso-8859-1?Q?XakPs7JCMBiSkqltlsIfavzPBGqb3ebrnJpAOOrBvdHsEaZW66OGH+at1a?=
 =?iso-8859-1?Q?i9WOe5JWOaWM5z9QOx8J4jlJUQiho1+3DzJ/hXBJpC5LMjk/QF7ub+Mtay?=
 =?iso-8859-1?Q?EDCLw2xnPXJB9ItWo+43Fh2YzKgq9Q6PAj4gVln7vCD+Xwepx1ybXn64zn?=
 =?iso-8859-1?Q?vCINur4pyLo5WY4QTx1nBe1ufy3hQZp7DFFDCe9UX3KAzFU5lXau2HKIPC?=
 =?iso-8859-1?Q?OkIEc/Dm2X+4p70iktYOJyJQBPO8FwP5Z5gdG8kFElxcWsiXRhQoIzwcnS?=
 =?iso-8859-1?Q?TqNvOBScdSOx5oPUMjjLE5p4IyX9lVwfQLWvvcBkG3NX51embgnqnLhrkZ?=
 =?iso-8859-1?Q?Wughd8h48fzXxpv+zYK3Y+7CrHNehoMXxheBDt2DeMZ2G9t2GFBORGNjB3?=
 =?iso-8859-1?Q?bOyJi+w3MfCt6L/nqDL+FKp9Dg38j36pHyanNvYzKekDrC73G7x/F5kppm?=
 =?iso-8859-1?Q?NpTlFsYInRINoV/f+k3hHwa57zGOJpjmlngJfmmbvebszf3SY1mtq6KNxe?=
 =?iso-8859-1?Q?REyoqZNve1RSXNnJ7CuzVjcEMUOtmRc0GyAHstd/OhtNJsJ9JQMTuL9PXV?=
 =?iso-8859-1?Q?Z2JDFZZunDK6ZLtnn7FV/P+DyHVCebCpSXOKKBOSnexmOphukSq+RBpwvb?=
 =?iso-8859-1?Q?I9Hhq/UwhocEG7C1MFSqYdi1yRDTHQ3cu1jz2HQCGFGXxzCql19w4PnKnl?=
 =?iso-8859-1?Q?J2kw5T9U9Plqjg2CgrnFpnCDhwTdvPjAK+bsr8dTuIqYcaVjw/ESS1zQMo?=
 =?iso-8859-1?Q?FXmq4aRlDqYRFjeUtqHP83fJsReaINIlbdz80MwGkNTqcL1tNvPGugZpC4?=
 =?iso-8859-1?Q?IDsyPbYtrjTkPqwLOwa3LuCrYETCV4tAg4qoznlMZZLOJVHQgYoC23bOzG?=
 =?iso-8859-1?Q?772lq1qTXLmpOeADGYdFxrz0TX4UgFoY1HH+eOBoQpAWg1NBkZWnZ/vMMO?=
 =?iso-8859-1?Q?/RvkQIfcXfqjvmYfrTBQjjiD6CssyqbZTfYjz+ODNQ5P6OHxcBezXFK1Gy?=
 =?iso-8859-1?Q?qc7oGC88+FVsW/yt+UGw8PjJLvGGdQYjCVPg6/z27TT3SO+D4zxQvOXcFE?=
 =?iso-8859-1?Q?tGQYl2L8jmGpgzD0n+wv56emZ6Ccwkft+DcKtsofe19Ccg09ef85IBu2VF?=
 =?iso-8859-1?Q?ICokLmtCrs2ipnvLNSETfvoO7M0UIezYaPrt6he0ZUgS3lMuGiH61Gz91f?=
 =?iso-8859-1?Q?/HZaW+TmEeDL4DbOqL8iuFpTF8pPVWksB3gSUqA0CKEyyLnfjqgWPicrQY?=
 =?iso-8859-1?Q?24dKUUg0xyobX5s3dKxioWOAqzfCnURSiZV6gw/YZAla4yWgS56UTRlwmG?=
 =?iso-8859-1?Q?zm+hIJYQJbSTfZImYeTBSVHzV6lW0aGq2cDZO9OHsxt3ocw51YWtPJ0FYF?=
 =?iso-8859-1?Q?mH3YE+maMhuaJ3CXS0yobW08DlvKnsFTjd7Ufnz6xvtGrWDm12i/WHt4sn?=
 =?iso-8859-1?Q?PRrdv2xtNxrG6+N/uC0NHurO0yrlvT2+m1RjRQV7AGBquRvjvOPa+Ds2zF?=
 =?iso-8859-1?Q?Cjl5JiIo4li9sM7W8WqQz1ZEdA4WQEqZB9Ee7sVo5Ltu5MGj9qpfpSRhi3?=
 =?iso-8859-1?Q?ZZLvxPLkbY84cOaJpypPOzuTHAdVBhpd7PyP5hH8Q/Qhxf9CI0cDRyt76G?=
 =?iso-8859-1?Q?ZKycra0MdJjZ+7QSVllwGYULM2iRCICf7RcS09dCY3H26zSioDKnnYCevl?=
 =?iso-8859-1?Q?shUDotgB6TijEDd92S95wy3S2NJumDz61dV1a6cWs/NppBrSFlCzSBcN28?=
 =?iso-8859-1?Q?WC6YhQZiC1l8/ZQ5fIGjbmRqYWka+6w=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 650d4f94-fa10-43dc-f636-08da53c74f7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 20:47:09.0034
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VieHLCpPRJuzG5p2QAEXgmrNgEUpSah8iRvxH72sMrVbq3FUaBMMdnZQ7BOWtv7LqkewAo03vH9coRSO1qUB/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5392
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_09:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 mlxlogscore=999 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206210087
X-Proofpoint-ORIG-GUID: GQtKQ-_DG7KKYF7e_M-coP8krLXI21gh
X-Proofpoint-GUID: GQtKQ-_DG7KKYF7e_M-coP8krLXI21gh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list and removing the linked
list will shrink the vm_area_struct.

Link: https://lkml.kernel.org/r/20220504011345.662299-34-Liam.Howlett@oracl=
e.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/fork.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index a653b259c321..7fcefef4c84d 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1294,13 +1294,16 @@ int replace_mm_exe_file(struct mm_struct *mm, struc=
t file *new_exe_file)
 	/* Forbid mm->exe_file change if old file still mapped. */
 	old_exe_file =3D get_mm_exe_file(mm);
 	if (old_exe_file) {
+		VMA_ITERATOR(vmi, mm, 0);
 		mmap_read_lock(mm);
-		for (vma =3D mm->mmap; vma && !ret; vma =3D vma->vm_next) {
+		for_each_vma(vmi, vma) {
 			if (!vma->vm_file)
 				continue;
 			if (path_equal(&vma->vm_file->f_path,
-				       &old_exe_file->f_path))
+				       &old_exe_file->f_path)) {
 				ret =3D -EBUSY;
+				break;
+			}
 		}
 		mmap_read_unlock(mm);
 		fput(old_exe_file);
--=20
2.35.1