Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "damon @ lists . linux . dev" <damon@lists.linux.dev>,
        SeongJae Park <sj@kernel.org>,
        David Hildenbrand <david@redhat.com>
Subject: [PATCH v10 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Topic: [PATCH v10 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Index: AQHYhbAM/jtODHr+AUirdm/bFOz3jQ==
Date:   Tue, 21 Jun 2022 20:46:57 +0000
Message-ID: <20220621204632.3370049-20-Liam.Howlett@oracle.com>
References: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DdU9Ses9JWV25SmN0LO2Ci2OitwTYcv+YzmOfxnEmpOcQbWfeJ3oQaoBd1?=
 =?iso-8859-1?Q?ydeloWmlDvjj5qPj63QVqSF9zUJAMBfz9gTlE8nuZsN+bTC6ffWlMxcqC2?=
 =?iso-8859-1?Q?IvqR/qsz3Qk22PrEdy9+L8NzbsWo293bJtcRviXOSwRRvB0I5z6WVjzq5o?=
 =?iso-8859-1?Q?qASRrc2/tcZR4+MCgGGCN7tssIqTIdcxFbh+xJ9/cxiJqjmBKD7cgnk0Fs?=
 =?iso-8859-1?Q?zLN9cCo/3iUY6dxHhms7aolbeZq7Wf+lCTmtfnzndnuPIZJLKUVMH91RcP?=
 =?iso-8859-1?Q?4KokYOH56oPh/La6p2472F2gtKUIPKuLUIrnq7MlJ6EkMMYHKu1aVEohG4?=
 =?iso-8859-1?Q?rJZqQoybspXZwrM/dXoBIgpJbN8eVWBekxuqwhWb5c/el67ykINvGXaLON?=
 =?iso-8859-1?Q?WZRtBSlIAXh1PlHQ7v4AGl81knM5z1zY5Gsa54P69aVpYo7tU4/CnpncGP?=
 =?iso-8859-1?Q?LWmqCpwNYmzCT9HzmAB5GpucYs7nqKTVXgL7S2IyaToqkQI0O1flDQFRYI?=
 =?iso-8859-1?Q?Tj2rycnw8uqYsTfjseoYnsTmbbv3LH5ePPDyJx1XWG9gKnwKydIjsnd56u?=
 =?iso-8859-1?Q?k55OYZZOr0qetkRnOspQVga3Y9jK9wVm93h0a5gNeUpFN2xw6F0ysecFli?=
 =?iso-8859-1?Q?O7MdYWoTYUJDv4uxRFqAahplXh2eV5mmcJy5E5ktEH9evAi/fZhuffQc9s?=
 =?iso-8859-1?Q?oSbNjE50da8FpeRkU0ggam7akWOuf1pJRzJUDKU/qsWWvZjyR0hs212EPl?=
 =?iso-8859-1?Q?8YpVGhY92soPRm1VPea1k+o4LVB0qeQmYzfRU5hTb6OuE/qs0UjuCwyjup?=
 =?iso-8859-1?Q?bEnsY1FVL+wGLQ78Ainxc1pvX0gQ+Sx48qbzo0ZXZtYw9UaLsjBS1/37/r?=
 =?iso-8859-1?Q?bxVjxbHXOlqeGmMEHvUg52D/wmJ9oUA1mMoA7oKyikd+OJu5cSXdShWX2U?=
 =?iso-8859-1?Q?NHCWRPY+pEVO3wSMG8Sy+suEZbPmzfH6gVEa/LFMAmUxPmkA8Vv2GOJ6cd?=
 =?iso-8859-1?Q?xwUagdk1plr0hynb+vg84Ycd9HIUFYQUXSBPkw2E5cp+r6lCoGFj4XRUFe?=
 =?iso-8859-1?Q?a7gOZE9m76LaC6JDdNDafWvvruLfDkAsyTtkINA4iuJZPMCI5+PkQjpYji?=
 =?iso-8859-1?Q?AmMRlTVjhhIC/AKadyMZRUfvlNLTe3SmSqwoTp0SY2ya/07vVcgvx4+WEp?=
 =?iso-8859-1?Q?2D5EpBnz+Mo9KWm6Cif4zauc4ZbQ+bx7rtmoRUwOcIFNLigjABl19Y9BVZ?=
 =?iso-8859-1?Q?gqWUxIYDqbXa4/r8YmFnJ6hxUxd5H3lkRs5oftfwF206ZaQOeXPrJAdjza?=
 =?iso-8859-1?Q?yxXB/VbfupNmXNRJZk5pYMdNOwDqdR0sh+IyA2ldXy3Acwbs0QWEi2BN6e?=
 =?iso-8859-1?Q?aIIfGJo1gfzr27opSBC9x+iPouGuwuAuLELdKdMLnNTgWF/0D2Li0oP6LF?=
 =?iso-8859-1?Q?AgKm1E5elBDVrBED+N72iidcFOjHZq/gxKHZDhHgMIJT7NWbc4dHgOZT7A?=
 =?iso-8859-1?Q?6Ns2FK6Tu31A7II+mnF4gVr/BU/X8BQcUYPywQocnui172lIVE0cn2uFYI?=
 =?iso-8859-1?Q?gTc/Y8RfuJcLwEpbyHXLCdjPMkBh0D8Y1orRRsbxpEcvhyplxcHFeGnlJf?=
 =?iso-8859-1?Q?ICLMQkPLsOtKt7NcVj0fCX3NEcuOpeOY5sRxges1/GER89RzXJ7rIvXtfL?=
 =?iso-8859-1?Q?NIH1jTgrFJpxn8fCyrS7TizKt2CBv27MbPAyQZLrtIkQchGQBUC039GkkC?=
 =?iso-8859-1?Q?pDR5Un67j31V5ffJSYoj1KqdGcy5ZvhYPr/MehNwxQ2amt/4LpCHfaxIhT?=
 =?iso-8859-1?Q?bnsJElKCrH5kFajGkMTczSHMymIyJSY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d733183d-89d8-4940-530e-08da53c733e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 20:46:57.5354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LARet9OZGsKeY1e7O8JctmMJgTj5vXvshPLR83jxHvH6qAejedzJCCnqmqAwvCQCXavqNwCFiG53TsOtCI5tSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3085
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_09:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206210087
X-Proofpoint-GUID: L3DjX3fhyDLLr0ACg-OBbEJhRMqJyKH8
X-Proofpoint-ORIG-GUID: L3DjX3fhyDLLr0ACg-OBbEJhRMqJyKH8
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

vma_lookup() walks the VMA tree for a specific value, find_vma() will
search the tree after walking to a specific value.  It is more efficient
to only walk to the requested value since privcmd_ioctl_mmap() will exit
the loop if vm_start !=3D msg->va.

Link: https://lkml.kernel.org/r/20220504011345.662299-4-Liam.Howlett@oracle=
.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 drivers/xen/privcmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 3369734108af..ad17166b0ef6 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -282,7 +282,7 @@ static long privcmd_ioctl_mmap(struct file *file, void =
__user *udata)
 						     struct page, lru);
 		struct privcmd_mmap_entry *msg =3D page_address(page);
=20
-		vma =3D find_vma(mm, msg->va);
+		vma =3D vma_lookup(mm, msg->va);
 		rc =3D -EINVAL;
=20
 		if (!vma || (msg->va !=3D vma->vm_start) || vma->vm_private_data)
--=20
2.35.1