Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 15:31:35 -0700
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
To:     Roberto Sassu <roberto.sassu@huawei.com>
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        kpsingh@kernel.org, john.fastabend@gmail.com,
        songliubraving@fb.com, kafai@fb.com, yhs@fb.com,
        dhowells@redhat.com, keyrings@vger.kernel.org, bpf@vger.kernel.org,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] selftests/bpf: Add test for
 bpf_verify_pkcs7_signature() helper
Message-ID: <20220621223135.puwe3m55yznaevm5@macbook-pro-3.dhcp.thefacebook.com>
References: <20220621163757.760304-1-roberto.sassu@huawei.com>
 <20220621163757.760304-6-roberto.sassu@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220621163757.760304-6-roberto.sassu@huawei.com>
Precedence: bulk

On Tue, Jun 21, 2022 at 06:37:57PM +0200, Roberto Sassu wrote:
> +	if (child_pid == 0) {
> +		snprintf(path, sizeof(path), "%s/signing_key.pem", tmp_dir);
> +
> +		return execlp("./sign-file", "./sign-file", "-d", "sha256",
> +			      path, path, data_template, NULL);

Did you miss my earlier reply requesting not to do this module_signature append
and use signature directly?