Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4283012iog; Tue, 21 Jun 2022 16:27:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tvQnzlPoiyljv3OfIqAE8YC2ZTR+t7Rb2jn7L4KpZeFObeAj2MY8AULk1EeuRunWq8KQVW X-Received: by 2002:a05:6402:18:b0:435:9a79:9a40 with SMTP id d24-20020a056402001800b004359a799a40mr666093edu.328.1655854036275; Tue, 21 Jun 2022 16:27:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655854036; cv=none; d=google.com; s=arc-20160816; b=PgTuQ2LWbpCOcCE3RwvPjaYHfMY/imMVb7AZSHHeejIZIj2bScrg++Ck+ODk1K6e8A Sz+IuXxJWy7S986CblUIjkFsRex34LGIO54Ezg50pTuUcgWw3zr6WQaAaFtROfAYNTAg +ibJQEGnmCFdj4feRwHGR3XQslNR2jJ5mIjskrPyvj+Wy9A1qyCOEfMf3KYroVia1GVx kWFb/irwpRpBh1gXq80aONdKG0fch3sPsDyMHm8VohgVAGp+jCT0bEWaT8FjiDUwe/ug uCX1awV66cbozUcKC8bRpfc595RbvteY82X/PzbWS7RS28mhoSs7VAOwOB7y7z7TSV41 kQ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ZTDRW4nF6Z0O67K/HQZFFDXY1lInr+MZTsUrmesWuUs=; b=PVL2iWH3QSGf8FI3Q2sWvHJ+q0kdnKON19jDa7zZhXpY2EdM6ZYIUm8tpV8afTCwfc MtkrI6yq8Dpm37qL87Bpx34G2D3I59oi5BhtV2fx+KwMKCUDXQUqN79zzla22qU3+FTM YzSL+8O1qVdWcrTZqihMILAhmPPIVAO2yNXSAZbRVXqP/ZwEofdvVYE38xCU6B1Iy7SX Z15ZSP14WLp0Nuhlaq0xjEI/JEOH6QxtqvRU0ZgT/5ZO6sEWDFsg7UhJ3m8qYCE7ZKJg 1z7Lck2Hvas74XjlUmHQceCfjWl9Mkd+nNhdZGkdlUsadB3806M5lzOPhwWm8gS8SAa8 5Ilw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd36-20020a1709076e2400b00715785bb696si17412885ejc.447.2022.06.21.16.26.45; Tue, 21 Jun 2022 16:27:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354727AbiFUWgv (ORCPT + 99 others); Tue, 21 Jun 2022 18:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354582AbiFUWgu (ORCPT ); Tue, 21 Jun 2022 18:36:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C616731DD9 for ; Tue, 21 Jun 2022 15:36:49 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3mUH-00072Y-BQ; Wed, 22 Jun 2022 00:36:45 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-ad3c-d4a3-b7b8-663d.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:ad3c:d4a3:b7b8:663d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D10FB9BC62; Tue, 21 Jun 2022 22:36:42 +0000 (UTC) Date: Wed, 22 Jun 2022 00:36:42 +0200 From: Marc Kleine-Budde To: Liang He Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: Remove extra of_node_get in grcan Message-ID: <20220621223642.zovfknmkl46d3lrs@pengutronix.de> References: <20220619070257.4067022-1-windhl@126.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7hp4pruqbs2u4bdq" Content-Disposition: inline In-Reply-To: <20220619070257.4067022-1-windhl@126.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7hp4pruqbs2u4bdq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19.06.2022 15:02:57, Liang He wrote: > In grcan_probe(), of_find_node_by_path() has increased the refcount. > There is no need to call of_node_get() again. >=20 > Fixes: 1e93ed26acf0 (can: grcan: grcan_probe(): fix broken system id chec= k for errata workaround needs) >=20 > Signed-off-by: Liang He Applied to linux-can/testing. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --7hp4pruqbs2u4bdq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKyR/cACgkQrX5LkNig 012j4QgAil42H+AKdjYOmRnYwjdDdSVagPnwXJ8o1Xy8K5dBH9r/qNWyLdcOKHhH 0M0D/R/uNtFDGhXFkWz5pH9K/04BPpwZN9s3Je6vHsWvj6vULUDcOyW4I+SzdZaE EMszknbppkNEJBg9C6OmapupzYMOq553CxYEIZPv7pXUAxe/ONDPZi7u8zstXFNp n1f7MV+PdKYZ+v35EJtWIAqYr5TezaEzzcrwJE8ZtbGXT7l7Yg44JN30y6052mbj fr33Lblwi/GT3y0SIdgmXoZnvNLYAq4CJVdpifUzA5tL+BeJRrRGkmtKYuNdAMZM 4HlThHfSdTNgSqjlUaXw42GTzOjPhQ== =u3Xx -----END PGP SIGNATURE----- --7hp4pruqbs2u4bdq--