Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 21 Jun 2022 16:41:49 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     sj@kernel.org, akpm@linux-foundation.org, songmuchun@bytedance.com,
        damon@lists.linux.dev, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old
Message-ID: <YrJXPT4dB39ylZtT@monkey>
References: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dqb6Q64IGM4jCw9/2vct5m27qsuvm+qOqwCW/ZgYQ2cLcGMTzAhhmZIeHfqu?=
 =?us-ascii?Q?9Yp/mX3uy9/lnFqnpkG6hyUYGBR/gjuInPiQzZp8yl+1uuKKeEE//4meMavL?=
 =?us-ascii?Q?RFP4G3Yv1Ryl9i37Pejg1x0VzRCykMk3Tbixe1+3SV8qXJtVsa4UEcetZ/Sr?=
 =?us-ascii?Q?KnPH2jYhw4sa3UIseTqUit+1UEKjIp2qM/wq0V1219HQhw9C++3xeIhStjhI?=
 =?us-ascii?Q?J60suePMPVKm1f2FUGGtTl9DzoCGwvT24y2HqcNdgIrz9DJ45WwTHVfWYR5+?=
 =?us-ascii?Q?XmLUYGUmGxbnK4MSRjb+pKLpNzEmnFwjLYQgXL/Yo8Cxb5qfpbs3xr09chtS?=
 =?us-ascii?Q?cr9cr9oEe4djpOhtML4r9Mbmp+nht5dMPC5icM7qJHeBYzyyWp/bmSqf7jiw?=
 =?us-ascii?Q?RwAx6sY7i5o3EUd6FNJE9efNx2GwKQzbO+R9oB4iLNZmf3PxJHyky4qYCqyO?=
 =?us-ascii?Q?EXJ5w7O6OcglNWu7BPbx1N0cnNkCiMcoAcJxs5tkWIfXW2k5EiTY+QChQrr7?=
 =?us-ascii?Q?y611pq07nW3i7xbTifBylUT0sjlLsOq/ZgUWfx5Tgb8SaNWpH8wJiZ4QGIew?=
 =?us-ascii?Q?AvxTAO8pLYYG6FMR5/sYyZ5q+784nrHTQHRQ/CbXy4lKJlJfZa/j5JMo3MDO?=
 =?us-ascii?Q?l97z5nFjn4EvrV+D2qxOFyHC1qtdkVTVccYEj8CpcRIflQA1z8gdkFNvOBw6?=
 =?us-ascii?Q?xQ+pggL8BPoS7vECzVeEaCHn7TLjeNse5QbmYICiMOQ07cLRWC30kbmcJoj9?=
 =?us-ascii?Q?6RKOyl7PDZKT3uwGmsfI44THpAM/Kaqk+2kLq2hpnz3oGxI4KxxAxqgT1DGQ?=
 =?us-ascii?Q?VCENXvviqNb1/5wTqTXjGobiRfnZGhDPS3MGmFGbDLyuDfY7pdUUPkGDnmUt?=
 =?us-ascii?Q?t4jXBY8AiW73Fr74td8cU9cXoW0N/Kp9fZnpyWP7lbJCcXvXIXg04JtiCO0w?=
 =?us-ascii?Q?ptYHCvx2QKOgkV9uLWkz+Tsy/aKGEEBefp5pclDJy1nSC4b+E/HybINGq8gM?=
 =?us-ascii?Q?t5jofW7fxJtO0LvK4AVD/0iIAxHUnTzICl/A5NPnrAr2LU21KzmQx8CgR9ig?=
 =?us-ascii?Q?KbpG7RVkKQJ7fBlJYqAsUu422tmHQHJHB4EMM7+T5P6a//056cryPqM2u1zC?=
 =?us-ascii?Q?c5FM71dHPyqatKKvphwz6YXJRs6b1Tx/5A1lXSSspd9y7CxwQ2OPCjjQ6c9w?=
 =?us-ascii?Q?yIrkKLQEH+QsCINH1HAYpN8kzzyqJOO9z6dFz31feVNDJAqoREY16CMNuHqP?=
 =?us-ascii?Q?+Lu1xnBaRVrSANdIfKGqk+c6lrXP9xVxJbi8ImCXBFDZM0zGnaF8JIqTkvPE?=
 =?us-ascii?Q?DGY9CtOOmrXlDl5H9SENkD7nDB0WPqeBtxofWrOKCHbRsbPdYsfRi9AVcb/l?=
 =?us-ascii?Q?r+sBCbr3sWDAu7366wyB39+aPs4rROzbCeCqlHprQgqLV3oX2FAtw5f77ssF?=
 =?us-ascii?Q?KMaQ5TG83rHxrA9F18xraPNE36fnGjkUVb/nx3n55rRhzbxWk+z3smnx+FpL?=
 =?us-ascii?Q?Ah7VvfAxseXlisXwJKyeC0ubc6CJwkshj9mb0VCLoRWYgE1X4gRf/+54pIj6?=
 =?us-ascii?Q?b95NF1cW1s2tR2wcgCXlXxW6FkruCisG7m8nK9EcSFKbyAA4OxC8O7xM43Ue?=
 =?us-ascii?Q?NI8xc1E872HXP340jtdZ8pHHtyaTmF5dfTucrBjNeefCEu/SxIEYPXzDNp6g?=
 =?us-ascii?Q?6vkP1QvvcNo6qix3VvBgaXbE9rhJSqWF11/ZfwISMavWwIx2gxL98UKzP3SG?=
 =?us-ascii?Q?ez7u9RS3tv916c6OE8Ws6eL+pXKsWag=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0454375a-a190-44d8-ad6c-08da53df9e61
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 23:41:52.9328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tn+xLZsyXnMbo3pa+W3tmPw/5desYOAoB4i2zRj5J02Zft3g0CLyZSdlSl030Zb0I1ZzR7Qnbvf+AiKqp/4XuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3816
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_10:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206210104
X-Proofpoint-GUID: kCIeRYIKdWTLxXEBfHFfPIsOAjNf0baL
X-Proofpoint-ORIG-GUID: kCIeRYIKdWTLxXEBfHFfPIsOAjNf0baL
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/20/22 10:34, Baolin Wang wrote:
> The huge_ptep_set_access_flags() can not make the huge pte old according
> to the discussion [1], that means we will always mornitor the young state
> of the hugetlb though we stopped accessing the hugetlb, as a result DAMON
> will get inaccurate accessing statistics.
> 
> So changing to use set_huge_pte_at() to make the huge pte old to fix this
> issue.
> 
> [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/
> 
> Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages")
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>

Thanks,

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

> ---
>  mm/damon/vaddr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index 5767be72c181..d24148a8149f 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -337,8 +337,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm,
>  	if (pte_young(entry)) {
>  		referenced = true;
>  		entry = pte_mkold(entry);
> -		huge_ptep_set_access_flags(vma, addr, pte, entry,
> -					   vma->vm_flags & VM_WRITE);
> +		set_huge_pte_at(mm, addr, pte, entry);
>  	}
>  
>  #ifdef CONFIG_MMU_NOTIFIER
> -- 
> 2.27.0
>