Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.garry@huawei.com>
Cc:     <axboe@kernel.dk>, <damien.lemoal@opensource.wdc.com>,
        <bvanassche@acm.org>, <hch@lst.de>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>, <hare@suse.de>, <satishkh@cisco.com>,
        <sebaddel@cisco.com>, <kartilak@cisco.com>,
        <linux-rdma@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
        <linux-nvme@lists.infradead.org>, <linux-s390@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>, <mpi3mr-linuxdrv.pdl@broadcom.com>,
        <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <nbd@other.debian.org>
Subject: Re: [PATCH 0/5] blk-mq: Add a flag for reserved requests series
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1a6a5ldwv.fsf@ca-mkp.ca.oracle.com>
References: <1655463320-241202-1-git-send-email-john.garry@huawei.com>
Date:   Tue, 21 Jun 2022 20:51:14 -0400
In-Reply-To: <1655463320-241202-1-git-send-email-john.garry@huawei.com> (John
        Garry's message of "Fri, 17 Jun 2022 18:55:15 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U6qnur5YVxaWMuHWlK3NJIY0s+g3M2HZBkMkWN/o/1rCnba6JN6i5KO2TiEp?=
 =?us-ascii?Q?jM8+XYUIQoBpMsV3g9t2lAgQAgjssP7Z6PhMjhx2zP/g3JNxKoFwK31zijkm?=
 =?us-ascii?Q?8vbel8RQmNpkfnKRpZqQEjknePAkWOkOyAVFa38M+gtewvTH0kUAS7W/Z74G?=
 =?us-ascii?Q?KftK31Wo7ofiTNW+24XZhKZSi5wtM/xw9Cb6L7fh8+pAn+Nxp+qIeAYkFhCh?=
 =?us-ascii?Q?fk1G+moAyTMV4f9XGkDCKby1xt+TUpvfUBfIZJ/CA8eG5MucFF0Ev9TH4pG9?=
 =?us-ascii?Q?XSdfALj0rpfPNyh71R9L/V5UKAQD22fgvvgbOfoH7EYZUnWbk7lK3v47c0bm?=
 =?us-ascii?Q?s97o0aqW1xCuwXi6edMxUdLmd+K7+O59Z1nob/wbhDWbqAZiAqhrnl/OI7RK?=
 =?us-ascii?Q?wXBMaWrPzmKuqDsNdOY1YWuPe4PjeJA/l1ZioiT8GJ7lMHgNp8jcUddJGBBS?=
 =?us-ascii?Q?uBAu413Vaxu3j5QsEAog7m7eF86G8rKfWlrrRrIcWVWdPX8fzOdxVWyPAJef?=
 =?us-ascii?Q?2vd7teG5I9IuksBPEbM5VpPOZNYk6mnfgkpVV4uoXHGw28EDnLnNRVS0Km19?=
 =?us-ascii?Q?Mz8pqtV/aZiRE64AHQ8xsXh5acIQPjlZvjXDuEjMt5zgOzzl5L2WsFCS32r9?=
 =?us-ascii?Q?gebwlKDVCMI2YUGCvLRX/mm7kRpQK+ocgxXz8aEACbRoMRFLRQwNhi8q0aDj?=
 =?us-ascii?Q?d1o/YBtzlvmG/MeiaJiTneieMKGQqpnRuBl9vKqpfYfHPvM5p0okpDtTNe3R?=
 =?us-ascii?Q?kGMGxNWR3I4wCpEcHld723JC99DQyuBU3BtOUj6fHQXuRBNrZ6vjl4Hn2sE1?=
 =?us-ascii?Q?wghC0YBSwlp+K7Zy4bjY0CfiakXudS2ksQa12VtuJgrtdkaQ/afyR11mHWIT?=
 =?us-ascii?Q?O4+7MXRtSgq+QsCa23KO7cxqoFrpvNIKL3Gvk69tnwDkpTMYtJqbHw9R5HkA?=
 =?us-ascii?Q?sN5DduGuDxgWwGKNycMRA3kk/DhvdAWc6pMwsQfvCn+f1mozri7PThd7Fixf?=
 =?us-ascii?Q?bEK0rtvD3myd3Yc7rZcvL448TyCmczT2wgPa04Q0MUT9RH2Un4W3S6P3Udan?=
 =?us-ascii?Q?SYKizv7Fo1kjyNl6ltd9QSYpx6EQkbJY5QYfKroNND5LfUPVESGDpGQ+p0oN?=
 =?us-ascii?Q?0Kx0V5liJgU7Bp11ysN7b7rOgkl/qV9hDyKT94Gv4ePRrAFpHuxYCUZiryhT?=
 =?us-ascii?Q?aBHyEOkfCIY0HYkbXC9sNbFMlPtDFp27hexuFv47wCMhBHv1tCQbjTMOaChx?=
 =?us-ascii?Q?iOf6ItfxtE1CstfOrT8Io9k5grs3iWRRlk/EivuHl4CTHSGB3KL/Qogcn5gw?=
 =?us-ascii?Q?SmCyVhNsM4iAaS/Scgpr/XqdzcZBDJmp2EWhg83BtLtuRENyZyDnX5beO/QC?=
 =?us-ascii?Q?Gf+VT7uvYZ0WFzIRHO9FInSsU+4dFljBXve7SDhtLPLlCrerd8HbA/DbxL13?=
 =?us-ascii?Q?jj8e5H+Q01A6/iHmcT8W88cdjjkrGJNBYW0Ghf7B8yiPPF3//EAfOUlBZcMp?=
 =?us-ascii?Q?NzJ12R+kLKSLvWCxkF/erbzOKQtvS2KrzhsB+7hFTe4VmccxfvVBajtcbSe+?=
 =?us-ascii?Q?SFZQNgLHvZEtkeTk6R7shkLd78zt8hZCa76RU3gG5o5QpsYjQAm3OsD3OHlH?=
 =?us-ascii?Q?BvXq0g8M4nI0qWcTPQk4h8x95phSYbRZkhjT+oWa1XXJnT98Z0l7GxdZY6YJ?=
 =?us-ascii?Q?BN6CBs469iRfqc6WCUI48b86jMwyUhuDLCU+KOIdoAOuVMO1ZxO4kItQH6MN?=
 =?us-ascii?Q?3a4n2fAOIKnXL0Tw2Y/Jy1oLGtSp1Do=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccd81afb-e7e2-458b-e182-08da53e951a0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 00:51:19.3808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3K/HocetBr8vi+1KJEEJ+WCmWyk4Wig5s+rxKFaIW6fkFQBXAZIV8/9I5elinaIM6lRB+EiRJRXaUYA3b8kWVKJldXHhLLRwgGnCJNUTOYI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2524
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_11:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206220002
X-Proofpoint-ORIG-GUID: bR3p0jWuL-gn5MXk1Gs_YO1mnUykqaAn
X-Proofpoint-GUID: bR3p0jWuL-gn5MXk1Gs_YO1mnUykqaAn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> In [0] I included "blk-mq: Add a flag for reserved requests" to
> identify if a request is 'reserved' for special handling. Doing this
> is easier than passing a 'reserved' arg to the blk_mq_ops
> callbacks. Indeed, only 1x timeout implementation or blk-mq iter
> function actually uses the 'reserved' arg (or 3x if you count SCSI
> core and FNIC SCSI driver). So this series drops the 'reserved' arg
> for these timeout and iter functions.  Christoph suggested that I try
> to upstream now.

Looks OK to me. I agree with the scsi_timeout() suggestion.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering