Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 03:04:40 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Oscar Salvador <osalvador@suse.de>
Subject: Re: linux-next: build failures after merge of the mm tree
Message-ID: <YrJ4uPNlIk1QifAL@casper.infradead.org>
References: <20220620164246.0d3f7784@canb.auug.org.au>
 <CAMZfGtWmGOr1LRBnKGVeqP8p47xyaA0ny_rotdHmgLx8DOk6xg@mail.gmail.com>
 <YrB7Vq/WlGK99fxz@casper.infradead.org>
 <20220621152845.16c801b4efd747173dc08559@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220621152845.16c801b4efd747173dc08559@linux-foundation.org>
Precedence: bulk

On Tue, Jun 21, 2022 at 03:28:45PM -0700, Andrew Morton wrote:
> On Mon, 20 Jun 2022 14:51:18 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> 
> > On Mon, Jun 20, 2022 at 03:11:31PM +0800, Muchun Song wrote:
> > > Thanks for your report. It is fixed in thread [1].
> > > 
> > > https://lore.kernel.org/all/20220619133851.68184-3-songmuchun@bytedance.com/ [1]
> > 
> > No, it's a different problem.  I suggest dropping/reverting
> > 
> > https://lore.kernel.org/linux-mm/20220617175020.717127-20-willy@infradead.org/
> 
> Dropping that creates awkwardness.  How about just uninlining it?

Sure!  We can also make compound_page_dtors static and drop the
declaration in linux/mm.h if we do that.  I think there's a pile of
cleanup to be done around freeing pages/folios, partly from accretions
over the decades, and partly from the existence of folios between order
0 and 9.  Not to mention Mel's recent addition of high-order PCP caching.

But I don't want to do that for this merge window.