Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Raj, Ashok" <ashok.raj@intel.com>
CC:     "Qiang, Chenyi" <chenyi.qiang@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2 1/1] iommu/vt-d: Fix RID2PASID setup failure
Thread-Topic: [PATCH v2 1/1] iommu/vt-d: Fix RID2PASID setup failure
Thread-Index: AQHYhfLuXUM1xHXjNk+lf4Dn9CxC1a1a5TUQ
Date:   Wed, 22 Jun 2022 05:26:23 +0000
Message-ID: <BN9PR11MB52769E1D6C180FA0BBF820128CB29@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220622044120.21813-1-baolu.lu@linux.intel.com>
In-Reply-To: <20220622044120.21813-1-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?01MF1DX4zhq3gtVNmmTM4Tv4EQ/pMDwI9u4dIaEG7Hy/SGLl8f0dU9YQ9D/f?=
 =?us-ascii?Q?CKYz9+pbHaVrf34mj/tAyI4savNTadqsVBaqdQGtSyvIrl34KH/Calb0Mht2?=
 =?us-ascii?Q?4AIwS946K3palANeIAjqZkDsb2Zit+9QTuJFOYKGYVC9XX3sOfEe3ZyAVVoh?=
 =?us-ascii?Q?iE1j6tmGWT95MGuQEW8KfmYxfGui0KmwtyFpUFlmukLwTAF9nV1opUJLfn5D?=
 =?us-ascii?Q?w6iXBlFyxqHc9MdBS4h4sN2W3op6z/t2PMtaAzOG0uBvJu+tG5rjlqoKUd2q?=
 =?us-ascii?Q?z9o21xoXkNBXAUYpmPb2f9oQxnUOtdu9fygdn/TICbNHSv4LwOyTITCtCGoO?=
 =?us-ascii?Q?9WeWBfE/ZocVM9S7yRe+IA11hFoYZnhWn2ILN623BKm1wF0iYojRMDqpoFGi?=
 =?us-ascii?Q?OYxXfxxwKkPrFfJBERQF1IXJLih/53sYW5nRU6Z0Wi1lykbvTYiAjjSlg3+Q?=
 =?us-ascii?Q?DDpMTPadR2PrSwYuaUG90f7ZN3uvFRiCHHTQkBzQQRKgXT5I7GdownoFKxbm?=
 =?us-ascii?Q?ZxiZ+X+Ah/E8BgzhaKBtneUiC++zHaaFfezcsQ3wBIb9YjsV9Jdeazm5Q6Ht?=
 =?us-ascii?Q?WBHp9nwgzsliJ7p7SgWWcB3Wyx693NyQlr3Athsp/+0XW9v3UGN7dkxUmZNc?=
 =?us-ascii?Q?hEPLtqv+lwFp5wmJ+7RoVx/gt/q8W+II1B+Z3YgOtK3XwgZHqfemh/3GdntT?=
 =?us-ascii?Q?9ja2tTiFD7J6Deqe7nca4mmg+5tKc0Ed0ljXNoUNiP6YRLY507Kf3vnMulj/?=
 =?us-ascii?Q?+vxiyc8ucXK8/E40Pda4RmMTZhyqqFvNz9hAwXITU/VWLVkHKBD5iySom907?=
 =?us-ascii?Q?hIPZO1Bk9a/KbxZcea4p4lp56LETZC01wCfwJLMDDyT5rxfyXRrs/c6YAsT7?=
 =?us-ascii?Q?a9KsNIyG0nCdqieNaKBCnXcMtF0hHpD/tna8U0NJcco+hF2GYE0phG3YI39B?=
 =?us-ascii?Q?IR4u48yUmN/hjffyh+kB9sfZa8quRZPFV5L0sv1SW1biiCvqWZdSIRi15WUD?=
 =?us-ascii?Q?wvv3+fBsnXgzp+LUBna2E1EbJYhpIMmEIzjOvcyYS8Wtx7XLWDFZlhgBlLWF?=
 =?us-ascii?Q?5ElAphOgKE9NRMgAR8bzKFfO4czSH3cNQypc1NvHGvO8bZFHgbrQQezsPwxc?=
 =?us-ascii?Q?TdFc0Y3rtKOY61Cc0CNERjGvRRE8ZatxjnnG+31JZaV1FYWza0XrRcklb87e?=
 =?us-ascii?Q?Oq0jk0pvlGOR2oJiS0puYKYoakCDBmIzGs2Cm8ADuueAMAQJVqJeIRe4rnLa?=
 =?us-ascii?Q?5MYNrIIF7mNNsdeuOPv7QH2oADxCuyzfFPF/WSaa790SBNKaYBznWcKKzmmJ?=
 =?us-ascii?Q?4k0FOiIYDmjZFPLmvi4SwldSPiZRndBQSifDQbVhaZXZju1M2OT27Bu9qZiP?=
 =?us-ascii?Q?4c04J5spb87IDvopoVaoVmwmlOLY4gn3kzFmN9nHLjtVl/pDtwq/pCuWrF0T?=
 =?us-ascii?Q?LXhAyz04tFyiWO9wK5kDHGqZ38nO5AqCVgp3kOXEQ6bYSupSY+mCh8zmjtbs?=
 =?us-ascii?Q?6vCkbtqMWdyN7tkWzBn4t2mDMWOgAGO3cbT9+KJA9JiqalzlUxNAOgt19YZt?=
 =?us-ascii?Q?8ZQXeuG/g8cbMgbvnrgts2dQaa+QT5KpY3am0+af8RSiYP2zKf4E/j1BvIIc?=
 =?us-ascii?Q?T9oag0stx4VijQ9fOFLOMEpADidIhVsBIwzJii6UjatQomn/eWmDA8rxH7Cg?=
 =?us-ascii?Q?0lRX2rCZWbyQp2GTbfpIk2Oz+JzTAbqZFCgR7PhM8N5dOS3fN+crJLA3YN4b?=
 =?us-ascii?Q?QJP/5jxnPA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd0bd8f-7313-4a4f-6f19-08da540fbf53
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 05:26:23.7348
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cFHC9mkviygOhTLLXucit6/4jpSYBCuoHHcGSywGx0kFjEfUXQCjMuMP9NCc+A90HjpAsvDS8q4tx9ruV5pOGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6535
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Wednesday, June 22, 2022 12:41 PM
>=20
> The IOMMU driver shares the pasid table for PCI alias devices. When the
> RID2PASID entry of the shared pasid table has been filled by the first
> device, the subsequent devices will encounter the "DMAR: Setup RID2PASID
> failed" failure as the pasid entry has already been marked as present. As
> the result, the IOMMU probing process will be aborted.
>=20
> This fixes it by skipping RID2PASID setting if the pasid entry has been
> populated. This works because the IOMMU core ensures that only the same
> IOMMU domain can be attached to all PCI alias devices at the same time.
> Therefore the subsequent devices just try to setup the RID2PASID entry
> with the same domain, which is negligible. This also adds domain validity
> checks for more confidence anyway.
>=20
> Fixes: ef848b7e5a6a0 ("iommu/vt-d: Setup pasid entry for RID2PASID
> support")
> Reported-by: Chenyi Qiang <chenyi.qiang@intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>