Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42f2ba58-acd9-a214-83f2-037f669d8d59@prevas.dk>
Date:   Wed, 22 Jun 2022 08:31:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 00/14] arm64: dts: imx8mp: correct pad settings
Content-Language: en-US
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de
Cc:     festevam@gmail.com, linux-imx@nxp.com, hvilleneuve@dimonoff.com,
        l.stach@pengutronix.de, abbaraju.manojsai@amarulasolutions.com,
        jagan@amarulasolutions.com, matteo.lisi@engicam.com,
        tharvey@gateworks.com, t.remmet@phytec.de,
        u.kleine-koenig@pengutronix.de, t.remmet@phytec.deh,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
References: <20220622061410.853301-1-peng.fan@oss.nxp.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <20220622061410.853301-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WCtlZ1FuSHc4bG1sN1RGMzV6Z1Fmdmw4bnVhVmd5M1hwTDFsUEJ2SFlEWWoy?=
 =?utf-8?B?ZXZpY2loMUQybWFyWDNlVG9sdTJKZDltMW9pblZNR3pib1c3eUJFU2p2QjF6?=
 =?utf-8?B?c0Qvd3V3dDZJN2cvR3c5UTA1QzlnTnVrdWF0UjRLSGZacitRRldmenZaU3Bm?=
 =?utf-8?B?dDh5VFlLR0RNM2xrSGdwa2syUkxhU0F6WkZwYlNFcUZTV2hFQTEvYVEyZHZR?=
 =?utf-8?B?ZFBuVnREQStoWElTVXlSSytNNmRhM3F1eVJ0RzVDWmpUM0tzRndkTXhxQTJI?=
 =?utf-8?B?YjhYSDB0a2NVT0VMM3g5QURLRWo4b0ZpeWpWL0ZLK2d5ajZldTlSc3ZHblBL?=
 =?utf-8?B?eDZvNjRTUU5ucENkNWdkelQ2NXV0SGo0ajlzOENuNGxNM0dlNWF4OTlOMlI3?=
 =?utf-8?B?eThGcEpqdm9QdFVUS0pTZW1ocmdRQzFsd09mcE1iYmo0MitqRU5QSHp6bVpi?=
 =?utf-8?B?Q0F6SHpuK2taVlhFMjl0ZmNTcjVMdUhhR1ppWUZ2OXlSTTZrb3h3dStjc0hR?=
 =?utf-8?B?TDkzNW5EUmZCN01ibHZVR1hIcllCSy9VMzkxOGl5SEZuV2Y2V3BVdDZrcFRq?=
 =?utf-8?B?NWRKV205eGJGU3ltN2Yxc1dBZ3orUkd0N3FVTEFqT2VVRVV0TlExNUdkakl5?=
 =?utf-8?B?KzVPYkc3NGprSEpvOXNDckZlWEp1eG02NkZhVjdmc0pRUElSUFhHbk9Pekc0?=
 =?utf-8?B?SDNZeDc0TFdRbk5haFpicHFSNEg5SWV5cFQvdW9ySktNeVpmVVNIUXZRWmVv?=
 =?utf-8?B?V0swd1NxMlY5TUNVV1ZSaEJxYkh5cC9MWEg5SUlMN2Y0bEdLdlBuSkJiVFNp?=
 =?utf-8?B?cFd4WUZaZXlIcEM2S2JTNTNkbGprS0dhK3BKcG5XYUNnSk9EVy9vdFkxekJV?=
 =?utf-8?B?cVJBaHdxT0Fzb3hNc2h0cmZCUXV0d1d3MFBNV09mM1ZhdTEvZ1d1WVF0UG14?=
 =?utf-8?B?c0Y1T0plOWdBNDdhdzNWeisxcWQ0eGJhM1lPdzhYVTBsTGlDcUZsbmdlajB4?=
 =?utf-8?B?L3VZWEZDbjJmN20rQ21wcG9zT0xWeUduUGgrUnltM2JaeUhVQU5zeFZMWEow?=
 =?utf-8?B?bVZnN0NkN0hkREZGRUpKbGtPc0VmcXhOUGFUalNKaGZYMXkrcmtwNUNLdmUr?=
 =?utf-8?B?OFlXZTUvdWg2UjZXdkl0ZjN3QStpQ2JaS2I4bXNNRmhVc0lTOHBXR2Z1aEhT?=
 =?utf-8?B?US92S3E2YXd4Rmg5ekVSUnQ5RTVkdHpQb2FQdWV0T1FOazkxSnVXUTQvSnIy?=
 =?utf-8?B?eTNid1V2Wm5MeDNKNjlESUxOU3pIMFlVMU00YitWYzhpejlsN081YTdodWow?=
 =?utf-8?B?cWxtTXZBczBiVnBGdDdsNmhIanV6K1hzY2VsUFNlQTlaQWFlSHFPQUxvRVdv?=
 =?utf-8?B?WFl0eDc5WXQxOHVJN0dpbjgzODErMkpwM3pCeStoQWkwNW41d01KQlN6R2tX?=
 =?utf-8?B?SFhCTUJ6WCsxRldrRlZSQUs0aE5ZM1dIWUhNdHpiSmtTcHVGUk9aWEYrbERN?=
 =?utf-8?B?ZmRrcTlIWFhXWHhGbXE1cEtpSUwwNC9FMGR4eTdyYjQzdk1PN2JtYnVQWHY3?=
 =?utf-8?B?ZDkrRDZ2RmgvdW04VGQ5eDEzeE5uQllNTUswM1ZSNEZIaTdlVVMvdWViZ1lU?=
 =?utf-8?B?M0NhNHF4V2duNjF6Vkh2blJrR0c3VzhUNE1PVmNxd1g3S2JncDRoR0RyZTYz?=
 =?utf-8?B?QTVHTzd4NThLZ3BQZ3E5L0JENVhheW9acEhLRzBtYnNNRUN0M1hZWXBwVVFv?=
 =?utf-8?B?R0RhTytKMXNxODVnSTBSWlI4aTJpeVV4d1hsMHVZN29ibFpqY2poTVJiUm5S?=
 =?utf-8?B?SEtjUjNjUEpNWXo5Vi9Ub3V2YjAyelRPbm5DWUxpRW13c0ZEQ3dRUW9yaUIr?=
 =?utf-8?B?U2dhSEMyQ05YRzFZeDlHckdkTlFYRERZcHhCcHIzR1gySStPZmVxdnZnZ0I4?=
 =?utf-8?B?NFlibTU0S2JxdVMrNytLZ3d0clBBRjJVSjZ6M0ZqRWZmSmlsVDROZkhMZTdV?=
 =?utf-8?B?RXBPM3JwT2pSWWNjOEJ6b0Jnc0xlVlVOYWpKVkU4VWR1UHRDS25hRHRFWVBD?=
 =?utf-8?B?RlpiU2xXck1YRGo0RUwwMmtPbkp4NWhnV3NIM0ZJWkM1UVY2c3FNMDB3a1ZM?=
 =?utf-8?B?bTRkLzdrQ055dEE4cUxrbWZMbmZvT0lnUjh0U0dScVZRV1FMMXc2UktwRkp0?=
 =?utf-8?B?NkJlR1dSb3RpNVY0bTZyYWFoUGtxd3JzQnI5dDkyZ0grQVFXZHM0ZU0yN2Vs?=
 =?utf-8?B?QVZ5ekJxem8rdzZIWE8ydHFWZ2MwUENoa1FoamZaYVZkamt4djAxL2JsZmhi?=
 =?utf-8?B?aTVXVVEwQTNQQWdGZzRkQmZkMzM5d09saGpLZXM2Nlo4bzFwVjk2cDNQUnV5?=
 =?utf-8?Q?4ivTDXg8MKXMAeUU=3D?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 71edf7a5-d22e-4381-6617-08da5418e44f
X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 06:31:51.4411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uj7z9vLgI6SsYh+sa+2lZTPKrJ8f2W3+d4GU/OD87PPFZDsHisqzNDPNIJYj1KsD224A/w2cGbx0UIEIeeYiJs1LPZrDDirTwvLh+HJqxQg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR10MB1627
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/06/2022 08.13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MP iomux pad BIT3 and BIT0 are reserved bits. Writing 1 to the
> reserved bit will be ignored and reading will still return 0. Although
> function not broken with reserved bits set, we should not set reserved
> bits.

Thank you, these have really been bugging my while trying to bring up an
imx8mp-based board and adding the right pinmux settings - not knowing
whether there was some undocumented effect from including one of those
bits has led me astray more than once.

One question: E.g. in patch 11, you change the setting from 0x49 to
0x40, which is of course exactly what the patch description says. But
when bit 8 (PE) is not set, is there any effect from either setting of
bit 6 (PUE)? Not that I suggest changing to 0x00, but I'm just curious.

For the series:

Reviewed-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>