Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 08:56:09 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Yonglin Tan <yonglin.tan@outlook.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] USB: serial: option: add Quectel EM05-G modem
Message-ID: <YrK9CcvsQpz2Qaz9@hovoldconsulting.com>
References: <MEYP282MB23748DE15DA9B962E7A2E7A7FDB39@MEYP282MB2374.AUSP282.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MEYP282MB23748DE15DA9B962E7A2E7A7FDB39@MEYP282MB2374.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk

On Tue, Jun 21, 2022 at 08:37:53PM +0800, Yonglin Tan wrote:
> The EM05-G modem has 2 USB configurations that are configurable via the AT
> command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with
> the following interfaces, respectively:
> 
> "RMNET"	: AT + DIAG + NMEA + Modem + QMI
> "MBIM"	: MBIM + AT + DIAG + NMEA + Modem
> 
> The detailed description of the USB configuration for each mode as follows:

> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> ---
> V2:
>   1. Add the description of the usb interface configurations.
>   2. Add QMI Interface description.
> 
> V3:
>   1. Move the entry to where the other Quectel entries with numerical PIDs are.
>   2. Define the macro and remove the comment.
> V4:
>   1. Remove a blank space at the end of the new entry.
>   2. Change the permission bit of the source file.

Now applied, thanks.

Johan