Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4556413iog; Wed, 22 Jun 2022 00:49:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sQYUuCkKV0Y7SdX1gYrys96ml4FN9f05hIT0IHIJQvZskBOO+FIMr7z0zTe1olYnufeavo X-Received: by 2002:a17:90b:3849:b0:1e8:7f47:5dcd with SMTP id nl9-20020a17090b384900b001e87f475dcdmr47914847pjb.61.1655884198374; Wed, 22 Jun 2022 00:49:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655884198; cv=none; d=google.com; s=arc-20160816; b=A2NLwCjGmoCgbKrLsH7DqvBoAk1bm8ALj4RswZcIlaFe8Z38ysgq2C07EWyX/qzSeT Bwg/v7iFJTtHz8BTtw9873+UhYlSnbNeBVdIzsrubb8ylAnPud3YjnMtwC2e2IeTUTf2 ShBKoxDLsIGG2rWuLTFM10K25vu6IJnNdeumQrzq4DwRBZ0HpQ7x4iMloQE54hBNdR5U RyvbZDe9yyQNGOLpozX9r2MS88oiNc91sKe+U2IcdwIgafn7j6CEncnePw+Kjnz/Y9Kx 8ra2Dz/x2UPnAuTMOxbd+aXClYgXYVBlYN2DKsUPsTd5Gs3IgYTPjM+0PTAZhjGdr/P3 r4yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=vCFskEDXxGLafelUfJuN2H8kyMSCY3jQDRawFymduC8=; b=NaBg6niSzh3cH+5NXsWUsn7wBF3ETX87yTT74NRYxecDawGR3cVl3slKhqy4F2p1lt j/A7TIKiQrIz1vWfg3HZW5B3M2+7YcnM6u84CojMFCM69hZmA2OA29Apz5o8fbq/uabp y/7D4gGMjLe3L53SUAuqEJIm6+uLqtTtaoh33xucfC13yJ1dXVsB9nVZFAJ6/cABN6ix poiYmzYPxmDSQnbbOzUhqOopFUljkyfH+eCYy2/8ZmyHbzN6Y8HhHYqUYaDknFh21KS8 Nrz83EHSTk4ftplKlWorf3K7iDGCWM6y3qVK1SGfkfgTNQz7VpbsG1Z+y2kECe+B/t8g x6Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p7-20020a170902ebc700b0016a04a664fasi18631312plg.8.2022.06.22.00.49.46; Wed, 22 Jun 2022 00:49:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353445AbiFVHhj (ORCPT + 99 others); Wed, 22 Jun 2022 03:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353166AbiFVHhc (ORCPT ); Wed, 22 Jun 2022 03:37:32 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5252F377D3; Wed, 22 Jun 2022 00:37:27 -0700 (PDT) X-UUID: a744a705032a49c7ad80031a6e2a6683-20220622 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:b1a38cf2-e852-4794-95e1-074d5679e8cd,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,RULE:Release_Ham,ACT ION:release,TS:95 X-CID-INFO: VERSION:1.1.6,REQID:b1a38cf2-e852-4794-95e1-074d5679e8cd,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,RULE:Spam_GS981B3D,ACT ION:quarantine,TS:95 X-CID-META: VersionHash:b14ad71,CLOUDID:dc272738-5e4b-44d7-80b2-bb618cb09d29,C OID:d1d2169eb362,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: a744a705032a49c7ad80031a6e2a6683-20220622 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 82527024; Wed, 22 Jun 2022 15:37:22 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 22 Jun 2022 15:37:21 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 22 Jun 2022 15:37:21 +0800 From: Stanley Chu To: , , , , , , CC: , , , , , , , , , , , , Subject: [PATCH v1 5/7] scsi: ufs-mediatek: Disable reset confirm feature by UniPro Date: Wed, 22 Jun 2022 15:37:17 +0800 Message-ID: <20220622073719.21599-6-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220622073719.21599-1-stanley.chu@mediatek.com> References: <20220622073719.21599-1-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Po-Wen Kao In MediaTek UFS platforms, UniPro will not return reset confirm if it is in POWERDOWN state thus hang issue may happen while disabling UFSHCI. Simply disable this feature before UniPro leaves POWERDOWN state. Reviewed-by: Stanley Chu Signed-off-by: Po-Wen Kao Signed-off-by: Stanley Chu --- drivers/ufs/host/ufs-mediatek.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 8184e871ff8e..348966dbad78 100755 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1079,6 +1079,11 @@ static int ufs_mtk_link_set_lpm(struct ufs_hba *hba) { int err; + /* Disable reset confirm feature by UniPro */ + ufshcd_writel(hba, + (ufshcd_readl(hba, REG_UFS_XOUFS_CTRL) & ~0x100), + REG_UFS_XOUFS_CTRL); + err = ufs_mtk_unipro_set_lpm(hba, true); if (err) { /* Resume UniPro state for following error recovery */ -- 2.18.0