Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 09:03:26 +0100
Message-ID: <87mte52khd.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Liang He <windhl@126.com>
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org,
        Miaoqian Lin <linmq006@gmail.com>
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
In-Reply-To: <20220622062138.4095598-1-windhl@126.com>
References: <20220622062138.4095598-1-windhl@126.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

+ Miaoqian Lin

On Wed, 22 Jun 2022 07:21:38 +0100,
Liang He <windhl@126.com> wrote:
> 
> We need to add missing of_node_get() for of_find_matching_node() to
> keep refcount balance.
> 
> Note: of_find_matching_node() will decrease the refcount of its first
> arg.
> 
> Signed-off-by: Liang He <windhl@126.com>

[...]

Please send these refcount fixes as a series for all the irqchip
drivers, not one every other day.

And please synchronise with Miaoqian Lin, as you are obviously both
chasing the same bugs.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.