Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <298dd904-586a-d09f-2e14-0e0fc45385fa@linux.intel.com>
Date:   Wed, 22 Jun 2022 10:40:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v7 07/14] ALSA: hda: cs35l41: Support multiple load paths
 for firmware
Content-Language: en-US
To:     Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Cc:     patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        Stefan Binding <sbinding@opensource.cirrus.com>
References: <20220622074653.179078-1-vitalyr@opensource.cirrus.com>
 <20220622074653.179078-8-vitalyr@opensource.cirrus.com>
From:   =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <20220622074653.179078-8-vitalyr@opensource.cirrus.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/22/2022 9:46 AM, Vitaly Rodionov wrote:
> From: Stefan Binding <sbinding@opensource.cirrus.com>
> 
> To be able to support different firmwares and tuning
> for different models, the driver needs to be able to
> load a different firmware and coefficient file based
> on its Subsystem ID.
> 
> The driver attempts to load the firmware in the
> following order:
> 
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>-dev<#>.wmfw
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>.wmfw
> /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>.wmfw
> 
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
> ---

...

	    CS35L41_FIRMWARE_ROOT, NULL, NULL, "wmfw");
> +	if (!ret) {
> +		/* fallback try cirrus/part-dspN-fwtype.bin */
>   		cs35l41_request_firmware_file(cs35l41, coeff_firmware, coeff_filename,
> -					      CS35L41_FIRMWARE_ROOT, "bin");
> +					      CS35L41_FIRMWARE_ROOT, NULL, NULL, "bin");
>   		return 0;
>   	}
>   
> @@ -143,7 +183,6 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41,
>   	return ret;
>   }
>   
> -

You add unnecessary line in patch 4 and remove in this one?

>   static int cs35l41_init_dsp(struct cs35l41_hda *cs35l41)
>   {
>   	const struct firmware *coeff_firmware = NULL;