Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4600648iog; Wed, 22 Jun 2022 02:02:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sBFlp7U54ZERj6Tfcz4y6K7h5F6m/u36RVUZpW6bDB2N6g1Ags9X+s0n6LiiTAzW8mmCuz X-Received: by 2002:a17:902:cecf:b0:16a:416c:3d19 with SMTP id d15-20020a170902cecf00b0016a416c3d19mr4654752plg.137.1655888538358; Wed, 22 Jun 2022 02:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655888538; cv=none; d=google.com; s=arc-20160816; b=NWyo0LdfotzOo2A/b4NGeJrLfig/kjgsuC+j5Re/Y9OlxiuGC31s9rtDiDRdHl06nu PsL3jP/s6290NuI+913w5ats/Wy/rutLJs6NNU0g/vZQHaZNhWjZ0kU1FOdwAuP0tM9Q ZS5UbtuQ7OFWIpsnwkIgbnRPQBCpZzegChJJmFOi9m+05xdugcTimizSECcRTEB8eV84 waye9S+iIseV4lp9Q9SVYBxURX6cfZK/yxFC8XN011VPHYGGqfOAPB+5v0x74L6bLtu5 vktWVisrVtWVbZlxzSkNrrxjcgwJpfkGGD2Kjz3+vd+Ub+jHJJujCfwGtRozLh1ZoAOp 2hSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:abuse-reports-to:tuid:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=7ETrpxMLgua9cEN0+CwxKlgawvtoPUKzkX7OGSfuoLo=; b=i9bJGou2xvfW/bBhN6zwZVZJgICR667ooEktBZC7L+tNI3WJ+/XVl/nRPQD0VM+IJO zsqCmgOIN59J2I2WBixo4YH1DhuTYnS0VuRCsCFZEeZvjCWsMsw9ZCQynaA18Qo76u5R 3KwTWLCvUM6JP5r2Ywt5WrXw7DorvAW7m4SDsrMbbCVp6nrYXu+Iqg1SETK4Dnl5NAmR 1X7abD19CQGtIHJnHpK5xLtkiUCL8MHCxWEGSHa4+vPkZTWUBgnv8EPVESkVV2jPupQZ AiY29vEA6m+vcSxSqeciJETFsCRgE/LeNFLmVV+g9fGdeOoW6v6cH+u1KsrM3g94XNLy 7+Ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d19-20020aa797b3000000b0051bd4457edesi10727577pfq.161.2022.06.22.02.02.02; Wed, 22 Jun 2022 02:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353741AbiFVIvR (ORCPT + 99 others); Wed, 22 Jun 2022 04:51:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239184AbiFVIvQ (ORCPT ); Wed, 22 Jun 2022 04:51:16 -0400 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1675237A00 for ; Wed, 22 Jun 2022 01:51:13 -0700 (PDT) Received: from ([60.208.111.195]) by unicom146.biz-email.net ((D)) with ASMTP (SSL) id RGW00106; Wed, 22 Jun 2022 16:51:06 +0800 Received: from localhost.localdomain (10.200.104.82) by jtjnmail201610.home.langchao.com (10.100.2.10) with Microsoft SMTP Server id 15.1.2308.27; Wed, 22 Jun 2022 16:51:07 +0800 From: Deming Wang To: , CC: , , Deming Wang Subject: [PATCH] virtio_ring: remove unnecessary to_vvq call in vring hot path Date: Wed, 22 Jun 2022 04:51:05 -0400 Message-ID: <20220622085105.1910-1-wangdeming@inspur.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.200.104.82] tUid: 2022622165106131d92a2a1a6c5e0383f0cc5581afbc2 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It passes '_vq' to virtqueue_enable_cb_delayed_packed(), which still calls to_vvq to get 'vq', let's directly pass to_vvq to gunnecessary call of to_vvq in hot path. Signed-off-by: Deming Wang --- drivers/virtio/virtio_ring.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 13a7348cedff..4d41d5a90816 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1534,9 +1534,8 @@ static bool virtqueue_poll_packed(struct virtqueue *_vq, u16 off_wrap) return is_used_desc_packed(vq, used_idx, wrap_counter); } -static bool virtqueue_enable_cb_delayed_packed(struct virtqueue *_vq) +static bool virtqueue_enable_cb_delayed_packed(struct vring_virtqueue *vq) { - struct vring_virtqueue *vq = to_vvq(_vq); u16 used_idx, wrap_counter; u16 bufs; @@ -2098,7 +2097,7 @@ bool virtqueue_enable_cb_delayed(struct virtqueue *_vq) if (vq->event_triggered) vq->event_triggered = false; - return vq->packed_ring ? virtqueue_enable_cb_delayed_packed(_vq) : + return vq->packed_ring ? virtqueue_enable_cb_delayed_packed(vq) : virtqueue_enable_cb_delayed_split(_vq); } EXPORT_SYMBOL_GPL(virtqueue_enable_cb_delayed); -- 2.27.0