Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87dd706a-6777-374f-1d41-7d791727697f@kernel.org>
Date:   Wed, 22 Jun 2022 10:58:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v3] arm/mm: Fix refcount leak bugs in cache
Content-Language: en-US
To:     Liang He <windhl@126.com>, linux@armlinux.org.uk,
        rmk+kernel@armlinux.org.uk, wangkefeng.wang@huawei.com,
        ardb@kernel.org, arnd@arndb.de, akpm@linux-foundation.org,
        rppt@kernel.org
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220619013941.4061894-1-windhl@126.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20220619013941.4061894-1-windhl@126.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/06/2022 03:39, Liang He wrote:
> In feroceon_of_init() and tauros2_init(), of_find_matching_node()
> will return a node pointer with refcount incremented. We should
> use of_node_put() in fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v3: (1) merge arm/mm leak bugs (2) fix bugs intro-ed by v2
>  v2: (1) use real name (2) normalize coding style
>  v1: (1) fix leak bug
> 

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.


[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof