Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6abb20a4-1858-3e04-ed5b-dff18110e58a@kernel.org>
Date:   Wed, 22 Jun 2022 11:02:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
Content-Language: en-US
To:     Liang He <windhl@126.com>, tglx@linutronix.de, maz@kernel.org,
        linux-kernel@vger.kernel.org
References: <20220622062138.4095598-1-windhl@126.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20220622062138.4095598-1-windhl@126.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/06/2022 08:21, Liang He wrote:
> We need to add missing of_node_get() for of_find_matching_node() to
> keep refcount balance.
> 
> Note: of_find_matching_node() will decrease the refcount of its first
> arg.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 ++
>  1 file changed, 2 insertions(+)

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.


[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof