Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0b562d2-fd93-647f-0980-ceadb3a48677@gmail.com>
Date:   Wed, 22 Jun 2022 17:39:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
Content-Language: en-US
To:     Liang He <windhl@126.com>, Marc Zyngier <maz@kernel.org>
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org
References: <20220622062138.4095598-1-windhl@126.com>
 <87mte52khd.wl-maz@kernel.org>
 <229e8ea9.5a09.1818a7b7a35.Coremail.windhl@126.com>
 <87letp2j9e.wl-maz@kernel.org>
 <1b3e9050.5eb9.1818a8c64d3.Coremail.windhl@126.com>
From:   Miaoqian Lin <linmq006@gmail.com>
In-Reply-To: <1b3e9050.5eb9.1818a8c64d3.Coremail.windhl@126.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2022/6/22 16:34, Liang He wrote:
>
>
> At 2022-06-22 16:29:49, "Marc Zyngier" <maz@kernel.org> wrote:
>> On Wed, 22 Jun 2022 09:15:56 +0100,
>> "Liang He" <windhl@126.com> wrote:
>>>
>>>
>>> At 2022-06-22 16:03:26, "Marc Zyngier" <maz@kernel.org> wrote:
>>>> + Miaoqian Lin
>>>>
>>>> On Wed, 22 Jun 2022 07:21:38 +0100,
>>>> Liang He <windhl@126.com> wrote:
>>>>> We need to add missing of_node_get() for of_find_matching_node() to
>>>>> keep refcount balance.
>>>>>
>>>>> Note: of_find_matching_node() will decrease the refcount of its first
>>>>> arg.
>>>>>
>>>>> Signed-off-by: Liang He <windhl@126.com>
>>>> [...]
>>>>
>>>> Please send these refcount fixes as a series for all the irqchip
>>>> drivers, not one every other day.
>>>>
>>> Sorry, I will group similar bugs  in future.
>>>
>>>
>>>> And please synchronise with Miaoqian Lin, as you are obviously both
>>>> chasing the same bugs.
>>>>
>>>> Thanks,
>>>>
>>>> 	M.
>>> Yes, before I send any new bug, I will confirm that this bug has not
>>> been reported in lore.kernel.org.
>> This is not what I meant. I am asking you to actively coordinate with
>> Miaoqian, working with them as a team instead of you both sending
>> competing series. I would like to see one series with patches from you
>> both.
> OK, I get it. This depends on Miaoqian.

Sure, I would like to work with Liang to fix these bugs.

>
> @linm006@gmail.com
>
>>> By the way, this is a bug missing |GET|, not |PUT|, which is
>>> different with Miaoqian's and my patches before.
It's a nice catch and I haven't noticed before.
>> Well, yet another reason for you both to work together, as you are
>> complementing each other.
>>
>> Thanks,
>>
>> 	M.
>>
>> -- 
>> Without deviation from the norm, progress is not possible.