Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4649287iog; Wed, 22 Jun 2022 03:08:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t/sPItZLjxtYueocCB09FKtuHdC2DITzEhsI1ByXEXBA9RDmNIjecJiWtsnXiTe3r4raYc X-Received: by 2002:a17:906:106:b0:722:e997:a365 with SMTP id 6-20020a170906010600b00722e997a365mr2322836eje.169.1655892515426; Wed, 22 Jun 2022 03:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655892515; cv=none; d=google.com; s=arc-20160816; b=k2nn1lN6CeaJdxLFaswIoB9tdWxmQmg2+npd9kJLboVXHHG/EqHD6o6hPCG5GBmXGE AG3ViBWOrmnv708a1xdiJCnOjGpg3eIxo6oKXqro560O7t/uQNmNULJHLAuF1NgFho1S ZcPr9uD0sJaUUZSjBF0nxTTmhBNaLT6uG2Sgsao2Us5eL2RfpreggFqOVmGLgfpeZ0CF ELM2NCLYenc1KRjcscxEeifLWY9gAvJeke2aKp4em7ECrE0Z99WY2kgYfu3rPX/s7Ucr TqtYu0GmBR1c9+iSHDLFn4I5HhdSwQUZ7d0ziz//hKmARrXndpSh2GnJ43IxT+SnZ3gZ IMUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=aEnj6RSsJ68f2qx5PM9IqL6QL82fSufUdWRfkS5+iAA=; b=ZDJ4kHmci9m6+icmV4t6zj7zrjmf5pqDq0uAv/nlLhq7UIgTgj6oyhC0JF92txK2/G CzLRQqc3NSpvXlAnANyAzsnjAJHaUIcXkPB75U0y+JKUG9v3RgKvJxWvm5r/7amYnaKl p1dWxCmOjg6V0DLPp7gUfwh+7o5Z7ddks3gWhRLu4kMVsjc8jR8kEUUkGkOUxD08Q17R B3n9f6BuCFf+EspfMxw+JfKCOVotZQXXxWQ4zM9tuut2WUcOcAWs4iTzyo9VO8BCWfa2 n5Dr546FYKIcrljUk2TYWIVF0OdYGShTRChUH0fFaszaqtDcRv8y4TkZMIkn+aQWYn90 xRcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="P/wR+uyu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc6-20020a170907168600b007120fe3e4acsi20487966ejc.680.2022.06.22.03.07.48; Wed, 22 Jun 2022 03:08:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="P/wR+uyu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237687AbiFVJQi (ORCPT + 99 others); Wed, 22 Jun 2022 05:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238121AbiFVJQh (ORCPT ); Wed, 22 Jun 2022 05:16:37 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3232738 for ; Wed, 22 Jun 2022 02:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=aEnj6RSsJ68f2qx5PM9IqL6QL82fSufUdWRfkS5+iAA=; b=P/wR+uyuuu6pIDsy9EOwy5IaYvuvHHCH05sCASsfRHcSpN9pr80dXjvj se2+CYt/6GsY2c5NeRNf898tZ3U1jwh7nmKJ6RIYZckV3VgzOqwbqsc+C F0Pz2+4SySCfBoUOm8Z+XS4PKvVHOPNofni0+mii9t/QJAdPEfi69NEKU 4=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.92,212,1650924000"; d="scan'208";a="17472762" Received: from 71-51-165-43.chvl.centurylink.net (HELO hadrien.PK5001Z) ([71.51.165.43]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 11:16:32 +0200 Date: Wed, 22 Jun 2022 05:16:21 -0400 (EDT) From: Julia Lawall X-X-Sender: julia@hadrien To: Shahab Vahedi cc: Bagas Sanjaya , Jilin Yuan , "vgupta@kernel.org" , "Julia.Lawall@inria.fr" , "rdunlap@infradead.org" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments In-Reply-To: <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com> Message-ID: References: <20220622080423.41570-1-yuanjilin@cdjrlc.com> <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 10:30, Bagas Sanjaya wrote: > > > I think that this kind of cleanup patches (typofixes) are best done > > as part of **actual** work on the code in question (for example > > refactoring or fixing build errors). > > Amen! So code that is fine will have typos forever? Fixing typos in comments doesn't break git blame for the following code. And typos in comments give a bad impression about the state of the code in general. But that is a general statement. Perhaps this code does particularly need work. julia