Subject: Re: [RFC] LZO de/compression support - take 3
From: Richard Purdie <richard@openedhand.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael-Luke Jones <mlj28@cam.ac.uk>,
       Nitin Gupta <nitingupta910@gmail.com>, linux-kernel@vger.kernel.org,
       linux-mm-cc@laptop.org
In-Reply-To: <20070524155428.55460e9c.akpm@linux-foundation.org>
References: <4cefeab80705230127r58e8f9e1sa644092e95eb81eb@mail.gmail.com>
	 <0F6CEFD7-86F2-4903-B4F7-F723DF88BE9A@cam.ac.uk>
	 <4cefeab80705230439n6bbb1259le3c3b9704ce49b75@mail.gmail.com>
	 <624FD7A7-5552-415F-96D8-4353453EA2A3@cam.ac.uk>
	 <4cefeab80705230703vdb3c414s250a61c4c2d70c51@mail.gmail.com>
	 <1CF43BBC-79EF-449B-A398-AE374E399573@cam.ac.uk>
	 <4cefeab80705230721i492b5f1ehfa2d775344b1c04e@mail.gmail.com>
	 <726113DF-D952-401F-96EA-7A10B035604B@cam.ac.uk>
	 <1180046482.12821.42.camel@localhost.localdomain>
	 <20070524155428.55460e9c.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Fri, 25 May 2007 00:00:43 +0100
Message-Id: <1180047643.12821.53.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 23

On Thu, 2007-05-24 at 15:54 -0700, Andrew Morton wrote:
> On Thu, 24 May 2007 23:41:22 +0100
> Richard Purdie <richard@openedhand.com> wrote:
> 
> > I'll not send a "rename to unsafe" patch for the LZO core until Andrew
> > decides whether to drop the unsafe version entirely or not as per your
> > patch. If he doesn't due to the potential use by the compressed cache
> > people, I will send that patch.
> 
> I'd have thought that a 3% performance difference isn't worth worrying
> about.  Especially when reclaiming that 3% costs an additional 500 lines
> of pretty yukky code.

7% since the 3% applied to code that was over twice as slow in the first
place!

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/