Date: Thu, 24 May 2007 16:59:47 -0700 (PDT)
Message-Id: <20070524.165947.09931811.davem@davemloft.net>
To: vvs@sw.ru
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org, akpm@osdl.org,
       linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH netdev] "wrong timeout value" in sk_wait_data() v2
From: David Miller <davem@davemloft.net>
In-Reply-To: <46552142.4090801@sw.ru>
References: <465512EB.4000808@sw.ru>
	<46551635.30809@cosmosbay.com>
	<46552142.4090801@sw.ru>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 25

From: Vasily Averin <vvs@sw.ru>
Date: Thu, 24 May 2007 09:23:14 +0400

> sys_setsockopt() do not check properly timeout values for
> SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout
> values. POSIX do not defines behaviour for sys_setsockopt in case negative
> timeouts, but requires that setsockopt() shall fail with -EDOM if the send and
> receive timeout values are too big to fit into the timeout fields in the socket
> structure.
> In current implementation negative timeout can lead to error messages like
> "schedule_timeout: wrong timeout value".
> 
> Proposed patch:
> - checks tv_usec and returns -EDOM if it is wrong
> - do not allows to set negative timeout values (sets 0 instead) and outputs
> ratelimited information message about such attempts.
> 
> Signed-Off-By:	Vasily Averin <vvs@sw.ru>

Thank you for this bug fix, patch applied.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/