Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 15:43:13 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: sc8280xp: Add reference device
Message-ID: <YrMccQXwsz/zC/gl@hovoldconsulting.com>
References: <20220622041224.627803-1-bjorn.andersson@linaro.org>
 <20220622041224.627803-5-bjorn.andersson@linaro.org>
 <099cc82f-d52f-315f-189d-bcc40c1afd49@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <099cc82f-d52f-315f-189d-bcc40c1afd49@somainline.org>
Precedence: bulk

On Wed, Jun 22, 2022 at 02:33:02PM +0200, Konrad Dybcio wrote:
> On 22.06.2022 06:12, Bjorn Andersson wrote:

> > +&qup2_i2c5 {
> > +	clock-frequency = <400000>;
> > +
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&qup2_i2c5_default>, <&kybd_default>, <&tpad_default>;
> > +
> > +	status = "okay";
> > +
> I think all device DTs generally have 'status = "okay"' at the beginning. Should we change that?
> 

No, quite the opposite, status go at the end.

(And please break your lines at 72 cols or so).

> > +
> > +/* PINCTRL - additions to nodes defined in sc8280xp.dtsi */
> This comment seems redundant.

Nope, it's a marker that explains why the pinctrl nodes are seemingly
out of sort order. We've decided to group them all at the end.

But sure "- additions to nodes defined in sc8280xp.dtsi" could be moved
since we also have PMIC pinctrl nodes here (as I just did for the x13s
dts).

> 
> > +
> > +&pmc8280_1_gpios {
> > +	edp_bl_en: edp-bl-en-state {
> > +		pins = "gpio8";
> > +		function = "normal";
> > +	};
> > +
> > +	edp_bl_reg_en: edp-bl-reg-en-state {
> > +		pins = "gpio9";
> > +		function = "normal";
> > +	};
> > +
> > +	misc_3p3_reg_en: misc-3p3-reg-en-state {
> > +		pins = "gpio1";
> > +		function = "normal";
> > +	};
> > +};

> > +	tpad_default: tpad-default-state {
> > +		int-n {
> If you aren't gonna add more pins to this touchpad block, I think you could drop this extra level.

You'd just lose information (what the pin is used for) with no real
gain.

> > +			pins = "gpio182";
> > +			function = "gpio";
> > +			bias-disable;
> > +		};
> > +	};

Johan